From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D03BD10F58 for ; Wed, 26 Nov 2025 15:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EXWqkoqzdsg8oaAn0JlO2ztf4lGMKOe3E9VhGoHX014=; b=Yv3IQTZnDbMty4TJEP5PQ7gooS umVuWwzfdQiXDmjtAdveU9dLG4wARymGNib/vrfywQSo+RMI4KidzpcStMcsuJY90q1jptcvvMiQ1 azxvaVID6uL5RUOG2i2h/MBg+uSripOhoqtlgDqkTol+JhQk8W0agZr46NMs2uxQvmpnaF/jJ1S0b 2MpdTs8l7NWK2UdH4fQ3Naa2i0olO/uG/BzD+8dtK0KDQn+XufXFqR9le7Oo992XPgtBLTlpJ7XdF A9adT0Uj1k0vtubivnC+4BRp9h57Tz6kSOpJX9l8ceDqtm1DJeZJ+8mAPZnVO3AMzg0aU+ZlbJbrG QQFxr2Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOHZc-0000000FC3i-1j5b; Wed, 26 Nov 2025 15:36:52 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOHZa-0000000FC3a-3GLn for linux-arm-kernel@lists.infradead.org; Wed, 26 Nov 2025 15:36:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id DB8F060215; Wed, 26 Nov 2025 15:36:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B62AC4CEF7; Wed, 26 Nov 2025 15:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764171409; bh=/8FCdi6x7TLlipr8hT2p3sBnfBjielKdgUHYCnvkaz8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dMxyN/yd84PF0UFsoBD7f/uvgZOCAUi4bi2Fr5AsEBGL5JKS1GVDnm+gAiHYm0y8Y oAXMFqfLjI0cDIrtgj1GdWXqUdugXrr1PU8DbXSFC3iPbTXfwlSp2EQuswAdPA+tzK U7f/GWpqjquUkgotOswxehle/8uSfek68hlUMcm0uL2TSUicGQdDurVALA3xoHlW2u 0mU4otPW+NMBOZgHBA0BIoETN7jCiGC5tjYxUtRvSHr5dGX9B8+Kv1hnjpD1IaPbs2 3JhtF0cjRci3stnOp2FBoe5ls9eE0/Va0tDuKBCcf7SdiIcn140Hlnbu29884iQCCO ZqFwm41AxSM9Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vOHZX-00000008WTd-19m0; Wed, 26 Nov 2025 15:36:47 +0000 Date: Wed, 26 Nov 2025 15:36:46 +0000 Message-ID: <864iqgrek1.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, vladimir.murzin@arm.com Subject: Re: [PATCH v5 5/9] KVM: arm64: Include VM type when checking VM capabilities in pKVM In-Reply-To: References: <20251118103807.707500-1-tabba@google.com> <20251118103807.707500-6-tabba@google.com> <867bvdqd4m.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, vladimir.murzin@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 26 Nov 2025 11:00:47 +0000, Fuad Tabba wrote: > > Hi Marc, > > I agree, but I don't think this patch changes this behavior. Later on > in this series we expand the check to apply to non-protected VMs to > also restrict features that are not allowed in protected mode in > general -- something that until this series we didn't have. Ah, you are correct. Apologies for being so thick. Still, I think we need to do something here -- the whole extension check without context is just broken. Thanks, M. -- Without deviation from the norm, progress is not possible.