From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A663C71133 for ; Tue, 10 Jun 2025 22:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: MIME-Version:References:In-Reply-To:Subject:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=97Ba4p5+Da+pz4mXZxIYLElnOJquFiCGTZedLlNMizY=; b=crczoHf3bMg9ENiXG4hqCwdh5b SJWO3vcseQi8Tcrxs7o8/Zi7xZkoy0jukbduygown4s01suZt/syrOgl4e/TsUijEd88QLVZO5jgh TARVdK5kSY18wHvVqJT3BQZ9BWQxiRtwdPtn43Rv6loDPnwItVCcg+uVT2GSo3vvUZkxde6j1eW26 07Nbh05MDXFzXfXAolNH5TMTG1ZS8PJqDW5AgtDNxBUsGAi9t/mzVbAHE/VMmIhyqX/4MrDue5uMx qnWq3VER3gFPzokn9U4sEiaIzV+mhceUq/yXU/hBjn0/RbFwb2Uewoqk+A/UyMI81qdXb+jPolYfU LyPszUGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uP7lB-00000008EcD-1xZN; Tue, 10 Jun 2025 22:48:01 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uP2M0-00000007Yl3-18CJ for linux-arm-kernel@lists.infradead.org; Tue, 10 Jun 2025 17:01:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2BD15A514E0; Tue, 10 Jun 2025 17:01:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6B54C4CEED; Tue, 10 Jun 2025 17:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749574898; bh=w7A2d0/ZPQU1PcKL9vOuHlBvVkGEXfQTlobUa93FGTM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HTUGdKBSck1rEp0kYQFUjdP88z9Ava2g7ZcwFJBewIGHYzspMPQZThx+s56gFtSq/ wUZK+LZg1YSRAouIphy7nSud0KdzfDxQHTcGFTt7U7Y2HFDiURxaj5D/BI0qBYxhz5 wF66Rfwk4V4jSV8lkJdi6VIONdIZXnGixeHIqM5WdhXPlKjWXYf2qLkOJI4fQyH1av Tdqb/Z/Qt/qHaSbqYDuB3KilGGY0ytG4zibtLUMLcKAAgCAIpYBkYYct3Cb3LvzpoM V8G0VuCYdWoA1QmapPcgN+9uheedSYkMWDSr8FTFOajsblcx4Vtg+Kh9oCxZsneG8E JPgyLVH9TkZSA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uP2Lw-005aZO-Cj; Tue, 10 Jun 2025 18:01:36 +0100 Date: Tue, 10 Jun 2025 18:01:35 +0100 Message-ID: <864iwnedjk.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Subject: Re: [PATCH V3 2/2] KVM: selftests: Change MDSCR_EL1 register holding variables as uint64_t In-Reply-To: <20250610053128.4118784-3-anshuman.khandual@arm.com> References: <20250610053128.4118784-1-anshuman.khandual@arm.com> <20250610053128.4118784-3-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, ada.coupriediaz@arm.com, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250610_100140_457006_8FDAF953 X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , linux-kselftest@vger.kernel.org, kvmarm@lists.linux.dev, Will Deacon , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Jun 2025 06:31:28 +0100, Anshuman Khandual wrote: > > Change MDSCR_EL1 register holding local variables as uint64_t that reflects > its true register width as well. > > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Joey Gouly > Cc: kvm@vger.kernel.org > Cc: kvmarm@lists.linux.dev > Cc: linux-kernel@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Reviewed-by: Ada Couprie Diaz > Signed-off-by: Anshuman Khandual > --- > tools/testing/selftests/kvm/arm64/debug-exceptions.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/arm64/debug-exceptions.c b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > index c7fb55c9135b..e34963956fbc 100644 > --- a/tools/testing/selftests/kvm/arm64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > @@ -140,7 +140,7 @@ static void enable_os_lock(void) > > static void enable_monitor_debug_exceptions(void) > { > - uint32_t mdscr; > + uint64_t mdscr; > > asm volatile("msr daifclr, #8"); > > @@ -223,7 +223,7 @@ void install_hw_bp_ctx(uint8_t addr_bp, uint8_t ctx_bp, uint64_t addr, > > static void install_ss(void) > { > - uint32_t mdscr; > + uint64_t mdscr; > > asm volatile("msr daifclr, #8"); > Why change this in the place that matters *the least*? arch/arm64/kernel/debug-monitors.c is full of 32bit manipulation of this register, and that's only one example of it. So if you are going to change this, please do it fully, not as a random change in a random file. Thanks, M. -- Without deviation from the norm, progress is not possible.