From: Marc Zyngier <maz@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v2 3/3] arm64: Rename reserved values for CTR_EL0.L1Ip
Date: Wed, 29 Nov 2023 13:06:11 +0000 [thread overview]
Message-ID: <864jh4d7zw.wl-maz@kernel.org> (raw)
In-Reply-To: <aeefd47d-60a8-4011-bd26-f520b9333e20@arm.com>
On Wed, 29 Nov 2023 07:13:57 +0000,
Anshuman Khandual <anshuman.khandual@arm.com> wrote:
>
>
>
> On 11/27/23 22:56, Marc Zyngier wrote:
> > We now have *two* values for CTR_EL0.L1Ip that are reserved.
> > Which makes things a bit awkward. In order to lift the ambiguity,
> > rename RESERVED (0b01) to RESERVED_AIVIVT, and VPIPT (0b00) to
> > RESERVED_VPIPT.
> >
> > This makes it clear which of these meant what, and I'm sure
> > archeologists will find it useful...
> >
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > ---
> > arch/arm64/tools/sysreg | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> > index 96cbeeab4eec..5a217e0fce45 100644
> > --- a/arch/arm64/tools/sysreg
> > +++ b/arch/arm64/tools/sysreg
> > @@ -2004,9 +2004,10 @@ Field 27:24 CWG
> > Field 23:20 ERG
> > Field 19:16 DminLine
> > Enum 15:14 L1Ip
> > - 0b00 VPIPT
> > + # This was named as VPIPT in the ARM but now documented as reserved
> > + 0b00 RESERVED_VPIPT
> > # This is named as AIVIVT in the ARM but documented as reserved
> > - 0b01 RESERVED
> > + 0b01 RESERVED_AVIVT
>
> s/RESERVED_AVIVT/RESERVED_AIVIVT - matches the spec. Commit message
> has got this right.
Huh, how embarrassing. Thanks for pointing this out, I'll fix it in
the next round.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-29 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 17:26 [PATCH v2 0/3] arm64: Drop support for VPIPT i-cache policy Marc Zyngier
2023-11-27 17:26 ` [PATCH v2 1/3] KVM: arm64: Remove VPIPT I-cache handling Marc Zyngier
2023-11-29 7:36 ` Anshuman Khandual
2023-11-27 17:26 ` [PATCH v2 2/3] arm64: Kill detection of VPIPT i-cache policy Marc Zyngier
2023-11-29 7:25 ` Anshuman Khandual
2023-11-27 17:26 ` [PATCH v2 3/3] arm64: Rename reserved values for CTR_EL0.L1Ip Marc Zyngier
2023-11-29 7:13 ` Anshuman Khandual
2023-11-29 13:06 ` Marc Zyngier [this message]
2023-11-29 6:31 ` [PATCH v2 0/3] arm64: Drop support for VPIPT i-cache policy Anshuman Khandual
2023-12-04 13:09 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jh4d7zw.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).