Re: [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro

[Olivier Benjamin <olivier.benjamin@bootlin.com>]

On 6/18/25 15:54, Diederik de Haas wrote:
> On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote:
>> As documented in its bindings, the compatible for the Himax HX8394
>> MIPI-DSI LCD panel controller is in 2 parts.
>> The PinePhone Pro DTS currently only specifies the first part of the
>> compatible, generating a warning.
>>
>> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> index 04ba4c4565d0a205e2e46d7535c6a3190993621d..5ebc380a24df86ba7172b0950b89cac56b61c507 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> @@ -479,7 +479,7 @@ mipi_out_panel: endpoint {
>>   	};
>>   
>>   	panel@0 {
>> -		compatible = "hannstar,hsd060bhw4";
>> +		compatible = "hannstar,hsd060bhw4", "himax,hx8394";
>>   		reg = <0>;
>>   		backlight = <&backlight>;
>>   		reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
> 
> Reviewed-by: Diederik de Haas <didi.debian@cknow.org>
> 
Thanks for the review.
> But I'd actually suggest to combine it with patch 3 and use that
> opportunity to also fix the property sorting, so you'd get 1 patch which
> fixes all of the panel issues.
> 
Makes sense, I'll integrate your suggestions from the other 2 patches, 
fix the property sorting, and squash the fixes into 1 commit/patch in v2.
> Cheers,
>    Diederik

-- 
Olivier Benjamin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com