From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49410606A31C for ; Wed, 18 Nov 2026 11:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HTLKYVvD; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jHYmmH/C DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Emak8Lm259YoIJ5aFedEql1wejCbZp03w6luolSmcoo=; b=HTLKYVvDfU5NOl2y26jJ1IwQ9N IsfozNO8PJvl7xf8oZjdncZDIaI8oQAvp1hPUjk2N4oNP8X9rromtRyxhk1MazQHsgqcGa4ZkKfOD ViQ9YLAwGnGZiSE8biS+XyJrBryWK7Q1nYpLDxQSi4ep0ejvp3fi8pQ4xMP+Up0nesBPq52oSj9r9 h1c3zR3dw8ntlqOi05ucmJufDUIrdJjfjayphpZUNnvSiP4/jlFdx3DeI6odMgKV2jMsgBv3PSkl9 u1F0P3K7EexIzJBz8kbYYOD3Abc/o1+u8M6kJFno9NCLJ3tr8gq9y1NlXJTGVt5rUswwz61MS0+zR KBDNONxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTdbr-00000008gdH-0908; Wed, 18 Nov 2026 11:13:51 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTdbp-00000008gcz-1Lf6 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2026 11:13:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 53B19600B4; Wed, 18 Nov 2026 11:13:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08C251F000C4; Wed, 18 Nov 2026 11:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795000428; bh=Emak8Lm259YoIJ5aFedEql1wejCbZp03w6luolSmcoo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jHYmmH/CEPhhkA1F8K8VYzo6YYE/AvQW1kkuC2JZXWBZwjm1c+nbxUS0AjGQHmPXi tu3TYIhPlm/n57dvSP9+IoyYSUsK/BKK5nzd0AROgWHBP7d8NkQoYVvKUBj4iv4lCq TZI4MkL4XlI3QhwmqmfCijlrudzXysUPPHFrwZthQzbUcrfr+1wiZw3yVbb/UHQbaA /+L/LYWBk9weInCbSqtTdVCUpSdY+bpP3VVIiyKX8Blh1ZS6M02BnRJrylWzO7yapj PE4PXTFvLmDk8C/qIMKChnU4zPK7Ki0C3gGgoFLwpkgDVx5XOyobvdnUAND90Rzp57 N9mmUV5pU6W5A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xTdbl-0000000HUEo-2k8X; Wed, 18 Nov 2026 11:13:45 +0000 Date: Wed, 18 Nov 2026 11:13:45 +0000 Message-ID: <865wxu1jfa.wl-maz@kernel.org> From: Marc Zyngier To: myrialsarvay@gmail.com Cc: Will Deacon , Mark Rutland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sven Peter , Janne Grunau , Neal Gompa , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, Yuvan Shen Subject: Re: [PATCH v2 02/15] drivers/perf: apple_m1: Remove unused variables In-Reply-To: <20261107-m3-plus-pmu-events-v2-2-acf1e78da039@gmail.com> References: <20261107-m3-plus-pmu-events-v2-0-acf1e78da039@gmail.com> <20261107-m3-plus-pmu-events-v2-2-acf1e78da039@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Archived-By: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: myrialsarvay@gmail.com, will@kernel.org, mark.rutland@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sven@kernel.org, j@jannau.net, neal@gompa.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, yuvanshen09@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Sat, 07 Nov 2026 10:48:49 +0000, Myria Sarvay via B4 Relay wrote: > > From: Myria Sarvay > > These variables are calculated elsewhere as well, remove the extra dead > code. > > Signed-off-by: Myria Sarvay > Fixes: a639027a1be1 ("drivers/perf: Add Apple icestorm/firestorm CPU PMU driver") Not quite. In this patch, the variables were very much in use. They became useless with 75ecffc361bbc ("drivers/perf: apple_m1: Refactor event select/filter configuration"). Please adjust the tag accordingly, or just drop it because this really isn't a fix, only a minor cleanup. Thanks, M. -- Without deviation from the norm, progress is not possible.