From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29076CD5BAC for ; Thu, 21 May 2026 14:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4yY0xLPIUePUsfft08eVBYhbYc5qg6P6+d9+9o4MEh0=; b=LcMN1VYviZPSwF3dxg0Uk2OEB5 DPdgDZTV2X/AXfJF0ZpmabkqBzP6cTUTsfAw37FmVoEf8DHX9KZI8F3AljOv7GW236aKHc38UY/RQ fnxFDptjSHdGGF7/96y4C44HehWBUZvWWJ9d66JqjQeJKh9Vhx7Qe3KJQrK+t9U5qeYEm3yC6KGhO 8a8Xv00Rb7vzUWeaeybClpoyPQUzL1BRZ4lg0geF+AK3MSC9tGijk1xJXran6PlE3tgmRWp62FlRb G9KWM/S6yZER+Cp2d/MC/9FUMA8F+A7KkkFz0LqFX9pLdn0j5zBh3tSWXCLgD0BNtYcqfB5dr/q7T wA9Y6uYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ4KR-000000083Gw-1Cwd; Thu, 21 May 2026 14:24:51 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ4KQ-000000083Gm-36d5 for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2026 14:24:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 08123600C3; Thu, 21 May 2026 14:24:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18C21F000E9; Thu, 21 May 2026 14:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779373489; bh=4yY0xLPIUePUsfft08eVBYhbYc5qg6P6+d9+9o4MEh0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=L0Fz94HId7nM2n3maEesRvPcRv33MSDQBBHbK6gKVdbWaWZo9I5zGOCXdawiZtc9O 4+a25ntNE1afgzE5DRoDAitfZ4P6ha5UKZKeSRijxWH0E/UBx37rk5yb9xm/CSQF+F mqL/0EAQk4bug9vFmTNNAy08j/p3VA9MCOso/kAhYDrSm1cEAckwPkXVZEMgtYFoQ2 uZVtuSmc+Q/PSBcGT4UdnJwWp4SUGdx339QNO4jU73mcA5jXczC7kiRjEqz/PNThVt +lKfYIagRozrqoN8ujsl5/Iffb/JgEPgzxutFlZ04Dvl4GHr+OS4nIGzSZcZPHjd3W 2RzR8c5SBbw8Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wQ4KN-00000004ruq-3M92; Thu, 21 May 2026 14:24:47 +0000 Date: Thu, 21 May 2026 15:24:47 +0100 Message-ID: <865x4gx2kw.wl-maz@kernel.org> From: Marc Zyngier To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com Subject: Re: [PATCH v14 08/44] arm64: RMI: Ensure that the RMM has GPT entries for memory In-Reply-To: <868q9cx4ac.wl-maz@kernel.org> References: <20260513131757.116630-1-steven.price@arm.com> <20260513131757.116630-9-steven.price@arm.com> <868q9cx4ac.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: steven.price@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com, alexandru.elisei@arm.com, christoffer.dall@arm.com, tabba@google.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, gshan@redhat.com, sdonthineni@nvidia.com, alpergun@google.com, aneesh.kumar@kernel.org, fj0570is@fujitsu.com, vannapurve@google.com, WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 May 2026 14:47:55 +0100, Marc Zyngier wrote: > > On Wed, 13 May 2026 14:17:16 +0100, > Steven Price wrote: > > > > +/* > > + * For now we set the tracking_region_size to 0 for RMI_RMM_CONFIG_SET(). > > + * TODO: Support other tracking sizes (via Kconfig option). > > + */ > > +#ifdef CONFIG_PAGE_SIZE_4KB > > +#define RMM_GRANULE_TRACKING_SIZE SZ_1G > > +#elif defined(CONFIG_PAGE_SIZE_16KB) > > +#define RMM_GRANULE_TRACKING_SIZE SZ_32M > > +#elif defined(CONFIG_PAGE_SIZE_64KB) > > +#define RMM_GRANULE_TRACKING_SIZE SZ_512M > > +#endif > > Basically, a level 2 mapping. Which means this whole block really is: > > #define RMM_GRANULE_TRAKING_SIZE (2 * PAGE_SHIFT - 3) Obviously wrong: #define RMM_GRANULE_TRAKING_SIZE BIT(2 * PAGE_SHIFT - 3) M. -- Without deviation from the norm, progress is not possible.