From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC74FCA0FF9 for ; Sat, 30 Aug 2025 00:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JfkmV+5v8BTOLyl6Bi0vtJUA82MgjJ6KKX2jqfeKbuA=; b=4VmloelmRZEUA/95Qf5PxcdhAu 6SFfnYpqvjV2ibOYrknNxFAYPDzmLXnLDXeodAe9l/gs4aCKtgxLaz8QETgjCFlcgI+3z9KWNS3Cw K6g+TSxjwtphOHv0Dc9ACWhnj7s1SsZCaAbmq83QGJSewAqfCekO8/FD5JctcbP3yhMNQ2NwjbIqf oTdJJe9YreOM05D8dtVEyUZr6UNLGRQkpZAFsKA6e+QUg6BPspYoz64gFJpU9BfXnF0O3E+vuXUne AVlYNZFw/ntjaeO05DCVFYfTBFbR8Cfn4jZwFHeG7S4pKP0xUKMZ+uvGc/vu9e6E4lgbZAOPqfB9a 7Sj5eYfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1us9ix-000000077Xb-1tTh; Sat, 30 Aug 2025 00:45:43 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1us0ef-000000068r4-0Usw for linux-arm-kernel@lists.infradead.org; Fri, 29 Aug 2025 15:04:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D1FA9601A9; Fri, 29 Aug 2025 15:04:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8579BC4CEF0; Fri, 29 Aug 2025 15:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756479878; bh=h0bS6nde0r5gPiUlkTLFoDI7mpvVlgMMqMLvnUG6IGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RqeIBF0UEpPPXZ8Lr7uMRvz6xHJVBjbvYR9KCy/1NpxMORLmELCKYMyBYqzsMcMM3 sgsCiDaqmAsaw7RutTdHHY6sjB1FgxYsZC5ym3/fmXM9FrE+hhRCx0Iebze3Sg9oBA W2KQq26lDddF8t4RF+FZMvT4lOwcrnMDWoMqqPf8c6hyrbGzq/fF/OKb5uACwwgvFH 1K8f7SmRRtk+XhPFWL6ykuLYu76wRsriU+or/uwP3H/fTCTuUdF+lfjuD13xjnSkCS X6V2R55u4Q29xzkRfJjZaGOIsNwfzMJxQagTS0DkGxUpyvGkVUvRe6aWO1vO6CjG5a P6ajjgDUqVK8w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1us0ea-00000001cZ8-13qy; Fri, 29 Aug 2025 15:04:36 +0000 Date: Fri, 29 Aug 2025 16:04:35 +0100 Message-ID: <865xe6dv98.wl-maz@kernel.org> From: Marc Zyngier To: Qianfeng Rong Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: Use int type to store negative error codes In-Reply-To: <20250829132020.82077-1-rongqianfeng@vivo.com> References: <20250829132020.82077-1-rongqianfeng@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rongqianfeng@vivo.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Aug 2025 14:20:19 +0100, Qianfeng Rong wrote: > > Change the 'ret' variable from unsigned int to int to store negative error > codes or zero returned by other functions. > > Storing the negative error codes in unsigned type, doesn't cause an issue > at runtime but it's ugly. Additionally, assigning negative error codes to > unsigned type may trigger a GCC warning when the -Wsign-conversion flag is > enabled. > > Signed-off-by: Qianfeng Rong For the GICv3 code: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.