* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
@ 2013-08-20 11:22 Bartlomiej Zolnierkiewicz
2013-08-20 12:13 ` Tomasz Figa
2013-09-23 16:01 ` Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-08-20 11:22 UTC (permalink / raw)
To: linux-arm-kernel
Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires
'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one
(0x12850000). Fix it by overriding the default PL330 MDMA1 address in
exynos4210-universal_c210.dts.
This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent
regression caused by conversion to DT-only setup on ARM EXYNOS.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 889cdad..d2e3f5f 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -350,3 +350,7 @@
status = "okay";
};
};
+
+&mdma1 {
+ reg = <0x12840000 0x1000>;
+};
--
1.8.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
2013-08-20 11:22 [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board Bartlomiej Zolnierkiewicz
@ 2013-08-20 12:13 ` Tomasz Figa
2013-09-23 16:01 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-08-20 12:13 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bart,
On Tuesday 20 of August 2013 13:22:45 Bartlomiej Zolnierkiewicz wrote:
> Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires
> 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one
> (0x12850000). Fix it by overriding the default PL330 MDMA1 address in
> exynos4210-universal_c210.dts.
>
> This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
> PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent
> regression caused by conversion to DT-only setup on ARM EXYNOS.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> b/arch/arm/boot/dts/exynos4210-universal_c210.dts index 889cdad..d2e3f5f
> 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -350,3 +350,7 @@
> status = "okay";
> };
> };
> +
> +&mdma1 {
> + reg = <0x12840000 0x1000>;
> +};
Acked-by: Tomasz Figa <t.figa@samsung.com>
As a side note for other reviewers, Universal C210 is the only board based
on Exynos4210 rev0, so board-level dts is the right place for such
override.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
2013-08-20 11:22 [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board Bartlomiej Zolnierkiewicz
2013-08-20 12:13 ` Tomasz Figa
@ 2013-09-23 16:01 ` Bartlomiej Zolnierkiewicz
2013-09-24 10:38 ` Kukjin Kim
1 sibling, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-23 16:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kukjin,
Could you please apply this patch?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Tuesday, August 20, 2013 01:22:45 PM Bartlomiej Zolnierkiewicz wrote:
> Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires
> 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one
> (0x12850000). Fix it by overriding the default PL330 MDMA1 address in
> exynos4210-universal_c210.dts.
>
> This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
> PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent
> regression caused by conversion to DT-only setup on ARM EXYNOS.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index 889cdad..d2e3f5f 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -350,3 +350,7 @@
> status = "okay";
> };
> };
> +
> +&mdma1 {
> + reg = <0x12840000 0x1000>;
> +};
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
2013-09-23 16:01 ` Bartlomiej Zolnierkiewicz
@ 2013-09-24 10:38 ` Kukjin Kim
2013-09-24 10:41 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2013-09-24 10:38 UTC (permalink / raw)
To: linux-arm-kernel
Bartlomiej Zolnierkiewicz wrote:
>
>
> Hi Kukjin,
>
Hi Bart,
> Could you please apply this patch?
>
Can you make sure there is no rev1 for universal c210 board?
- Kukjin
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> On Tuesday, August 20, 2013 01:22:45 PM Bartlomiej Zolnierkiewicz wrote:
> > Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires
> > 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one
> > (0x12850000). Fix it by overriding the default PL330 MDMA1 address in
> > exynos4210-universal_c210.dts.
> >
> > This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
> > PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent
> > regression caused by conversion to DT-only setup on ARM EXYNOS.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > index 889cdad..d2e3f5f 100644
> > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > @@ -350,3 +350,7 @@
> > status = "okay";
> > };
> > };
> > +
> > +&mdma1 {
> > + reg = <0x12840000 0x1000>;
> > +};
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
2013-09-24 10:38 ` Kukjin Kim
@ 2013-09-24 10:41 ` Bartlomiej Zolnierkiewicz
2013-10-07 22:11 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-24 10:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tuesday, September 24, 2013 07:38:13 PM Kukjin Kim wrote:
> Bartlomiej Zolnierkiewicz wrote:
> >
> >
> > Hi Kukjin,
> >
> Hi Bart,
>
> > Could you please apply this patch?
> >
> Can you make sure there is no rev1 for universal c210 board?
Universal C210 always used Exynos4210 rev0.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> - Kukjin
>
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >
> > On Tuesday, August 20, 2013 01:22:45 PM Bartlomiej Zolnierkiewicz wrote:
> > > Revision 0 of Exynos4210 SoC (used on Universal C210 board) requires
> > > 'secure' PL330 MDMA1 address (0x12840000) instead of 'non-secure' one
> > > (0x12850000). Fix it by overriding the default PL330 MDMA1 address in
> > > exynos4210-universal_c210.dts.
> > >
> > > This is a Device Tree (DT) version of commit 91280e7 ("ARM: EXYNOS:
> > > PL330 MDMA1 fix for revision 0 of Exynos4210 SOC") and fixes recent
> > > regression caused by conversion to DT-only setup on ARM EXYNOS.
> > >
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > ---
> > > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > > index 889cdad..d2e3f5f 100644
> > > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> > > @@ -350,3 +350,7 @@
> > > status = "okay";
> > > };
> > > };
> > > +
> > > +&mdma1 {
> > > + reg = <0x12840000 0x1000>;
> > > +};
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board
2013-09-24 10:41 ` Bartlomiej Zolnierkiewicz
@ 2013-10-07 22:11 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-10-07 22:11 UTC (permalink / raw)
To: linux-arm-kernel
On 09/24/13 19:41, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Tuesday, September 24, 2013 07:38:13 PM Kukjin Kim wrote:
>> Bartlomiej Zolnierkiewicz wrote:
>>>
>>>
>>> Hi Kukjin,
>>>
>> Hi Bart,
>>
>>> Could you please apply this patch?
>>>
>> Can you make sure there is no rev1 for universal c210 board?
>
> Universal C210 always used Exynos4210 rev0.
>
OK, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-07 22:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 11:22 [PATCH] ARM: EXYNOS: fix PL330 MDMA1 address in DT for Universal C210 board Bartlomiej Zolnierkiewicz
2013-08-20 12:13 ` Tomasz Figa
2013-09-23 16:01 ` Bartlomiej Zolnierkiewicz
2013-09-24 10:38 ` Kukjin Kim
2013-09-24 10:41 ` Bartlomiej Zolnierkiewicz
2013-10-07 22:11 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox