From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A590C47DD9 for ; Fri, 22 Mar 2024 09:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ndOsnA+5WMbGUwPNfCigQeLvft/dPVwgnZWofnDJLWM=; b=RmRsG5q7WQJkXc Q4VxMatPtmb3OfFdiIP/0UsYkqHKc79P/VL8NpenS6D252i+sBHKdBL1miMOGIku72YVGHqRuW2eg oMMSjOZQkp8CJJjR3wcRBsL3bwxDqia8vIUNiHoABAWP9v6lG/3w3zx1sUPoGI17+JPS/Kn8fdnks mZCu6bUh13eaB9pZpJHGqpoXTlwIgD5jsFowKFMnBVRJ26NpotEK8WLGncllQUWvN9vr3iFbw8i9C QlRfGhPMNkSxPuuEIi7xHG6xDs01VeriMv3QqC1yvmHsqUDLQRNA6abPccwZSDMu9954Gd1DUDubs 8s1ejqVDz2EloMo1v/fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnbNF-00000006d5l-0B8h; Fri, 22 Mar 2024 09:39:41 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnbN9-00000006d18-2gd0 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 09:39:39 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a465ddc2c09so107000266b.2 for ; Fri, 22 Mar 2024 02:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711100373; x=1711705173; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iKaGHu7VFDCljo+X/R+DU525M8eOtDFvQLYVkXGWhqI=; b=adFrt/yn6WhG41nQXL2JFUqtjzmaskKZn70n0g2qp51891c1e0r9US5vgqzjC0DSYw kQlILJovm/lD2em2CVt0oi1sfjRZYz3r3ttp5/+qlq4vFkPcDLGUWw85GrvDUoV8EMt1 Bws15tk2nW5eHJCiNzlZ/5Ou6InMIBKSCT8B+EFzpQ46up1XXW7ObAqfjg/L1p/iLT+e O+1t6yqko8pu53LrCZ++Lz6C19b5PUHmyPsNDtWW7ZHtBA1d39FFsEiOEI6dOm5Oa5lx EaNq+jxpxOtSSLG6jTx5cEFpfNt/Isxxum5ZTiQuGnbB4GphiPEouQPL7h/nf2GTF27K v1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711100373; x=1711705173; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iKaGHu7VFDCljo+X/R+DU525M8eOtDFvQLYVkXGWhqI=; b=WOENVvqkZqx9WElJDU2oIPGRW8+GkdMF8EZ8IEBcahu3v2EUB5AtbW3UzaALrBcitf UQ/qSaAGsdSQhzcisTefhyVqmfemdP9Rg6OSF7Z6PnbSCNZLKfClLjlyPN+O0f9dcbDR A4VTOyJBV35M4tffrYDBZhnlDKXukI01CxZI42grCxrdGaImR1hpVei7prtntYKHbfL2 Zw8hf9vfrrzx3c2h5+3QKBVvvf9f78oeKVdKIx51SIWDqWuEtyxtcTSANhT9bcchl8CS BvOzHDYrdKhdnQSEKLccfkLRsghNjlsTY1xSTcVhnxidcGwsmhLvjh4Kf/4+Omlgikof tC9w== X-Forwarded-Encrypted: i=1; AJvYcCUiD3DSqkQU2ALqPCoMhCidGd6g3t8afWiFp2JgYHS6DxpN40VC/Ri5qSHhVZtx06Aj5h57uMhHNfJXMkrV3WJqFh/s4eu69T/KqwYafIW4o5X90ec= X-Gm-Message-State: AOJu0Yzdd39FX9Gzhafv6qQuwjmSJKs9zju136qTdDhUfBoDN5yQtJE6 uMht+bHtOEsxRrw8Wb9kQAg439Gw9V29TvbXAlQWuMlVBUQ7MlsKA1o2dhDVVSI= X-Google-Smtp-Source: AGHT+IFdS/wNfVkgLAzNBLe3/39onavyj4PwvV6BXzaBahe1ih49oGZqJ0APqPhqlZak3M8FXBrluA== X-Received: by 2002:a50:8a84:0:b0:565:6e34:da30 with SMTP id j4-20020a508a84000000b005656e34da30mr1483570edj.21.1711100372846; Fri, 22 Mar 2024 02:39:32 -0700 (PDT) Received: from [172.20.10.10] ([213.233.108.187]) by smtp.gmail.com with ESMTPSA id ek14-20020a056402370e00b00562d908daf4sm817450edb.84.2024.03.22.02.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 02:39:32 -0700 (PDT) Message-ID: <867158d7-0d98-4058-9c2e-6b573ec68516@linaro.org> Date: Fri, 22 Mar 2024 09:39:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] clk: samsung: exynos850: fix propagation of SPI IPCLK rate Content-Language: en-US To: Sam Protsenko , =?UTF-8?B?6rmA7J6s7JuQL0pBRVdPTiBLSU0=?= Cc: krzysztof.kozlowski@linaro.org, s.nawrocki@samsung.com, cw00.choi@samsung.com, alim.akhtar@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, peter.griffin@linaro.org, andre.draszik@linaro.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com References: <20240229122021.1901785-1-tudor.ambarus@linaro.org> <20240229122021.1901785-5-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_023935_742690_22ADC305 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Sam! On 3/1/24 00:13, Sam Protsenko wrote: > I fail to see how this patch fixes anything. Instead it looks to me it > replaces the (already) correctly implemented logic with incorrect one. I opened another thread asking for feedback on whether it's safe to re-parent the USI MUX to OSCCLK at run-time, find it here: https://lore.kernel.org/linux-samsung-soc/71df1d6b-f40b-4896-a672-c5f0f526fb1f@linaro.org/T/#m588abb87eb5fd8817d71d06b94c91eb84928e06b Jaewon came up with the idea on verifying what the downstream clock driver does. I added some prints in the driver, and indeed the USI MUX re-parents to OSCCLK on low SPI clock rates in the GS101 case. Thus I'll respin this patch set fixing GS101 on low USI clock rates by re-parenting the USI MUX to OSCCLK. I'll leave exynos850 out if I don't hear back from you, but I think it deserves the same fix. Allowing SPI to modify the clock rate of HSI2C/I3C at run-time is bad IMO. Re-parenting the USI MUX to OSCCLK fixes this problem, HSI2C/I3C will no longer be affected on low SPI clock rates. Cheers, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel