From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C210BC79FA0 for ; Mon, 7 Sep 2026 17:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mllLkfa4j6cMDPeyNiMqsOMa/da1v2mEshsDPnTO6MA=; b=K7yPLv0pZz4a78j+WNLK7Grauf /DjoXfRhL7ffZHQuhJpkoEVgfcCixt3bZkrUMTyvy7jH9exuQ55Kg21NbGWGlI8NR9xrjIfVkRaeR 5EtUaFAfCT9EQQpUx3DDpazHOrmQIJiufTsQbdJhd2OQThUmGYcFkXxjUFINWfMQTP5Rmk7pRTsW9 YaweMSQ4jl7K5dCiAm0fRiJx7CdHXb8Pc5AITF6HqUP/VYA97Ea9eFchm7Kq85vZZLp0f6W6CvL8a 68MOi/74hHiYko6CoC8GV/m7kxGKbPdr2o7FHMFxAWrFuMNzScWSRncTM3mbL+31lOpSCaTgwhmdS +gyS0H9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3dU4-00000007WQR-3vrq; Mon, 07 Sep 2026 17:50:20 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3dU2-00000007WQ3-03oM for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2026 17:50:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id F40FF601DB; Mon, 7 Sep 2026 17:50:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4C641F00A3A; Mon, 7 Sep 2026 17:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788803416; bh=mllLkfa4j6cMDPeyNiMqsOMa/da1v2mEshsDPnTO6MA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=aXYBXV5LjCa95Ar1ahT4FkT0RH2hAHbboc+AU+af64jq11E0qdOIFR+n5DQ163Vz/ 86YbKPwrtq1aeFC1dB4U8tmOoaEuetTUakgi5wpWweH+D3oOdd0VrP+DMvF6/3MyFK jJOqBiKR8PDgMFadBfziaDQNuxALVK3y/RjOf24hDhDj1LL1+GjFlsMUxR2pwXM9kv hmJR5hZVreqCfqeSqzTXo989ClOLYdhxY7HHBO2d9hpyM652NjD77O2nwtjjMEMvN8 sSfXQL5PZM+I4eIYXdBOkws45gclWOPqd3M7fLGF59P435+u98dPXPeVhWv8PDHOlE pkcrqSKjgabrQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x3dTy-00000005tfl-3fb0; Mon, 07 Sep 2026 17:50:14 +0000 Date: Mon, 07 Sep 2026 18:50:14 +0100 Message-ID: <868q5d3q95.wl-maz@kernel.org> From: Marc Zyngier To: Sascha Bischoff Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , nd , "lpieralisi@kernel.org" , "tglx@kernel.org" , Catalin Marinas , "will@kernel.org" , Mark Rutland , Sashiko Subject: Re: [PATCH v2] irqchip/gic-v5: Preserve ICC_CR0_EL1 state In-Reply-To: <20260907164945.714545-1-sascha.bischoff@arm.com> References: <20260907164945.714545-1-sascha.bischoff@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: Sascha.Bischoff@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nd@arm.com, lpieralisi@kernel.org, tglx@kernel.org, Catalin.Marinas@arm.com, will@kernel.org, Mark.Rutland@arm.com, sashiko-bot@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 07 Sep 2026 17:49:50 +0100, Sascha Bischoff wrote: > > In addition to EN, ICC_CR0_EL1 contains other fields, such as LINK and > LINK_IDLE. The driver only needs to modify EN, and must preserve the > values of all other fields when enabling or disabling the CPU > interface. > > Define the missing LINK and LINK_IDLE fields, and use read-modify-write > accesses to update EN without affecting the rest of ICC_CR0_EL1. > > Fixes: 7ec80fb3f025 ("irqchip/gic-v5: Add GICv5 PPI support") > Reported-by: Sashiko > Closes: https://lore.kernel.org/r/20260807121703.D4B7A1F00A3A@smtp.kernel.org > Signed-off-by: Sascha Bischoff Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.