From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 310F0C369DC for ; Wed, 30 Apr 2025 11:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o6hHnLQ2OY2lM+RJG3wpB7OXUFEAxnAyC0A+0JTbvc4=; b=17zjSweB8GCDpoxkjjuXWiUPYo 9iUHQhSL0ITL2CyTektauISkxVQ0KihRFPbnJNIbrN68lwIPw0bQwPSh3cAs5trH/lSAdSiQ8MiXA KsS4/I4RTSk6De6aTpfl2OpaVqx1RhTnfHy0Bz8VDVeHtlRJrWcGjT6A64ehRxewlW7P9MKHCt/bc VKRJ9HiXFk9gQgrn6BOKwN9Zj3hDXJG+eSeWA66pCQgUAocNjx3k9GnvKqfGKJ3SJOfbXFo8w+vC6 uQMs8iHl5yUIPe6tbc5yLMvU6iO4sDY6InwTd4dRE3JLeTj/J/hq08/MgxvQL6G1aX1qgFEbH3qbV VATEqNTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uA60W-0000000CjxB-0cRj; Wed, 30 Apr 2025 11:53:44 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uA5k3-0000000CiGk-1CBs for linux-arm-kernel@lists.infradead.org; Wed, 30 Apr 2025 11:36:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8A05043AEA; Wed, 30 Apr 2025 11:36:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F46FC4CEE9; Wed, 30 Apr 2025 11:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746013002; bh=4h8cRpkZDTjCUV3PlrFF9/xj2YdTvuqBv2OPM3jesrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HfwWNZob8r29rO82ImMRt26pqXWwFB8Ro7yjJW2DsXaX68e7b14dflIAuhvIUI9D0 52gswgZVasMA2HTrjBKTfMdfF9RqPaf+GHmUjfuhQLVMWjwOOjuA5FNZ9KfvEQZ3+n 9V3D4Rp94FbMXUidpa61NnZfEXz5c7QFrt1wPwHeDp7YQpr4C0mzmiLI/MpsQDxfXb xPjWa1SPBMPdOnsEnDvM4pYRODDcQtrwRmgasc/2vPw7UcUqRbH66aTWc2w45W7iiZ vzUtTec1qxLW8sL+L6vjtsEHWFW7qbmdyIHqI/aPQj1YxSX79bizwooNhr7BWzVIHg OQftMQB/5WNgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uA5k0-00AFy2-IX; Wed, 30 Apr 2025 12:36:40 +0100 Date: Wed, 30 Apr 2025 12:36:40 +0100 Message-ID: <868qnhj2yf.wl-maz@kernel.org> From: Marc Zyngier To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, dan.carpenter@linaro.org, johan@kernel.org, Johan Hovold Subject: Re: [PATCH v3 2/3] firmware: arm_scmi: Add Quirks framework In-Reply-To: References: <20250429141108.406045-1-cristian.marussi@arm.com> <20250429141108.406045-3-cristian.marussi@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: cristian.marussi@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, dan.carpenter@linaro.org, johan@kernel.org, johan+linaro@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250430_043643_363597_8524F8D2 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 30 Apr 2025 08:54:06 +0100, Cristian Marussi wrote: > > On Tue, Apr 29, 2025 at 03:11:07PM +0100, Cristian Marussi wrote: > > Add a common framework to describe SCMI quirks and associate them with a > > specific platform or a specific set of SCMI firmware versions. > > > > All the matching SCMI quirks will be enabled when the SCMI core stack > > probes and after all the needed SCMI firmware versioning information was > > retrieved using Base protocol. > > > > Tested-by: Johan Hovold > > Signed-off-by: Cristian Marussi > > Hi > > just a quick remarks that a bot spotted the usage of __VA_OPT__ which is > only available since GCC >= 8.0 :< ... so I will probably revert to use the > previous, less clean, mechanism to build the NULL terminated array in > which the compats array WILL HAVE to be explicitly NULL terminated when > provided (even the empty ones...) See 20250407094116.1339199-1-arnd@kernel.org, which is slated for 6.16. The TL;DR is that GCC 8.1 and binutils 2.30 should be the minimal versions from 6.16 onwards. So it's probably not worth using ugly hacks that will eventually be reverted. Thanks, M. -- Without deviation from the norm, progress is not possible.