From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCA4CA0FE7 for ; Fri, 30 Aug 2024 12:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k5JleH7jU9K8a1b8kKnBUOlfVI/FKSe5mz+Iz+cy4MA=; b=NrUuGGwj5jotR+mOWYxhpy0Dmt D15yDPgjUhSmSA+MjkYsLYS8I3IHH0lR94KnyTwk56cTmofZlpafiJxCkCbJz2rlS8VLhqbizur0X 2oKIbtLqprmo/7U7VYlKs2XquarKUbPcsS15yVlg8zKewxoKsYxZGiGdEYHUZheh17E8IcX0Zu+aV M3FPXGCKjHz5lwMPLBq/yWiSFWvfQmU1qDqH4pJnElEEUC2gMfRZzWJ2eq/Y+oRfrZSUtVbBxnoxq 0AgB5A86dbejlGs5TK8j5Npg3kPKkRf459Fbke6w7X6Iopj+WsmUiN/OVDBzRbQId01GqoFoTq+RD Kf5lIZiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk0lm-00000006Ebu-1N0V; Fri, 30 Aug 2024 12:30:26 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk0k4-00000006DsV-3XGZ for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 12:28:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 07411A4288A; Fri, 30 Aug 2024 12:28:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96B95C4CEC8; Fri, 30 Aug 2024 12:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725020919; bh=zO4wCnBxkRXI4i7T5gLDq8jp8Mqm7VeBGA6ulGBi90g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uMGTTGx8s5zmmy3/df69HrZEHIrifn0gDansnbCAJgTGbTtDclef3IKWPrpklEnPr ELsNmyQs8e69sUiNCtm/TkT0WXtdqF9hheMKjklQ8C1Kkh/6C9oCFkmU0QjkaN5AaM AUcrHUyqdMutMujyrs0nVmeXggVkztoWHE3rFppU+7lecAUWcziH7YdOSDOWWQQZyB oTzcFdhR8/khxQyd3V0JenFzXGwf8Br6rvPNfCW08bDJim1Ltc/HeUlyywyqY/Z1kM Ln8ygNn+e3DfuSpYf0/tKWADFAJILzYQ6i+xpbKbnJgwNN4A/0fp73lIKR+8zLOsy7 Z3t6HLh+c+jDA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sk0k1-008EPI-01; Fri, 30 Aug 2024 13:28:37 +0100 Date: Fri, 30 Aug 2024 13:28:36 +0100 Message-ID: <868qwew5xn.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 2/5] arm64: ptdump: Expose the attribute parsing functionality In-Reply-To: <20240827084549.45731-3-sebastianene@google.com> References: <20240827084549.45731-1-sebastianene@google.com> <20240827084549.45731-3-sebastianene@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastianene@google.com, akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_052840_973158_0B4EF2AF X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 27 Aug 2024 09:45:45 +0100, Sebastian Ene wrote: > > Reuse the descriptor parsing functionality to keep the same output format > as the original ptdump code. This sentence seems either out of place or missing something, because this change it not reusing anything... > In order for this to happen, move the state > tracking objects into a common header. ... but instead doing this ^^^. I propose to rewrite the commit message as: "Adding a new page-table dumper for stage-2 requires parsing the page tables, and reusing the descriptor parsing functionality would help keeping the same output format as the original ptdump code. In order for this to happen, move the state tracking object definitions into a common header." Shout if you object to it! Thanks, M. -- Without deviation from the norm, progress is not possible.