From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57247C7EE26 for ; Mon, 22 May 2023 10:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CksSZEw1L7DgxRwet9wN7gOpzZ03gxv2oV5yDBwOLlA=; b=vPXbgiHmWlsYYz OVQfpHg4MKIBiUIQGnDRExPmNl9xaZ8hAdYDk6IbDERNfY74d/LyhnjkLfBMddC64KHBhgmM7jYIU ubY7ol7mVpeI+qeebwXVuzcofUr2DPrxbM14klIr/Ojf2k14eJWcEAZokQJ+kWFwFQsiseDh1HOMp 1Mf2gg14xSbuk+1jxaEfSjdCzCsG5O2H3mlWxWz6HXPZeCzkbaCKeGUy7fs+4LgnXEFdl4k/I4x3q SKJnEN92Q2qhittbKCZEEFZS1XUByTu3A4r6JWrXMO2XhkhFtr0zutAiLxMbvO/k6iGfSf1hWcZ6l 959Oq1K1fcUxTGj5f0aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q13Ez-006BhM-0R; Mon, 22 May 2023 10:58:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q13Ev-006Beb-2x for linux-arm-kernel@lists.infradead.org; Mon, 22 May 2023 10:58:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 50D2D620A7; Mon, 22 May 2023 10:58:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD9D2C433EF; Mon, 22 May 2023 10:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684753087; bh=vvt2xSD5+nErgKEKVqkW5gcAcma0t3x8nb93UKEW900=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U07gW75cTUkTH0a8x1LthCQmaZ8KTR5cnp0Ev9JI2JyjaV7IEhzlA14rA1JtWrqg3 jdq0c1UF8/Q+phfbzHqO+Nlhg47Tpu+lq5fuHy/burBasGwOnJyMIHeHyzh6occtqx 1SyA+gptSxs9hfadsinTVlwAyzbgKSk/eGc9aOApVESUfKDOb5tCVJ6gePhB4SBtxP WOaPRmRKOPvX706yCgRO0T0mle8x9pMhRzGzMkFD61eg2mlK5GiOZg1hmZPZLbaDr1 BoEBqIOiJac8aoTyYtgCAoCxV5noL9lrqjsjIvm4pbtyWFQg+KXUGoPxJG+hCrC3CZ bVOWm5uIIlUjA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q13Er-00H1G2-BK; Mon, 22 May 2023 11:58:05 +0100 Date: Mon, 22 May 2023 11:58:05 +0100 Message-ID: <868rdgljk2.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, catalin.marinas@arm.com, alexandru.elisei@arm.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, reijiw@google.com, ricarkol@google.com, dmatlack@google.com, qperret@google.com, bgardon@google.com, gshan@redhat.com, peterx@redhat.com, seanjc@google.com Subject: Re: [PATCH] KVM: arm64: Reload PTE after invoking walker callback on preorder traversal In-Reply-To: <86a5xwljzt.wl-maz@kernel.org> References: <20230522103258.402272-1-tabba@google.com> <86a5xwljzt.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, catalin.marinas@arm.com, alexandru.elisei@arm.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, reijiw@google.com, ricarkol@google.com, dmatlack@google.com, qperret@google.com, bgardon@google.com, gshan@redhat.com, peterx@redhat.com, seanjc@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_035810_036165_BFD2DAF8 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 22 May 2023 11:48:38 +0100, Marc Zyngier wrote: > > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > > index 3d61bd3e591d..120c49d52ca0 100644 > > --- a/arch/arm64/kvm/hyp/pgtable.c > > +++ b/arch/arm64/kvm/hyp/pgtable.c > > @@ -207,14 +207,26 @@ static inline int __kvm_pgtable_visit(struct kvm_pgtable_walk_data *data, > > .flags = flags, > > }; > > int ret = 0; > > + bool reload = false; > > kvm_pteref_t childp; > > bool table = kvm_pte_table(ctx.old, level); > > > > - if (table && (ctx.flags & KVM_PGTABLE_WALK_TABLE_PRE)) > > + if (table && (ctx.flags & KVM_PGTABLE_WALK_TABLE_PRE)) { > > ret = kvm_pgtable_visitor_cb(data, &ctx, KVM_PGTABLE_WALK_TABLE_PRE); > > + reload = true; > > + } > > > > if (!table && (ctx.flags & KVM_PGTABLE_WALK_LEAF)) { > > ret = kvm_pgtable_visitor_cb(data, &ctx, KVM_PGTABLE_WALK_LEAF); > > + reload = true; > > + } > > From these two clauses, it is clear that reload is always the value of > (ctx.flags & KVM_PGTABLE_WALK_LEAF). That'd simplify the patch a bit. OK, it should be obvious by now that I cannot read, because TABLE_PRE and LEAF are very different things. Sorry about the noise. I'll fix the trailer thing and stay quiet for the rest of the day... M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel