From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07D4FC43602 for ; Tue, 7 Jul 2026 09:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8uyo2XhmUAHRevNoXiCaMuL1oCl90zKZlPv2wkcpU7o=; b=jsn2T3oWMpTDwWjNwvRVGzwSqO jr/uVpPc7ZJnlfkcycMG8C7jkaE5zbJH4PSN2MmCwwfcoWSElDCI2a5HRQFawjNHTaVdjWGPUuVwJ T3nXty3dTgQ2UGCiJlEr1j8wK8xYncJQcFr7D02Rj0XIxnMvWJ7i9r7rdKyQk/1VIsPxCOKvI8Fbq EvNDH6WEW9OR5E84ucZuRFzeFbt4fgpZLeYOOPGHJr+3iknCp/6+Vea+K3BVttfzHu/7WMhXOXwZu KA30kSDUo02yao24YTYk/xdPC5hBqScE1MDrRYp7gcYCV2L6MCPsMMYrdd6pjkotyJL98+pqXL1ri zivpwP/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh23y-0000000Ecl8-2dd0; Tue, 07 Jul 2026 09:25:58 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh23x-0000000Ecky-1pEu for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2026 09:25:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 953AF618B1; Tue, 7 Jul 2026 09:25:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46DD81F00A3A; Tue, 7 Jul 2026 09:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783416356; bh=8uyo2XhmUAHRevNoXiCaMuL1oCl90zKZlPv2wkcpU7o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KnruRaKfHD+xT3Z4ZkAXPUYtv1S3SziqmpW11MvmgPrTZpKhaJ4eZBaCpwBva3NlE U56oUy52tboS0xyFp0xbs1VISvI8UKsGhcn/gFg918a866mC/j6Hnt+A6WkYs6nNWu zb5i2h4IFEvbs4gkpVB1aXWqAyIWT37DdANxvPtIkTmA3DhEcr844iujUcGgrBwCuz L1hIcxQ7ix5RzOIa/AXDe71lufSEIu2OKlMSjbGMJapa4lC/Y2LPCczTiyxDfTxR0l zSqmQ+5iIvVbO+clviVV+mv8bQ+OPJ5i3zmuSuXda0la8rc9hHEGEEIjjPVIF5oRX+ DFUrHA8rGpsAg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wh23u-00000002KZJ-0bdk; Tue, 07 Jul 2026 09:25:54 +0000 Date: Tue, 07 Jul 2026 10:25:53 +0100 Message-ID: <86a4s3p2vy.wl-maz@kernel.org> From: Marc Zyngier To: Yureka Lilian Cc: Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2ls?= =?UTF-8?B?Y3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Sven Peter , Janne Grunau , Neal Gompa , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: apple: Integrate pwrctrl API In-Reply-To: <20260707-apple-pcie-pwren-v1-1-5a281b182fe2@cyberchaos.dev> References: <20260707-apple-pcie-pwren-v1-0-5a281b182fe2@cyberchaos.dev> <20260707-apple-pcie-pwren-v1-1-5a281b182fe2@cyberchaos.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yureka@cyberchaos.dev, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, sven@kernel.org, j@jannau.net, neal@gompa.dev, krzk+dt@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 06 Jul 2026 23:38:27 +0100, Yureka Lilian wrote: > > Integrate the PCI pwrctrl framework into the Apple PCIe host driver to > provide standardized power management for PCI devices. > > Notably, this allows enabling powering on the WiFi, SD card reader on > various Macs by means of the pwrctrl framework before probing the ports. > > Previously, a custom solution for powering on the WiFi and SD card > reader was proposed[1], but we can now use the new pci-pwrctrl-generic > driver for this purpose. > > Link[1]: https://lore.kernel.org/lkml/20220502093832.32778-4-marcan@marcan.st/ > nit: this paragraph and the accompanying link don't belong in the commit message and should be moved below the --- mark or even better, to the cover letter. > Signed-off-by: Yureka Lilian > --- > drivers/pci/controller/Kconfig | 1 + > drivers/pci/controller/pcie-apple.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 2247709ef6d6..af64630d28fa 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -46,6 +46,7 @@ config PCIE_APPLE > depends on OF > depends on PCI_MSI > select PCI_HOST_COMMON > + select PCI_PWRCTRL_GENERIC > select IRQ_MSI_LIB > help > Say Y here if you want to enable PCIe controller support on Apple > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index c2cffc0659f4..db038a9d4831 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include "pci-host-common.h" > > @@ -825,6 +826,21 @@ static int apple_pcie_init(struct pci_config_window *cfg) > if (WARN_ON(!pcie)) > return -ENOENT; > > + ret = pci_pwrctrl_create_devices(pcie->dev); > + if (ret) { > + dev_err(pcie->dev, "Failed to create pwrctrl devices: %pe\n", ret); > + return ret; > + } > + > + ret = pci_pwrctrl_power_on_devices(pcie->dev); > + if (ret) { > + if (ret != -EPROBE_DEFER) { > + dev_err(pcie->dev, "Failed to power on devices: %pe\n", ret); > + pci_pwrctrl_destroy_devices(pcie->dev); > + } > + return ret; > + } > + Why is this done globally while the whole driver works on a per-port basis, and that the proposed DT updates are also per port? Thanks, M. -- Without deviation from the norm, progress is not possible.