Re: [PATCH v1 00/12] KVM Dirty-bit cleaning accelerator (HACDBS)

Leonardo Bras
2026-04-30T15:36:10Z

On Thu, Apr 30, 2026 at 03:51:20PM +0100, Marc Zyngier wrote:
> On Thu, 30 Apr 2026 14:29:37 +0100,
> Leonardo Bras <leo.bras@arm.com> wrote:
> >
> > On Thu, Apr 30, 2026 at 02:14:22PM +0100, Marc Zyngier wrote:
> > > On Thu, 30 Apr 2026 12:14:04 +0100,
> > > Leonardo Bras <leo.bras@arm.com> wrote:
> > >
> > > > d - In __kvm_arch_dirty_log_clear() there is no way to predict how long
> > > > should be the buffer, so I used 1x PAGE_SIZE, and when it gets full
> > > > it's cleaned and reused. Should I let users configure that over a
> > > > parameter, or is it overthinking?
> > >
> > > How long is a piece of string? We can't know that. A single page feels
> > > very small in the 4kB case, and letting userspace define the size of
> > > that buffer seems a likely requirement.
> > >
> >
> > Ok, as a KVM parameter, or as a compile-time option?
>
> Noticed the "userspace" word in there? It *has* to be controlled by
> userspace one way or another. So not as a kernel parameter, and
> *never* as a compile option.

Okay, I would suggest that a module parameter could be set by userspace,
but I remember now that it is usually built in the kernel instead. Also, it
could be bad having this set for the whole system, instead of per-VM.

How do you suggest letting userspace control that?
(All I could think was using an ioctl / API of any sorts, which would
require changing the VMMs as well.)

>
> > > > Kernel v7.0.0 + this patchset builds properly, passing both kvm selftests
> > > > for dirty-bit tracking[2], on HW HACDBS enabled or disabled.
> > >
> > > I have absolutely no trust in these tests.
> > >
> > > Have you enabled a VMM to make use of these APIs, and actively
> > > migrated running guests? That's the level of testing I'd like to see,
> > > as the selftests are not what people run in production...
> > >
> >
> > There is no enablement needed on VMM side.
> > Yes, I have created a VM on upstream qemu with --enable-kvm and migrated it
> > on the same host. (Inside a model)
> >
> > That was the first test I used, but then I found out that kvm selftests
> > stress up multiple scenarios in an easier way.
>
> Except when they don't. In my experience, the selftests are only there
> to give the CI people the fuzzy feeling that they are doing something
> useful.

LOL

> I have a collection of examples indicating that what these
> things test is not representative of the bugs we have in KVM.
>

Fair enough... it was tested in qemu live migration, and it works properly
(migrated from 2 instances of qemu in the same host, emulated by model).

> > Do you prefer me to test on any specific scenario, or does whatever qemu
> > uses as a default parameter work well enough?
>
> I want to hear about testing at a scale that make sense for production
> VMs, including live migrating between hosts while under memory
> pressure (swapping out).

I agree that's a more interesting test.

>
> I'm also interested in efficiency: how much better is HACDBS compared
> to the current page faulting?

The terms are indeed confusing, but HACDBS is just the cleaning accelerator
for dirty-bit. It means it will only affect how long it takes to transverse
the page table making pages in the array writable-dirty -> writable-clean.

That being said, it regards to efficiency:
Well, as I only have the model to test that, I am limmited to those
results, which may not reflect reality.

As an example, on dirty_log_perf_test, the cleaning process took much
longer (8x) compared to software cleaning, even when faced with no error,
and entries that fit the array (4k page above). If it took that long even
in this ideal scenario, it means the HACDBS mechanism implemented in the
model takes much longer than software, which is counter-intuitive.

> Just having patches for a feature is not
> enough to decide adoption of that feature. Show me the benefits in a
> quantitative way (within the limits of the model, of course).

Sure, I will try measuring migration between 2 instances of the model, and
see how qemu live migration time is affected, then post the results in this
thread for us to compare.

Thanks!
Leo