From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>, James Clark <james.clark@linaro.org>
Cc: Oliver Upton <oupton@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Colton Lewis <coltonlewis@google.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] KVM: arm64: Read PMUVer as unsigned
Date: Thu, 19 Mar 2026 16:51:06 +0000 [thread overview]
Message-ID: <86a4w369vp.wl-maz@kernel.org> (raw)
In-Reply-To: <20260305-james-kvm-pmuver-sign-v2-0-ee80a125af9b@linaro.org>
On Thu, 05 Mar 2026 16:28:16 +0000,
James Clark <james.clark@linaro.org> wrote:
>
> Fix some issues with the signedness of PMUVer and PerfMon ID fields.
>
> I ran into the first issue when testing "ARM64 PMU Partitioning" patches
> on the FVP. The second issue was only found by inspection.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> Changes in v2:
> - Handle ID_AA64DFR0_EL1_PMUVer_IMP_DEF correctly by using
> pmuv3_implemented()
> - Fix another issue with incorrect sign in cpufeature.c
> - Add a commit to refactor has_pmuv3() to use pmuv3_implemented() for
> consistency
> - Link to v1: https://lore.kernel.org/r/20260305-james-kvm-pmuver-sign-v1-1-eea0a2116dd0@linaro.org
>
> ---
> James Clark (3):
> KVM: arm64: Read PMUVer as unsigned
> arm64: cpufeature: Make PMUVer and PerfMon unsigned
> arm64: cpufeature: Use pmuv3_implemented() function
>
> arch/arm/include/asm/arm_pmuv3.h | 7 +++++++
> arch/arm64/kernel/cpufeature.c | 16 ++++------------
> arch/arm64/kvm/debug.c | 5 ++++-
> 3 files changed, 15 insertions(+), 13 deletions(-)
Given that this only tangentially affects KVM, it'd better be routed
via the arm64/perf tree.
With that in mind:
Reviewed-by: Marc Zyngier <maz@kernel.org>
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2026-03-19 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 16:28 [PATCH v2 0/3] KVM: arm64: Read PMUVer as unsigned James Clark
2026-03-05 16:28 ` [PATCH v2 1/3] " James Clark
2026-03-05 16:28 ` [PATCH v2 2/3] arm64: cpufeature: Make PMUVer and PerfMon unsigned James Clark
2026-03-05 16:28 ` [PATCH v2 3/3] arm64: cpufeature: Use pmuv3_implemented() function James Clark
2026-03-12 21:44 ` [PATCH v2 0/3] KVM: arm64: Read PMUVer as unsigned Colton Lewis
2026-03-19 16:51 ` Marc Zyngier [this message]
2026-03-24 15:08 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a4w369vp.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=coltonlewis@google.com \
--cc=james.clark@linaro.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oupton@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox