From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D6B3C36005 for ; Mon, 28 Apr 2025 10:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qrHl5jERHiyRV2QhPEJ8HC/tfGUU+KOEJEFRhIJJ8L8=; b=P+6pfkz9r/gLbVdmRjg68RH0tL mXrJNk6XE6Kvl3J6tCBtcpJeKilb0P6bJCckwENeIR1KuFdGNypXC6W3slyePKJ3LJ5Kek6KC1ASm NuE1pWPWYOfU5zNnyg2bLR6Gl2YKhwrqU94+Nue3+5sJGUD21AOqNwqWwLy3vaNDDnTGGaGoX7VjW Kugz8Q9wARbiUpZ4rqQjyfOaQd7+4CJnuSbs54xsq/tQsUi70ubwajARN2MqMAiP4rXe1qZSrTiL4 sHaRvEBzCp3sovk/pAdWNVwTrES2BhFvnCFkG72LAfimWjjn5QVgYCv85A2f08iT941RDlJf1qKVZ gPg3fxIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9LNQ-00000005klG-3hZk; Mon, 28 Apr 2025 10:06:16 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9LLO-00000005kJt-0XDK for linux-arm-kernel@lists.infradead.org; Mon, 28 Apr 2025 10:04:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 71F4C61156; Mon, 28 Apr 2025 10:03:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF3D8C4CEE4; Mon, 28 Apr 2025 10:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745834648; bh=vAoG5/xSEr/30IS/WDi1H6EZUnCxT0ydzdIngcc8O/M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ICE4fLJdboNxGzgGECHOJxbMT0kwWt5N6Tk6Zmc9mJZ+7/UZNh6fL9QaSAeOGAl1n K9oXqCtxqepMiutpU9RF+V+CewWe4EPURqQlNnh3Kc0oi6D0w4INU6dAKHpzwuAbe/ jthwIm+cfrp9yUDQcKOyBJ2lY5dBuuacNFFu8KPgnyBKAelkWFFrZ2LQrTf7DszO62 TqiZQLVScHQYv1A74qAGVALZ00WMlUoSTKy4hJkY36NdV8cvDDY3mwfiRmwvOClokE yy1WVcxokj5nvAdo4lI2hN3u/uti053EDaczhDzvjydieXIB/5WIgapTqSFo81Vj8T 7aRxnlZALumZg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1u9LLK-009ToD-5g; Mon, 28 Apr 2025 11:04:06 +0100 Date: Mon, 28 Apr 2025 11:04:05 +0100 Message-ID: <86a580k3fu.wl-maz@kernel.org> From: Marc Zyngier To: "Seongsu Park" Cc: "'Anshuman Khandual'" , , , , , , , , , Subject: Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper In-Reply-To: <0fd501dbb80c$d5a91d30$80fb5790$@samsung.com> References: <1891546521.01744691102904.JavaMail.epsvc@epcpadp1new> <0fd501dbb80c$d5a91d30$80fb5790$@samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sgsu.park@samsung.com, anshuman.khandual@arm.com, will@kernel.org, catalin.marinas@arm.com, suzuki.poulose@arm.com, joey.gouly@arm.com, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, cpgs@samsung.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Apr 2025 08:11:59 +0100, "Seongsu Park" wrote: > > On 4/15/25 06:54, Seongsu Park wrote: > > > Replace repetitive ternary expressions with the str_on_off() helper > > > function. This change improves code readability and ensures > > > consistency in tracepoint string formatting > > > > > > Signed-off-by: Seongsu Park > > > --- > > > arch/arm64/kvm/trace_arm.h | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h > > > index c18c1a95831e..9c60f6465c78 100644 > > > --- a/arch/arm64/kvm/trace_arm.h > > > +++ b/arch/arm64/kvm/trace_arm.h > > > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush, > > > ), > > > > > > TP_printk("S/W flush at 0x%016lx (cache %s)", > > > - __entry->vcpu_pc, __entry->cache ? "on" : "off") > > > + __entry->vcpu_pc, str_on_off(__entry->cache)) > > > ); > > > > > > TRACE_EVENT(kvm_toggle_cache, > > > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache, > > > ), > > > > > > TP_printk("VM op at 0x%016lx (cache was %s, now %s)", > > > - __entry->vcpu_pc, __entry->was ? "on" : "off", > > > - __entry->now ? "on" : "off") > > > + __entry->vcpu_pc, str_on_off(__entry->was), > > > + str_on_off(__entry->now)) > > > ); > > > > > > /* > > > > Reviewed-by: Anshuman Khandual > > Dear Anshuman, > > Do you have any feedback? > If you have, please let me know. > I think this patch is appropriate. There isn't much to add. This patch looks reasonable, but it also doesn't warrant being merged immediately (it is purely cosmetic). Once I start queuing patches for 6.16, I'll probably add it to the mix. Thanks, M. -- Without deviation from the norm, progress is not possible.