* [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper [not found] <CGME20250415012410epcas1p42b48977934c21b5db0b19f4185f7a63c@epcas1p4.samsung.com> @ 2025-04-15 1:24 ` Seongsu Park 2025-04-15 6:36 ` Anshuman Khandual ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Seongsu Park @ 2025-04-15 1:24 UTC (permalink / raw) To: will, catalin.marinas, yuzenghui, suzuki.poulose, joey.gouly, oliver.upton, maz Cc: linux-arm-kernel, kvmarm, linux-kernel, sgsu.park, cpgs Replace repetitive ternary expressions with the str_on_off() helper function. This change improves code readability and ensures consistency in tracepoint string formatting Signed-off-by: Seongsu Park <sgsu.park@samsung.com> --- arch/arm64/kvm/trace_arm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h index c18c1a95831e..9c60f6465c78 100644 --- a/arch/arm64/kvm/trace_arm.h +++ b/arch/arm64/kvm/trace_arm.h @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush, ), TP_printk("S/W flush at 0x%016lx (cache %s)", - __entry->vcpu_pc, __entry->cache ? "on" : "off") + __entry->vcpu_pc, str_on_off(__entry->cache)) ); TRACE_EVENT(kvm_toggle_cache, @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache, ), TP_printk("VM op at 0x%016lx (cache was %s, now %s)", - __entry->vcpu_pc, __entry->was ? "on" : "off", - __entry->now ? "on" : "off") + __entry->vcpu_pc, str_on_off(__entry->was), + str_on_off(__entry->now)) ); /* -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper 2025-04-15 1:24 ` [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper Seongsu Park @ 2025-04-15 6:36 ` Anshuman Khandual 2025-04-28 7:11 ` Seongsu Park 2025-05-06 3:34 ` Zenghui Yu 2025-05-06 8:39 ` Marc Zyngier 2 siblings, 1 reply; 6+ messages in thread From: Anshuman Khandual @ 2025-04-15 6:36 UTC (permalink / raw) To: Seongsu Park, will, catalin.marinas, yuzenghui, suzuki.poulose, joey.gouly, oliver.upton, maz Cc: linux-arm-kernel, kvmarm, linux-kernel, cpgs On 4/15/25 06:54, Seongsu Park wrote: > Replace repetitive ternary expressions with the str_on_off() helper > function. This change improves code readability and ensures consistency > in tracepoint string formatting > > Signed-off-by: Seongsu Park <sgsu.park@samsung.com> > --- > arch/arm64/kvm/trace_arm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h > index c18c1a95831e..9c60f6465c78 100644 > --- a/arch/arm64/kvm/trace_arm.h > +++ b/arch/arm64/kvm/trace_arm.h > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush, > ), > > TP_printk("S/W flush at 0x%016lx (cache %s)", > - __entry->vcpu_pc, __entry->cache ? "on" : "off") > + __entry->vcpu_pc, str_on_off(__entry->cache)) > ); > > TRACE_EVENT(kvm_toggle_cache, > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache, > ), > > TP_printk("VM op at 0x%016lx (cache was %s, now %s)", > - __entry->vcpu_pc, __entry->was ? "on" : "off", > - __entry->now ? "on" : "off") > + __entry->vcpu_pc, str_on_off(__entry->was), > + str_on_off(__entry->now)) > ); > > /* Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper 2025-04-15 6:36 ` Anshuman Khandual @ 2025-04-28 7:11 ` Seongsu Park 2025-04-28 10:04 ` Marc Zyngier 0 siblings, 1 reply; 6+ messages in thread From: Seongsu Park @ 2025-04-28 7:11 UTC (permalink / raw) To: 'Anshuman Khandual', will, catalin.marinas, suzuki.poulose, joey.gouly, oliver.upton, maz Cc: linux-arm-kernel, kvmarm, linux-kernel, cpgs > On 4/15/25 06:54, Seongsu Park wrote: > > Replace repetitive ternary expressions with the str_on_off() helper > > function. This change improves code readability and ensures > > consistency in tracepoint string formatting > > > > Signed-off-by: Seongsu Park <sgsu.park@samsung.com> > > --- > > arch/arm64/kvm/trace_arm.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h > > index c18c1a95831e..9c60f6465c78 100644 > > --- a/arch/arm64/kvm/trace_arm.h > > +++ b/arch/arm64/kvm/trace_arm.h > > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush, > > ), > > > > TP_printk("S/W flush at 0x%016lx (cache %s)", > > - __entry->vcpu_pc, __entry->cache ? "on" : "off") > > + __entry->vcpu_pc, str_on_off(__entry->cache)) > > ); > > > > TRACE_EVENT(kvm_toggle_cache, > > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache, > > ), > > > > TP_printk("VM op at 0x%016lx (cache was %s, now %s)", > > - __entry->vcpu_pc, __entry->was ? "on" : "off", > > - __entry->now ? "on" : "off") > > + __entry->vcpu_pc, str_on_off(__entry->was), > > + str_on_off(__entry->now)) > > ); > > > > /* > > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Dear Anshuman, Do you have any feedback? If you have, please let me know. I think this patch is appropriate. Thanks. Seongsu Park. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper 2025-04-28 7:11 ` Seongsu Park @ 2025-04-28 10:04 ` Marc Zyngier 0 siblings, 0 replies; 6+ messages in thread From: Marc Zyngier @ 2025-04-28 10:04 UTC (permalink / raw) To: Seongsu Park Cc: 'Anshuman Khandual', will, catalin.marinas, suzuki.poulose, joey.gouly, oliver.upton, linux-arm-kernel, kvmarm, linux-kernel, cpgs On Mon, 28 Apr 2025 08:11:59 +0100, "Seongsu Park" <sgsu.park@samsung.com> wrote: > > On 4/15/25 06:54, Seongsu Park wrote: > > > Replace repetitive ternary expressions with the str_on_off() helper > > > function. This change improves code readability and ensures > > > consistency in tracepoint string formatting > > > > > > Signed-off-by: Seongsu Park <sgsu.park@samsung.com> > > > --- > > > arch/arm64/kvm/trace_arm.h | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h > > > index c18c1a95831e..9c60f6465c78 100644 > > > --- a/arch/arm64/kvm/trace_arm.h > > > +++ b/arch/arm64/kvm/trace_arm.h > > > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush, > > > ), > > > > > > TP_printk("S/W flush at 0x%016lx (cache %s)", > > > - __entry->vcpu_pc, __entry->cache ? "on" : "off") > > > + __entry->vcpu_pc, str_on_off(__entry->cache)) > > > ); > > > > > > TRACE_EVENT(kvm_toggle_cache, > > > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache, > > > ), > > > > > > TP_printk("VM op at 0x%016lx (cache was %s, now %s)", > > > - __entry->vcpu_pc, __entry->was ? "on" : "off", > > > - __entry->now ? "on" : "off") > > > + __entry->vcpu_pc, str_on_off(__entry->was), > > > + str_on_off(__entry->now)) > > > ); > > > > > > /* > > > > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > > Dear Anshuman, > > Do you have any feedback? > If you have, please let me know. > I think this patch is appropriate. There isn't much to add. This patch looks reasonable, but it also doesn't warrant being merged immediately (it is purely cosmetic). Once I start queuing patches for 6.16, I'll probably add it to the mix. Thanks, M. -- Without deviation from the norm, progress is not possible. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper 2025-04-15 1:24 ` [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper Seongsu Park 2025-04-15 6:36 ` Anshuman Khandual @ 2025-05-06 3:34 ` Zenghui Yu 2025-05-06 8:39 ` Marc Zyngier 2 siblings, 0 replies; 6+ messages in thread From: Zenghui Yu @ 2025-05-06 3:34 UTC (permalink / raw) To: Seongsu Park Cc: will, catalin.marinas, suzuki.poulose, joey.gouly, oliver.upton, maz, linux-arm-kernel, kvmarm, linux-kernel, cpgs It'd better to write the subject as "KVM: arm64: Replace ..." On 2025/4/15 9:24, Seongsu Park wrote: > Replace repetitive ternary expressions with the str_on_off() helper > function. This change improves code readability and ensures consistency > in tracepoint string formatting > > Signed-off-by: Seongsu Park <sgsu.park@samsung.com> > --- > arch/arm64/kvm/trace_arm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Zenghui Yu <yuzenghui@huawei.com> Thanks, Zenghui ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper 2025-04-15 1:24 ` [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper Seongsu Park 2025-04-15 6:36 ` Anshuman Khandual 2025-05-06 3:34 ` Zenghui Yu @ 2025-05-06 8:39 ` Marc Zyngier 2 siblings, 0 replies; 6+ messages in thread From: Marc Zyngier @ 2025-05-06 8:39 UTC (permalink / raw) To: will, catalin.marinas, yuzenghui, suzuki.poulose, joey.gouly, oliver.upton, Seongsu Park Cc: linux-arm-kernel, kvmarm, linux-kernel, cpgs On Tue, 15 Apr 2025 10:24:05 +0900, Seongsu Park wrote: > Replace repetitive ternary expressions with the str_on_off() helper > function. This change improves code readability and ensures consistency > in tracepoint string formatting > > Applied to kvm-arm64/misc-6.16, thanks! [1/1] arm64: kvm: Replace ternary flags with str_on_off() helper commit: d2f14174f9e839e1128664ab339bbe17c333208b Cheers, M. -- Without deviation from the norm, progress is not possible. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-06 9:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250415012410epcas1p42b48977934c21b5db0b19f4185f7a63c@epcas1p4.samsung.com>
2025-04-15 1:24 ` [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper Seongsu Park
2025-04-15 6:36 ` Anshuman Khandual
2025-04-28 7:11 ` Seongsu Park
2025-04-28 10:04 ` Marc Zyngier
2025-05-06 3:34 ` Zenghui Yu
2025-05-06 8:39 ` Marc Zyngier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).