From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 582CBD6ACE8 for ; Wed, 27 Nov 2024 15:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XG8h3ZyU9BHPVM/ztx9+Ohn+XQTO/3lRYXcIse3rcdY=; b=a6EuFPQOW8QlKwesBcyR12yLmZ IqsINq9u0AGYGICt4BeKX5+AmHwhK9j4U1X4wl2pR5kt1McS4Zq7rmCm5I/y3LY0yUCjoKNDbTYi/ cvJOvt0OEGaLdXgkOBiE7aROYWhliHxHCiLsJk+mD/6vvV/2aih3StJmwjv+C82JmO/2SSGJeEqfL +R6JRyK9Np2yPDCN06MHH2LeJBys7jvA56gTYfTM9xVubgX0oDnE/rQwUgm8eVxWNrfHmtXYgIAXU qxKXVN0VfoYnLzK8CeXMWtu0+p/D/TP/gWNINEdkWMgT/4YhLFlQTqRmFvTUZbxYD53GRWWbuiZLU hA0ZLeXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGJoF-0000000DTuK-42Sm; Wed, 27 Nov 2024 15:18:31 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGJmR-0000000DTg6-1k4G for linux-arm-kernel@lists.infradead.org; Wed, 27 Nov 2024 15:16:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 775215C543F; Wed, 27 Nov 2024 15:15:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B9E2C4CECC; Wed, 27 Nov 2024 15:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732720598; bh=8jnJkKM3PWqGFdZGSMROt5V4Vl8ICBi2XhYnl1VjbiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hTx6qf/0jaw7idnchniEopk++7ZRKCwqCQwXRZH/FWn0hbimneT7dJNv+yPmEJL3n PeXzIZzlJlkztMJaP0GSju3OlT8Fo5JZq6vY2wT1BPTKkpD1RkUBQFLrn4FwiaBKuL jgkOOd0nhJ8hKCF2y97F55WiS1zf0uuKXY0BbAFsyJXtzEpOxBJomPZDdXBL7yF4uJ QIYDIfXg22DbgRUWvBpgktauIrQHs8vZ9NJRT3dOWp606PI4chHrOa16PaKB8wPOPE Y5EhPKHgsOHvEzOeLOqJoiAYThL1M1f1Mz2V8/v9CSTRHcGnyT4R7boWSus4m+eKZ4 rmJROb/5CCaOw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tGJmN-00GIa4-QV; Wed, 27 Nov 2024 15:16:35 +0000 Date: Wed, 27 Nov 2024 15:16:35 +0000 Message-ID: <86a5dkvh9o.wl-maz@kernel.org> From: Marc Zyngier To: Steven Price Cc: Catalin Marinas , Oliver Upton , Will Deacon , Joey Gouly , Suzuki K Poulose , Zenghui Yu , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Bump KVM_VCPU_MAX_FEATURES In-Reply-To: <20241127145644.421352-1-steven.price@arm.com> References: <20241127145644.421352-1-steven.price@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: steven.price@arm.com, catalin.marinas@arm.com, oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241127_071639_499073_A829BB1F X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Nov 2024 14:56:31 +0000, Steven Price wrote: > > When the KVM_ARM_VCPU_HAS_EL2 define was added, the value of > KVM_VCPU_MAX_FEATURES wasn't incremented, so that feature has never been > in the KVM_VCPU_VALID_FEATURES bit mask. This means the HAS_EL2 feature > will never be exposed to user space even if the system supports it. > > Fixes: 89b0e7de3451 ("KVM: arm64: nv: Introduce nested virtualization VCPU feature") > Signed-off-by: Steven Price > --- > I might be missing something, and it's possible that > KVM_ARM_VCPU_HAS_EL2 is deliberately not exposed yet. This is on purpose. I'm not planning to enable EL2 support until it is ready. > However I'm > working on v6 of the host CCA series and as part of that want to add a > new feature but and bump KVM_VCPU_MAX_FEATURES up to 9. Well, I guess that defines some ordering then! :D M. -- Without deviation from the norm, progress is not possible.