From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD550C4345F for ; Mon, 15 Apr 2024 08:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7lYxklDwblKOr92RBU4nZOA3PtMNfgY85PFjpkjg8do=; b=KkrTHC1NPwXROq lO26tsZYPlTUaaPTtNHdoV6bQ4l6UjZ6r+oRN9r3ZzJk6lHQ1zZYPBORVuDJgkmk9BAqwlN/sQ/rg QEY3pNgAaa3GoYb6nA5vB7hL+LxUdKCZ0s7w5KygNP48OzyRMbg1gnGpYg9DeQf5aeXuhIlqx8Axk dkl19qIOZw39I4cCt1X4RdD5bz+tX5/iv7OSmes+Yany0sQBeoHd0KOY7gbId7TUY0w0Lc/ZKbZ3e xRxJjhBMRK+GuoFcQk5Kdk12aTR80Kx9SSpjMYff2s2VlPQzsnyzCUje9YWliKG9WEfbdKQJC0d9P IkLUmkRHn37sciWDKi6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwHZu-00000007WKw-1lUN; Mon, 15 Apr 2024 08:20:38 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwHZr-00000007WKP-06xP for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 08:20:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A7472CE01F5; Mon, 15 Apr 2024 08:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE42DC113CC; Mon, 15 Apr 2024 08:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713169228; bh=lHakyS2EZjfHogpbTDGyQn5qs32Vn2rw45fF5c6ipjU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RVAcg6KdZ/zWL71SlH0I3T9EGRO6eKKr3Cksm5bzsZKF2TpjoUm5kjXEvD7rPx6hB HUj6g6mBQMMIC1O8F30EeiaXJbJM58wwmoudG5eZn390CjJrN9c1yETL1Dyoco/CZU oAhuZTCLqAhSJxIc2Zg/Bt5FjMipyidJXurq3n4BhQUTRPvgOmZmwr6omHcu9tOGu4 GWZrdgxl1DRdrq8ZiFbe7mnX95cCGUgXiccSaZc+D+tAhZ0z4L7c+XAbjWgBnN4279 yp/wg4JrQeqfBBz3yLrS0zY0gAAcxp6TaYDNhDJPRU7XuVLWEQUfqcO7n0wA3zTJuu AgJtLbfuHoJCg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rwHZi-004XdH-Ou; Mon, 15 Apr 2024 09:20:26 +0100 Date: Mon, 15 Apr 2024 09:20:25 +0100 Message-ID: <86a5lvrq9i.wl-maz@kernel.org> From: Marc Zyngier To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Catalin Marinas , Will Deacon , Mark Rutland Subject: Re: [PATCH 1/2] arm64/head: Drop unnecessary pre-disable-MMU workaround In-Reply-To: <20240415075412.2347624-5-ardb+git@google.com> References: <20240415075412.2347624-4-ardb+git@google.com> <20240415075412.2347624-5-ardb+git@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ardb+git@google.com, linux-arm-kernel@lists.infradead.org, ardb@kernel.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_012035_268097_5409E97F X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Apr 2024 08:54:14 +0100, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > The Falkor erratum that results in the need for an ISB before clearing > the M bit in SCTLR_ELx only applies to execution at exception level x, > and so the workaround is not needed when disabling the EL1 MMU while > running at EL2. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/head.S | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 06234c3a15f3..b8bbd72cb194 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -323,13 +323,11 @@ SYM_INNER_LABEL(init_el2, SYM_L_LOCAL) > cbz x0, 2f > > /* Set a sane SCTLR_EL1, the VHE way */ > - pre_disable_mmu_workaround > msr_s SYS_SCTLR_EL12, x1 > mov x2, #BOOT_CPU_FLAG_E2H > b 3f > > 2: > - pre_disable_mmu_workaround > msr sctlr_el1, x1 > mov x2, xzr > 3: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel