From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFDCECA0EF8 for ; Thu, 21 Aug 2025 13:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WlqqfI0U0npfmgU+tmlUwSHbK4ZelsnQ4LVffls/8aw=; b=ij09XxRbXZzP0NWBm5nBxIYil3 OmWSVQxDSFtZg+hFBgS+sd8AOCwmYX2pI/aGcY0eKnBippGRfYLZmJW9TGyzddVTC7YabIz4OfS1g dRJ0sNu5sn/+YA3HwNk4pnoQ93mDEskBO9rQPKS53jaaEFwY0SuEumyqxBtN+1nGxdMFtJvmAoNoi +tWZyIvatEikZOTNsvENhrSHQX1973CEsU/p/MMks43cMlZ6kSblQXAgc4p2+eu9MHMnmXwOLVspW D3ykAjN9OCL2BsE852nZPf3FTEB0XPfo89yv2YUkoH2dkTmEke3uCYxkO124oSnvmrDK8qkis992w DZTgis2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1up4zy-0000000GzTH-3ThV; Thu, 21 Aug 2025 13:06:34 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1up1mM-0000000GR7L-1Clz for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2025 09:40:19 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57L73mkn017291; Thu, 21 Aug 2025 11:39:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= WlqqfI0U0npfmgU+tmlUwSHbK4ZelsnQ4LVffls/8aw=; b=n5hHxiHwTKdbVyRl vHBWgMduDM+tlhtZeSXTi/mGPgVEsu/HOgOcBgDrwFVAPAVlc6/35j9oQpPweKad b2qSUj3MTwx77kAkK3nbKgC77W4lGqLmIjx7LNzvM/UjDvLLrDJrMHOuAU6CtxCr xjP3lYfEXbJUS0nBw/4kiq15Gi9Rf9+B5RecphEiZFJCv1mCLprGvM8uV+5MUVZT fO1CxdWtOi6kMZTY82cKed2gYCB3d7Ds4+8ggAbvIlE4ywU/hhm9sKiDDh5r8zpz /8z7stmnBupg7HBOfEsgTrji6B2v+Hp+gya+hzkvCOsMcbEyZJRxy1z+LDv1JwVz vEpSJg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 48n70de72d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Aug 2025 11:39:56 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3446F40046; Thu, 21 Aug 2025 11:37:35 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id F3EAD73DB5A; Thu, 21 Aug 2025 11:36:15 +0200 (CEST) Received: from [10.48.87.178] (10.48.87.178) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 21 Aug 2025 11:36:14 +0200 Message-ID: <86adb9ce-68de-494f-92e8-6e11773987fe@foss.st.com> Date: Thu, 21 Aug 2025 11:36:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/9] drm/stm/lvds: convert from round_rate() to determine_rate() To: Brian Masney , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , "Abhinav Kumar" , Jessica Zhang , Sean Paul , Marijn Suijten , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd CC: , , , , , , , , References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> <20250811-drm-clk-round-rate-v2-7-4a91ccf239cf@redhat.com> Content-Language: en-US From: Yannick FERTRE In-Reply-To: <20250811-drm-clk-round-rate-v2-7-4a91ccf239cf@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.87.178] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-21_02,2025-08-20_03,2025-03-28_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_024018_680353_0AAB0DF4 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Brian, thanks for the patch. Acked-by: Yannick Fertre Le 11/08/2025 à 12:56, Brian Masney a écrit : > The round_rate() clk ops is deprecated, so migrate this driver from > round_rate() to determine_rate() using the Coccinelle semantic patch > on the cover letter of this series. > > Acked-by: Raphael Gallais-Pou > Signed-off-by: Brian Masney > --- > drivers/gpu/drm/stm/lvds.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c > index 07788e8d3d8302a3951e97d64736b721033998d3..fe38c0984b2b552e1ccaef4d1e589b9d86a40ee3 100644 > --- a/drivers/gpu/drm/stm/lvds.c > +++ b/drivers/gpu/drm/stm/lvds.c > @@ -682,8 +682,8 @@ static unsigned long lvds_pixel_clk_recalc_rate(struct clk_hw *hw, > return (unsigned long)lvds->pixel_clock_rate; > } > > -static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > +static int lvds_pixel_clk_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > struct stm_lvds *lvds = container_of(hw, struct stm_lvds, lvds_ck_px); > unsigned int pll_in_khz, bdiv = 0, mdiv = 0, ndiv = 0; > @@ -703,7 +703,7 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, > mode = list_first_entry(&connector->modes, > struct drm_display_mode, head); > > - pll_in_khz = (unsigned int)(*parent_rate / 1000); > + pll_in_khz = (unsigned int)(req->best_parent_rate / 1000); > > if (lvds_is_dual_link(lvds->link_type)) > multiplier = 2; > @@ -719,14 +719,16 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, > lvds->pixel_clock_rate = (unsigned long)pll_get_clkout_khz(pll_in_khz, bdiv, mdiv, ndiv) > * 1000 * multiplier / 7; > > - return lvds->pixel_clock_rate; > + req->rate = lvds->pixel_clock_rate; > + > + return 0; > } > > static const struct clk_ops lvds_pixel_clk_ops = { > .enable = lvds_pixel_clk_enable, > .disable = lvds_pixel_clk_disable, > .recalc_rate = lvds_pixel_clk_recalc_rate, > - .round_rate = lvds_pixel_clk_round_rate, > + .determine_rate = lvds_pixel_clk_determine_rate, > }; > > static const struct clk_init_data clk_data = { >