From: Neil Armstrong <neil.armstrong@linaro.org>
To: Carlo Caione <ccaione@baylibre.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Da Xue <da@lessconfused.com>
Cc: dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks
Date: Fri, 17 Feb 2023 11:20:12 +0100 [thread overview]
Message-ID: <86b55b41-3faf-dbb8-a072-9a905d111eaa@linaro.org> (raw)
In-Reply-To: <20230210-relax_dmt_limits-v2-1-318913f08121@baylibre.com>
On 13/02/2023 10:32, Carlo Caione wrote:
> Relax a bit the supported modes list by including also 480x1920 and
> 400x1280. This was actually tested on real hardware and it works
> correctly.
>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> In particular relax the resolution checks to allow more resolutions like
> 480x1920 and 400x1280.
> ---
> Changes in v2:
> - Lower the hdisplay limit to support 400x1280 as well.
> - Link to v1: https://lore.kernel.org/r/20230210-relax_dmt_limits-v1-0-a1474624d530@baylibre.com
> ---
> drivers/gpu/drm/meson/meson_venc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 3c55ed003359..fcd532db19c1 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -866,10 +866,10 @@ meson_venc_hdmi_supported_mode(const struct drm_display_mode *mode)
> DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))
> return MODE_BAD;
>
> - if (mode->hdisplay < 640 || mode->hdisplay > 1920)
> + if (mode->hdisplay < 400 || mode->hdisplay > 1920)
> return MODE_BAD_HVALUE;
>
> - if (mode->vdisplay < 480 || mode->vdisplay > 1200)
> + if (mode->vdisplay < 480 || mode->vdisplay > 1920)
> return MODE_BAD_VVALUE;
>
> return MODE_OK;
>
> ---
> base-commit: 38c1e0c65865426676123cc9a127526fa02bcac6
> change-id: 20230210-relax_dmt_limits-355e2a1c7ccf
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-17 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 9:32 [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks Carlo Caione
2023-02-17 10:20 ` Neil Armstrong [this message]
2023-03-06 8:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b55b41-3faf-dbb8-a072-9a905d111eaa@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=ccaione@baylibre.com \
--cc=da@lessconfused.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).