* [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks
@ 2023-02-13 9:32 Carlo Caione
2023-02-17 10:20 ` Neil Armstrong
2023-03-06 8:45 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Carlo Caione @ 2023-02-13 9:32 UTC (permalink / raw)
To: Neil Armstrong, David Airlie, Daniel Vetter, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Da Xue
Cc: dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel,
Carlo Caione
Relax a bit the supported modes list by including also 480x1920 and
400x1280. This was actually tested on real hardware and it works
correctly.
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
In particular relax the resolution checks to allow more resolutions like
480x1920 and 400x1280.
---
Changes in v2:
- Lower the hdisplay limit to support 400x1280 as well.
- Link to v1: https://lore.kernel.org/r/20230210-relax_dmt_limits-v1-0-a1474624d530@baylibre.com
---
drivers/gpu/drm/meson/meson_venc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
index 3c55ed003359..fcd532db19c1 100644
--- a/drivers/gpu/drm/meson/meson_venc.c
+++ b/drivers/gpu/drm/meson/meson_venc.c
@@ -866,10 +866,10 @@ meson_venc_hdmi_supported_mode(const struct drm_display_mode *mode)
DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))
return MODE_BAD;
- if (mode->hdisplay < 640 || mode->hdisplay > 1920)
+ if (mode->hdisplay < 400 || mode->hdisplay > 1920)
return MODE_BAD_HVALUE;
- if (mode->vdisplay < 480 || mode->vdisplay > 1200)
+ if (mode->vdisplay < 480 || mode->vdisplay > 1920)
return MODE_BAD_VVALUE;
return MODE_OK;
---
base-commit: 38c1e0c65865426676123cc9a127526fa02bcac6
change-id: 20230210-relax_dmt_limits-355e2a1c7ccf
Best regards,
--
Carlo Caione
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks
2023-02-13 9:32 [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks Carlo Caione
@ 2023-02-17 10:20 ` Neil Armstrong
2023-03-06 8:45 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-02-17 10:20 UTC (permalink / raw)
To: Carlo Caione, David Airlie, Daniel Vetter, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Da Xue
Cc: dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel
On 13/02/2023 10:32, Carlo Caione wrote:
> Relax a bit the supported modes list by including also 480x1920 and
> 400x1280. This was actually tested on real hardware and it works
> correctly.
>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> In particular relax the resolution checks to allow more resolutions like
> 480x1920 and 400x1280.
> ---
> Changes in v2:
> - Lower the hdisplay limit to support 400x1280 as well.
> - Link to v1: https://lore.kernel.org/r/20230210-relax_dmt_limits-v1-0-a1474624d530@baylibre.com
> ---
> drivers/gpu/drm/meson/meson_venc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 3c55ed003359..fcd532db19c1 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -866,10 +866,10 @@ meson_venc_hdmi_supported_mode(const struct drm_display_mode *mode)
> DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))
> return MODE_BAD;
>
> - if (mode->hdisplay < 640 || mode->hdisplay > 1920)
> + if (mode->hdisplay < 400 || mode->hdisplay > 1920)
> return MODE_BAD_HVALUE;
>
> - if (mode->vdisplay < 480 || mode->vdisplay > 1200)
> + if (mode->vdisplay < 480 || mode->vdisplay > 1920)
> return MODE_BAD_VVALUE;
>
> return MODE_OK;
>
> ---
> base-commit: 38c1e0c65865426676123cc9a127526fa02bcac6
> change-id: 20230210-relax_dmt_limits-355e2a1c7ccf
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks
2023-02-13 9:32 [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks Carlo Caione
2023-02-17 10:20 ` Neil Armstrong
@ 2023-03-06 8:45 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-03-06 8:45 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Da Xue, Carlo Caione
Cc: dri-devel, linux-amlogic, linux-arm-kernel, linux-kernel
Hi,
On Mon, 13 Feb 2023 10:32:09 +0100, Carlo Caione wrote:
> Relax a bit the supported modes list by including also 480x1920 and
> 400x1280. This was actually tested on real hardware and it works
> correctly.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes)
[1/1] drm/meson/meson_venc: Relax the supported mode checks
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=bf458e5b139894234444e4f88500616a8398b719
--
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-06 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-13 9:32 [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks Carlo Caione
2023-02-17 10:20 ` Neil Armstrong
2023-03-06 8:45 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).