From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30EBCE7717F for ; Fri, 13 Dec 2024 17:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x+Dd4Exvw6c5XKfl4Pnp2NyLL6AFhObPU/dE3AuYgbg=; b=wpKPLb9bv/phNQPPyqMkahRCjL haf9Wv4b7gQ0SbCbl8LLfmpxvOl4JKVBFfP2Xk+Wz9DZdQaJ/VrM1cSNUsLgh137x6tVL6G/AGzny iUspOyRlnLGMjKEYvlDPjIP0jHmIF7tNeWu0QB7dStNadlW/P/w3mziIlMHcRP9a8mM8ARwbc2eiP WHQgSZACnayscbyWB9U/tOadUK2euqevYKPgcu9sltGEDsIpmfTH5GQ/p0qTI7+vXIl7fMvCpbFW5 +tl7PhCtx3BbptVCnU+PCC1jIRRw5vl9wEJr4aJD8uJKmfZBGLPr2A/QEWw9IeJEvcFpTFMtQekGH dnyKnRVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tM9HK-00000004XXD-42Yq; Fri, 13 Dec 2024 17:16:38 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tM9GF-00000004XMJ-3FpR for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2024 17:15:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C6D68A42D6C; Fri, 13 Dec 2024 17:13:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CAEFC4CED0; Fri, 13 Dec 2024 17:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734110130; bh=2YJ7aI7lgNgInMsZf1T3jkaRml+zGxaMkU8tu0NSViU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jwFnfZHtJRdNKH+ybm0QEKAg3qZ60IbY6L+VQxt6+YdW6BM9uAmHxcpXyXVYEzrWP zS6eE7+dWYNwAcELVtbJ8ASixRhGLltL43p7NN601ihIoHc2VFp1tK0cOMprJ1iUgy Sv/yj3sFyCi+2fo2qth+eR/ynsRTrG4gbk/sMkoZSQprSQlMZ+xD614plNzaEUwzaO taWeJtDMp8NIklaovuK6UEAV0H4q5z3lNBqUd4nNbTFsOFifCqtH6dCdI7WruFce93 GBWzlkhIQKssH89xiDNeCVssv6vKGkDj+TpS1/rXUQ2h4B3eOJoDPFh4aryZtmsBWI /NKGalKaxhcXg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tM9GC-003W5f-7g; Fri, 13 Dec 2024 17:15:28 +0000 Date: Fri, 13 Dec 2024 17:15:27 +0000 Message-ID: <86bjxfsdw0.wl-maz@kernel.org> From: Marc Zyngier To: Uros Bizjak Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon Subject: Re: [PATCH 1/3] KVM: arm64: timers: Fix percpu address space issues in kvm_timer_hyp_init() In-Reply-To: <20241213145809.2918-1-ubizjak@gmail.com> References: <20241213145809.2918-1-ubizjak@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ubizjak@gmail.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241213_091531_941511_AAF45DF9 X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 13 Dec 2024 14:57:52 +0000, Uros Bizjak wrote: > > Cast return value from kvm_get_running_vcpus() in the __percpu > address space to the generic address space via uintptr_t [1] > to fix a couple of: > > arch_timer.c:1395:66: warning: incorrect type in argument 2 (different address spaces) > arch_timer.c:1395:66: expected void *vcpu_info > arch_timer.c:1395:66: got struct kvm_vcpu *[noderef] __percpu * > > sparse warnings. > > There were no changes in the resulting object files. > > [1] https://sparse.docs.kernel.org/en/latest/annotations.html#address-space-name > > Signed-off-by: Uros Bizjak > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Joey Gouly > Cc: Suzuki K Poulose > Cc: Zenghui Yu > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kvm/arch_timer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > index 1215df590418..a13bb9e8dc19 100644 > --- a/arch/arm64/kvm/arch_timer.c > +++ b/arch/arm64/kvm/arch_timer.c > @@ -1392,7 +1392,7 @@ int __init kvm_timer_hyp_init(bool has_gic) > > if (has_gic) { > err = irq_set_vcpu_affinity(host_vtimer_irq, > - kvm_get_running_vcpus()); > + (void *)(uintptr_t)kvm_get_running_vcpus()); > if (err) { > kvm_err("kvm_arch_timer: error setting vcpu affinity\n"); > goto out_free_vtimer_irq; > @@ -1416,7 +1416,7 @@ int __init kvm_timer_hyp_init(bool has_gic) > > if (has_gic) { > err = irq_set_vcpu_affinity(host_ptimer_irq, > - kvm_get_running_vcpus()); > + (void *)(uintptr_t)kvm_get_running_vcpus()); > if (err) { > kvm_err("kvm_arch_timer: error setting vcpu affinity\n"); > goto out_free_ptimer_irq; I think the fix is worse than the current code, because there is no real semantics behind the pointer being passed to irq_set_vcpu_affinity(). All that is required is that it is a non-NULL pointer. I expect the following hack to work just as well and not suffer from any sparse indigestion. Untested though. M. diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c index 1215df5904185..8058d92048fb4 100644 --- a/arch/arm64/kvm/arch_timer.c +++ b/arch/arm64/kvm/arch_timer.c @@ -1391,8 +1391,7 @@ int __init kvm_timer_hyp_init(bool has_gic) } if (has_gic) { - err = irq_set_vcpu_affinity(host_vtimer_irq, - kvm_get_running_vcpus()); + err = irq_set_vcpu_affinity(host_vtimer_irq, info); if (err) { kvm_err("kvm_arch_timer: error setting vcpu affinity\n"); goto out_free_vtimer_irq; @@ -1415,8 +1414,7 @@ int __init kvm_timer_hyp_init(bool has_gic) } if (has_gic) { - err = irq_set_vcpu_affinity(host_ptimer_irq, - kvm_get_running_vcpus()); + err = irq_set_vcpu_affinity(host_ptimer_irq, info); if (err) { kvm_err("kvm_arch_timer: error setting vcpu affinity\n"); goto out_free_ptimer_irq; -- Without deviation from the norm, progress is not possible.