From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CE66C3DA6E for ; Mon, 8 Jan 2024 09:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8rCbdJxUzfqhbs2Y+EI22DLgcBxRpnSw55EE1+rD3XE=; b=xVRNJRneTC4sr2 5xE2oip1elYpzHCAIsPXWCiplJ4itgn+GjU3XV3U9o+NqEbrtv+4gHsSpHxFEXDVCWP8S+NMrSf4I jA61/jJGo59nlrS6aCIiDKPnEMfoS5LhoPhasDdFSb4KKjCNI/3lvJXpcAyzOByujF0VHZ1SqN4vJ idh2twxnY0J/ndIXPNux9V0acd8LB3idXF1TSAxR+4IlBzjNfnEcD8X8/b+B+834zaw94Ll7CORsv dGk4Nm9bvOu7qDNGo3kEmYsOAS8bwW/VUjqAi0UV3jP8VMab7l6UnSnKesVu0mY4ZG+Aq4ImNZSp5 fp3puW4C8AcNyuGPjlLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMmJ6-004XOE-0Q; Mon, 08 Jan 2024 09:52:32 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMmJ1-004XND-0r for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 09:52:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 14490B80D1B; Mon, 8 Jan 2024 09:52:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66A6CC433C7; Mon, 8 Jan 2024 09:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704707543; bh=akYUu7zgTnARxgKa2BkHmXO+XpLmFkPyFbtYGz0X9jY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EHH+C9VQ0fPHQWw3Q7a7xpBuBy9fsV7MaHI+N5O7PKjPAY124CJSd6tDxEksbqRQH +ZTM+TPF45DinLWT/2/SkMuQ/4ypVaW/TX5O1uEXwyATWGVw2/u4K+9XF3/vMqPxdT SiJI0uYtjxm8gdW5af+RCo3OixIymzEXU5kQQPweyfm1HoP3o2wgrcSnKYjtA3KPst ITYBl+Nu3o/zxg7CHm+fwnetxdsSA8a4y34SQ+vu5Uw0fEQtQxbcg/NVlpqYMxp3K+ xyEiJKoAGA3gJS/Vce1ksBzAEBnmE892tJiViczdSTxS13detuQjDy2GE9fB1M+RQX s0PNZpi8yVxBA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rMmIu-009lGE-PW; Mon, 08 Jan 2024 09:52:20 +0000 Date: Mon, 08 Jan 2024 09:52:20 +0000 Message-ID: <86bk9w9mp7.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, Robin Murphy , Mark Rutland , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Fang Xiang , Robert Moore Subject: Re: [PATCH v4 3/3] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing In-Reply-To: References: <20230905104721.52199-1-lpieralisi@kernel.org> <20231227110038.55453-1-lpieralisi@kernel.org> <20231227110038.55453-4-lpieralisi@kernel.org> <86il499wtf.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, mark.rutland@arm.com, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, fangxiang3@xiaomi.com, robert.moore@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_015227_634734_C10CE598 X-CRM114-Status: GOOD ( 25.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 08 Jan 2024 09:43:23 +0000, Lorenzo Pieralisi wrote: > > On Thu, Jan 04, 2024 at 11:12:28AM +0000, Marc Zyngier wrote: > > On Wed, 27 Dec 2023 11:00:38 +0000, > > Lorenzo Pieralisi wrote: > > > > > > The GIC architecture specification defines a set of registers > > > for redistributors and ITSes that control the sharebility and > > > cacheability attributes of redistributors/ITSes initiator ports > > > on the interconnect (GICR_[V]PROPBASER, GICR_[V]PENDBASER, > > > GITS_BASER). > > > > > > Architecturally the GIC provides a means to drive shareability > > > and cacheability attributes signals and related IWB/OWB/ISH barriers > > > > IWB/OWB *barriers*? Unless you're talking about something else, > > IWB/OWB refers to cacheability, and only that. > > Yes, it should be expressed differently. Unfortunately this sentence made > it into the kernel with the DT counterpart - commit 3a0fff0fb6a3 log, > apologies. Oh well. At least please clean this one up when you repost. [...] > > > + if (!madt_read) { > > > + madt_read = true; > > > > Huh. Why do we need this hack? What's the issue with accessing the > > MADT? Can it disappear from under our feet? While we're walking it? > > It is an awkward attempt at stashing the revision instead of > calling acpi_get_table() repeatedly (and from multiple files > for the same reason - ie get an MADT rev number). > > Side note: get_madt_table() does the same thing and I followed > it - I am not sure it is very helpful either (or maybe > there is something I don't know behind that reasoning). This was introduced as part of 149fe9c293f76, as a cleanup. Not a great move IMHO. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel