From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14BA0EB64D7 for ; Wed, 28 Jun 2023 15:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wrEWCAEkLd7gaF/RtlEUYIA5vsJOaD6sy2ImfizITCY=; b=00FuaqPgCPYaU3 aqm49/crDeRo1hWc2DdS+Ay+s1T0YdO+aPjDcSzpS7hI/tnQHcCjzmczsPDfCaEm/lXZ4hMrqfZFH DfKwofIrB4jMnei4Hm63PQHqYZITrZMlRUzD5Ybw1zk4ryfKXp9DCi+w84vkuf0+csUCL4YXmbRdd yZwZ3kNhD4n0Fz69kmD8wao8lwMfiZgeFv4OJZ+v7zdTAOF+lr15M/GnKr/xjbhOs3/k8uYB47QmM 440LV+sY/DJY3uzDAljMvt+VHKKY/Dgloz4Ky8rwmbC2yosz17D1ElPi4afVMc/k4GCeuw1EkROdX UncNtGjvTDedCMSwKIzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEX15-00Fywj-25; Wed, 28 Jun 2023 15:23:35 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEX12-00Fyw0-28 for linux-arm-kernel@lists.infradead.org; Wed, 28 Jun 2023 15:23:34 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35SEboS8032604; Wed, 28 Jun 2023 15:23:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=WFkKKkqtyqaZFCoepnWbsAmdxJT8uhDZrVsVu73pAn8=; b=PpDvGt6bBkXi6ENnBU9PxLr4o/Js+whE8hX+6ViJxiBV6iFehCdMer9vAeYtApyD4O0u indt7vGInUxJ74kfAQWsHhpuHBN3e1aRvtCYvXwN02zOzSTl8tIBGn+S8dHRFkjfzcCv maeVF726Ny/hXit72YBtIS4iGG8oHhcfJGsSrFZy9vcpAqEMxMc3z/ccNFWEjpbrsWyq tMiN/hcdY/JIZVzFjgz5zBoP858ZKTup0pCYhlF8ahTLKCZzqO31zYJG0TNPvZnoSU8M 2KIV5DLw0j+me7Q674XP2GyZwfuN861dsi7EClb3h2ZCfBAH0sve8fXtRwf+Ueh8IfI6 sQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rgexthah8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 15:23:11 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35SFNBOM008369 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 15:23:11 GMT Received: from [10.216.26.159] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 28 Jun 2023 08:23:01 -0700 Message-ID: <86c104a6-a685-4d05-08f4-e1be595f9d31@quicinc.com> Date: Wed, 28 Jun 2023 20:52:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 02/21] kallsyms: Export kallsyms_lookup_name Content-Language: en-US To: Pavan Kondeti CC: , , , , , , , , , , , , , , , , , , , , , , References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com> <1687955688-20809-3-git-send-email-quic_mojha@quicinc.com> From: Mukesh Ojha In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: xhyixVggvep4Hpw--p5GRvSXPJDLqlTn X-Proofpoint-GUID: xhyixVggvep4Hpw--p5GRvSXPJDLqlTn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-28_10,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 mlxlogscore=870 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306280137 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_082332_701657_012D3550 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/28/2023 7:23 PM, Pavan Kondeti wrote: > On Wed, Jun 28, 2023 at 06:04:29PM +0530, Mukesh Ojha wrote: >> Module like minidump providing debugging support will need to >> get the symbol information from the core kernel e.g to get >> the linux_banner, kernel section addresses bss, data, ro etc. >> > One might ask why we would need such a debug driver to > be compiled as module? What would you do if we need to capture more > kernel data structures later? Do you plan to continue use > kallsyms_lookup_name() to query all the symbols? You are on point, i needed this driver to be static but i don't have any example at present to collect more than just _linux_banner_ from my existing set of patches.. Agree, it will be easier to make this driver as static instead of opening up the doors for modules to abuse via exporting kallsyms_lookup_name() and also it will be very slow for production kernel uses. > > I have seen v3 discussion where you are asked to compile this driver > as module but that time there was no reason why your driver needs to > be compiled as statically, now you have a reason (linux_banner) for > it. Yes, at present minidump driver will not be able to compile without exporting kallsyms_lookup_name() -Mukesh > >> commit 0bd476e6c671 ("kallsyms: unexport kallsyms_lookup_name() >> and kallsyms_on_each_symbol()") unexports kallsyms_lookup_name >> due to lack of in-tree user of the symbol. Now, that minidump >> will one of its user, export it. >> >> Signed-off-by: Mukesh Ojha > > Thanks, > Pavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel