From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C55C07E95 for ; Sat, 10 Jul 2021 12:38:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D14A0613AF for ; Sat, 10 Jul 2021 12:38:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D14A0613AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=6HQeG9an5n3v1Ppy/5UUpzzDZvMl09wSPnXXMg8+Nnk=; b=pCvZezOKjZhgYEQxaqXzJW3dcS UJv3vBVj0stHn2F8NrXmCvfhsHgnCVSOlAn/VcImZptiTxo95itDvFV0eg77XGK5jEfKj7m+TsYRi SyFVnUsy4tHSIGE5cRk2UBnCjPLlCzMhyfBt1CZ0z3wLrfcOPWVrW8Dsoe3lCXY2yWJZhOEq84iZV anexhxG5uoy5s+2OwFZlMMUprXZz3tjvW2lRJ4pvoPeAat8BIH3VaUeD5hy27WqyXbdgN41QOQUUg 4K+aMXt6jJA9pNkdJ1R+AUowrUZ4mUpemJRHjBOF/eijYnaRGw/d9pJTZcMW6tvQFec3GlL9tP4Pf IUEtQcvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2CE2-003e80-PW; Sat, 10 Jul 2021 12:36:54 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2CDx-003e5n-7E for linux-arm-kernel@lists.infradead.org; Sat, 10 Jul 2021 12:36:51 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10040"; a="273657798" X-IronPort-AV: E=Sophos;i="5.84,229,1620716400"; d="scan'208";a="273657798" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2021 05:36:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,229,1620716400"; d="scan'208";a="629174899" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.79]) ([10.237.72.79]) by orsmga005.jf.intel.com with ESMTP; 10 Jul 2021 05:36:40 -0700 Subject: Re: [PATCH v3 07/10] perf: Cleanup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT To: Leo Yan , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20210704071644.107397-1-leo.yan@linaro.org> <20210704071644.107397-8-leo.yan@linaro.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <86cd5d3d-2441-2f8e-28ab-54802e47c68b@intel.com> Date: Sat, 10 Jul 2021 15:36:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210704071644.107397-8-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210710_053649_335278_C1F45D1C X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/07/21 10:16 am, Leo Yan wrote: > Since the __sync functions have been dropped, This patch removes unused > build and checking for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT in perf tool. > > Note, there have a test for SYNC_COMPARE_AND_SWAP and the test file is > located in build/feature/test-sync-compare-and-swap.c. Since there > still has several components using the sync functions, it's deliberately > to not be removed. I don't quite follow that. If they aren't using the feature test macro, then why keep the feature test? > > $ cd linux/tools > $ git grep __sync_val_compare_and_swap | awk '{ printf $1"\n" }' > build/feature/test-sync-compare-and-swap.c: > include/asm-generic/atomic-gcc.h: > testing/selftests/bpf/progs/atomics.c: > testing/selftests/bpf/progs/atomics.c: > testing/selftests/bpf/progs/atomics.c: > testing/selftests/bpf/progs/atomics.c: > testing/selftests/futex/include/atomic.h: > testing/selftests/futex/include/futextest.h: > > Signed-off-by: Leo Yan > --- > tools/perf/Makefile.config | 4 ---- > tools/perf/util/auxtrace.c | 5 ----- > 2 files changed, 9 deletions(-) > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index eb8e487ef90b..4a0d9a6defc7 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -349,10 +349,6 @@ CXXFLAGS += $(INC_FLAGS) > > LIBPERF_CFLAGS := $(CORE_CFLAGS) $(EXTRA_CFLAGS) > > -ifeq ($(feature-sync-compare-and-swap), 1) > - CFLAGS += -DHAVE_SYNC_COMPARE_AND_SWAP_SUPPORT > -endif > - > ifeq ($(feature-pthread-attr-setaffinity-np), 1) > CFLAGS += -DHAVE_PTHREAD_ATTR_SETAFFINITY_NP > endif > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index 44bd04dbb6d6..db6255b55c90 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -130,11 +130,6 @@ int auxtrace_mmap__mmap(struct auxtrace_mmap *mm, > return 0; > } > > -#if BITS_PER_LONG != 64 && !defined(HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT) > - pr_err("Cannot use AUX area tracing mmaps\n"); > - return -1; > -#endif > - > pc->aux_offset = mp->offset; > pc->aux_size = mp->len; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel