From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FE08EFD20E for ; Wed, 25 Feb 2026 08:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CjKAStcG/ShPpPx56WtB+ba+NAoKwkKSIfhyRj/ggsw=; b=LOcZMPLUDpOXQ38b1zFAkJtqij 0kFuEobkU0/MTDesLPVFazLJaYX2dlcTpMQrbKieMUBPhkQTaqLdx6rXfzH47FqsRZqzON+cwsPYn 40+rg8iXFKFl3MWTVtOqZftp0i89e6KvSiiSGRlCo5J17v3hEh9dtL9pH7gRaQlkj/UEI5aYAGyEG 7J4BQo0hqXlzKKNdl+P8ZSAG+QJb8IF2oSonHHS2C8zxR1//GIgyoguSv3U1tarWjPOtH9SFsTELT YuBU8YAIO5G4Ghb95hAFiopVTGfswcCTNF86ErTushN6/pRUWXLn7d6gt/OpIu7uGfuJG5qagHYNP pmBGrITg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvAdV-00000003aSK-1Pke; Wed, 25 Feb 2026 08:52:49 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvAdR-00000003aRr-0Huk for linux-arm-kernel@lists.infradead.org; Wed, 25 Feb 2026 08:52:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5373744367; Wed, 25 Feb 2026 08:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31E4BC19423; Wed, 25 Feb 2026 08:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772009564; bh=nxiB4eR3ZUkyJ3dWbA+IdTm3cCYRhc1g98xGjy3nX7U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q0+eB3cBcwVZZ0ujGJcgnP96sAYAvEwZmoxSktiYSXrlUz7OulAvaIPxJvAQTqB7y tuSk+nGjtcM8zQXn3M9h1AiZmW2UMgbdD/ysrldHldnsrPIiWgrDAvqeoAfGtjQ+St 4f1tWCxufHirdq6jP88dY41ID6zocpMOrme4yZMDJ7usFxyQMSVriYgg1ALouo3UIf IHwdFvAlNXHUv4qZsnGa409vsvaKTbTrFa/Kz9uerjDkcytvOaH//pf3DxTpiz0Ciz L4q3RQcWCCcD9zzf7dddtkupY+RjRcZfF9yKrFpbyhox0llqtxJ+dI7ERamO9Utv9D lpw2CscKzVKZQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vvAdN-0000000DdAm-3G3y; Wed, 25 Feb 2026 08:52:41 +0000 Date: Wed, 25 Feb 2026 08:52:41 +0000 Message-ID: <86cy1t9pd2.wl-maz@kernel.org> From: Marc Zyngier To: Sascha Bischoff Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , nd , "oliver.upton@linux.dev" , Joey Gouly , Suzuki Poulose , "yuzenghui@huawei.com" Subject: Re: [PATCH] irqchip/gic-v5: Fix inversion of IRS_IDR0.virt flag In-Reply-To: <20260225083130.3378490-1-sascha.bischoff@arm.com> References: <20260225083130.3378490-1-sascha.bischoff@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: Sascha.Bischoff@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, nd@arm.com, oliver.upton@linux.dev, Joey.Gouly@arm.com, Suzuki.Poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260225_005245_124190_4F658151 X-CRM114-Status: GOOD ( 20.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Feb 2026 08:31:40 +0000, Sascha Bischoff wrote: > > It appears that a !! became ! during a cleanup, resulting in inverted > logic when detecting if a host GICv5 implementation is capable of > virtualization. > > Re-add the missing !, fixing the behaviour. > > Fixes: 3227c3a89d65f ("irqchip/gic-v5: Check if impl is virt capable") > Signed-off-by: Sascha Bischoff > --- > drivers/irqchip/irq-gic-v5-irs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v5-irs.c b/drivers/irqchip/irq-gic-v5-irs.c > index e518e5dfede78..f3fce0b1e25d9 100644 > --- a/drivers/irqchip/irq-gic-v5-irs.c > +++ b/drivers/irqchip/irq-gic-v5-irs.c > @@ -699,7 +699,7 @@ static int __init gicv5_irs_init(struct gicv5_irs_chip_data *irs_data) > */ > if (list_empty(&irs_nodes)) { > idr = irs_readl_relaxed(irs_data, GICV5_IRS_IDR0); > - gicv5_global_data.virt_capable = !FIELD_GET(GICV5_IRS_IDR0_VIRT, idr); > + gicv5_global_data.virt_capable = !!FIELD_GET(GICV5_IRS_IDR0_VIRT, idr); > > idr = irs_readl_relaxed(irs_data, GICV5_IRS_IDR1); > irs_setup_pri_bits(idr); Gah. Apologies for the overly eager cleanup. I'll take that in the next batch of KVM fixes. Thanks, M. -- Without deviation from the norm, progress is not possible.