From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C4E0C83F1A for ; Fri, 11 Jul 2025 12:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X5eycw+cztZ82tcWFUCBaHqi/zjlZsCZCpaV+CP0FP8=; b=sAQzxvQn2S6Ksww0fHrS0g/NfO aBaQ1QQ7I6lm9ibqYbtHpUQ6LAxYijc8f57ESZt/nhS2px7elIcCnB0dxz8MzNsOe1UbsnVdIfJAE MF8TlsgSxMFq+DPPystizTh/U9wOkG56JpL0kFiEDxBZVFZAKICOC+5CTMgYPrRzJdq9Tr+HEn4R8 haYAqHxDgX4TVF6K9GKnt0TpBCzupTaH5qJwax/7yYC60ZNrKjpjFrsAJ7j7Y7l/ce4MP+0B2EtYY nOTJTX9fzv+I/uxRwGV7AXxfbrm65emFR97jnIuomIQQkSoP/zoyxb0v9E1+1GVrMPJ5B6weVBz3R x76PuoFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaD6u-0000000Em07-26w2; Fri, 11 Jul 2025 12:44:16 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaBLy-0000000EWZd-1Qfo for linux-arm-kernel@lists.infradead.org; Fri, 11 Jul 2025 10:51:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A60F6A54DE0; Fri, 11 Jul 2025 10:51:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E6DC4CEF4; Fri, 11 Jul 2025 10:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752231101; bh=84BMvuy9Pk8YrU/GpAF8QkVxJqmSioEdul6p6Hjaas8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j8hj78NkD71YdFzBqvHsQJbSBSgu9I4hzkRnOEj/kjR36IMWi68LRMOzqoUQPn2x5 6pIzQK5S+UYCJVZxQ1NFAmQ0FCdQsPdKxtf0vG8wCudjXLSmchmTL+aDsmkXyTRpvl MhYKPu7xnvwdeWPlJ5DZ5OqvpqQkVmezKz6SFoFnihU9MwLhx/momFAOxAEGwdIwwG LwaFbPNIe/nIceApqIht/C5MEZjbkyztuCcQL2UIgC8nIeeTs26ae6QLLZSBn2iomN RAXxnD81+Nvirs2ZQpTz3D5TCPKYc24jH1xlp32xHmUh5HM49fzaTadIg9mViuIkwA myZTLQaGFiZgw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uaBLv-00EqW3-79; Fri, 11 Jul 2025 11:51:39 +0100 Date: Fri, 11 Jul 2025 11:51:38 +0100 Message-ID: <86cya79f0l.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Toan Le , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Thomas Gleixner Subject: Re: [PATCH v2 09/13] PCI: xgene-msi: Sanitise MSI allocation and affinity setting In-Reply-To: References: <20250708173404.1278635-1-maz@kernel.org> <20250708173404.1278635-10-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, toan@os.amperecomputing.com, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250711_035142_442356_EE481812 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Jul 2025 11:11:02 +0100, Lorenzo Pieralisi wrote: > > On Fri, Jul 11, 2025 at 11:55:17AM +0200, Lorenzo Pieralisi wrote: > > On Tue, Jul 08, 2025 at 06:34:00PM +0100, Marc Zyngier wrote: > > [...] > > > We could use MSInRx_HWIRQ_MASK, I can update it. > > > > More importantly, what code would set data->hwirq[6:4] (and > > data->hwirq[7:7] below) ? > > Forget it. It is the hwirq allocation itself that sets those bits, > 256 HWIRQs you use the effective cpu affinity to steer the frame, > it makes sense now. Exactly. > > I can update the code to use the mask above and merge it. > > Sorry for the noise, No worries, and thanks for looking at it! M. -- Without deviation from the norm, progress is not possible.