From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3DA7C27C4F for ; Tue, 18 Jun 2024 08:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Zui29RPq2twSnX1XNIZkOOoivnkIXQDN5AMLsXHnl0=; b=KMeXUflRX6O6F3XmjMSrG5mBwQ lL4+idwFhb6CpJaACwkqZ3zPZ8rNipnGhoAw58QbzRlwL+vvovbcvHNyNRqAbCCBVrNz/ED7MZGA2 7szJ4vZiXtE+1vWCYQGRG1ONmWpZFp+Dt2EY+W9axCCy3O16/1cw4kCK77/6yihOR/eQUvKsVGtHX 6INL+Vc6rMH8/5T8oY2Kitk0/lOFau2A8WsKec0+IhjE4kX7+L6rOq6MHn0XXN1fi+dHm8hCvRMCr eyfvFw9YkRc/qa3PBEdBvGO+OrtYqafj2NuBDQu6nPLv0ihnhcnAtMx2IFQKXpwl88fRZnQFrZWHX OePlEU6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJU0J-0000000E3fM-17OE; Tue, 18 Jun 2024 08:15:47 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJU0F-0000000E3eA-3Q5M for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 08:15:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F060CE1247; Tue, 18 Jun 2024 08:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1E01C3277B; Tue, 18 Jun 2024 08:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718698540; bh=iYioEWORDDUMLHtKnujTc36m4+0j/4elywu9H2FX8UQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OMnw/u+pJ6a9Sb30gXqTMC78NV+7Mdo/Q3XtkF3C8QAzLBPb6c8BveAHaLw2f1SR4 UMqEFyr9cvZVbObLQetIsi+5rNsvfXo1ruqiSz2IIPH+Wa34sBRpLkFkeJquZ+6jHP cOzKGttDTC/0pfURvv0KlVj9fqH+umGW7PaQadMDLMnX8p4v5UPr/EH1vLbYh2s4q4 HyAANnAJ5QCLIQHk5n2NRQS1XdGC7OrLLkWBzyWbUZTojDbMbiKBn0GXfqkuDIzkUL V5WdpCM8WJTWSAHtZjaRi9LEpGTsZnUUKjqSL3Cv7gV7EMEgXrcZkOi7gltII5YiT4 /GXoXw17gfK1A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sJU0A-004sL0-JB; Tue, 18 Jun 2024 09:15:38 +0100 Date: Tue, 18 Jun 2024 09:15:37 +0100 Message-ID: <86cyoek6om.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, ryan.roberts@arm.com, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] arm64/mm: Stop using ESR_ELx_FSC_TYPE during fault In-Reply-To: <20240618034703.3622510-1-anshuman.khandual@arm.com> References: <20240618034703.3622510-1-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, ryan.roberts@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_011544_084285_9F291EAC X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2024 04:47:03 +0100, Anshuman Khandual wrote: > > Fault status codes at page table level 0, 1, 2 and 3 for access, permission > and translation faults are architecturally organized in a way, that masking > out ESR_ELx_FSC_TYPE, fetches Level 0 status code for the respective fault. > > Helpers like esr_fsc_is_[translation|permission|access_flag]_fault() mask > out ESR_ELx_FSC_TYPE before comparing against corresponding Level 0 status > code as the kernel does not yet care about the page table level, where in > the fault really occurred previously. > > This scheme is starting to crumble after FEAT_LPA2 when level -1 got added. > Fault status code for translation fault at level -1 is 0x2B which does not > follow ESR_ELx_FSC_TYPE, requiring esr_fsc_is_translation_fault() changes. > > This changes above helpers to compare against individual fault status code > values for each page table level and stop using ESR_ELx_FSC_TYPE, which is > losing its value as a common mask. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.