From: Marc Zyngier <maz@kernel.org>
To: Kunkun Jiang <jiangkunkun@huawei.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
moderated for non-subscribers
<linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
"wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>
Subject: Re: [bug report] GICv4.1: doorbell interrupts will be lost in a corner case
Date: Wed, 24 Jan 2024 12:43:48 +0000 [thread overview]
Message-ID: <86cytq9a0r.wl-maz@kernel.org> (raw)
In-Reply-To: <4edc4d02-5c0b-a2e5-897a-7e60fbb0f3e3@huawei.com>
On Wed, 24 Jan 2024 08:54:24 +0000,
Kunkun Jiang <jiangkunkun@huawei.com> wrote:
>
> Hi all，
>
> In chapter 8.5 ("Doorbells") of the GIC spec, the affinity of
> doorbell interrupt is described like this:
>
> > Doorbell interrupts target the Redistributor the vPE is
> > currently mapped to, based on the previous VMAPP or VMOVP
> > command for the vPE.
> The doorbell interrupt here should refer to all types of
> doorbell interrupt, right?
There is only one type of doorbell.
>
> When GICv4.1 is enabled, the doorbell interrupt will be
> truned on only when kvm handles WFI exit. There is a
> corner case where will lost doorbell interrupt:
> 1. doorbell interrupt enabled
> 2. the cpu which the vPE is mapped to is manually offline
> through 'echo 0 > /sys/device/system/cpu/cpuX/online'
> 3. According to the description of chapter 8.5 ("Doorbells"),
> the doorbell interrupt coming at this time will still
> be sent to the offline cpu.Then the interrupt will be
> lost.
>
> Should we add a cpu offline callback to handle the
> doorbell interrupt mapped to this cpu?
That seems gross. The right way to do it is to track the affinity of
the doorbell (which we already do), and let the core code move the
interrupt somewhere else in this case (which is should already do).
Have you actually witnessed this issue? Or is that just idle
conjecture?
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-24 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 8:54 [bug report] GICv4.1: doorbell interrupts will be lost in a corner case Kunkun Jiang
2024-01-24 12:43 ` Marc Zyngier [this message]
2024-01-25 13:26 ` Kunkun Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cytq9a0r.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=jiangkunkun@huawei.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).