* [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS
@ 2025-11-25 10:27 Ben Horgan
2025-11-25 15:26 ` Marc Zyngier
2025-11-27 19:15 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Ben Horgan @ 2025-11-25 10:27 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: catalin.marinas, will, maz, oliver.upton, Ben Horgan
The define ARM64_FEATURE_FIELD_BITS is now unused and feature id
fields don't always have 4 bits. Remove it.
Signed-off-by: Ben Horgan <ben.horgan@arm.com>
---
It is still used in tools/testing/selftests/kvm/arm64/set_id_regs.c
but this uses the define in tools/arch/arm64/include/asm/sysreg.h.
I have submitted a separate patch to remove it from these as well:
https://lore.kernel.org/kvmarm/20251125101207.1492580-2-ben.horgan@arm.com/
Based on Linux 6.18-rc4
---
arch/arm64/include/asm/sysreg.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
index c231d2a3e515..1f3303d09a27 100644
--- a/arch/arm64/include/asm/sysreg.h
+++ b/arch/arm64/include/asm/sysreg.h
@@ -1129,8 +1129,6 @@
#define gicr_insn(insn) read_sysreg_s(GICV5_OP_GICR_##insn)
#define gic_insn(v, insn) write_sysreg_s(v, GICV5_OP_GIC_##insn)
-#define ARM64_FEATURE_FIELD_BITS 4
-
#ifdef __ASSEMBLY__
.macro mrs_s, rt, sreg
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS
2025-11-25 10:27 [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS Ben Horgan
@ 2025-11-25 15:26 ` Marc Zyngier
2025-11-27 19:15 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2025-11-25 15:26 UTC (permalink / raw)
To: Ben Horgan; +Cc: linux-arm-kernel, catalin.marinas, will, oliver.upton
On Tue, 25 Nov 2025 10:27:32 +0000,
Ben Horgan <ben.horgan@arm.com> wrote:
>
> The define ARM64_FEATURE_FIELD_BITS is now unused and feature id
> fields don't always have 4 bits. Remove it.
>
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS
2025-11-25 10:27 [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS Ben Horgan
2025-11-25 15:26 ` Marc Zyngier
@ 2025-11-27 19:15 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2025-11-27 19:15 UTC (permalink / raw)
To: linux-arm-kernel, Ben Horgan; +Cc: will, maz, Oliver Upton
On Tue, 25 Nov 2025 10:27:32 +0000, Ben Horgan wrote:
> The define ARM64_FEATURE_FIELD_BITS is now unused and feature id
> fields don't always have 4 bits. Remove it.
>
>
Applied to arm64 (for-next/sysreg), thanks!
[1/1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS
https://git.kernel.org/arm64/c/27abb1ee5a4e
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-27 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-25 10:27 [PATCH v1] arm64/sysreg: Remove unused define ARM64_FEATURE_FIELD_BITS Ben Horgan
2025-11-25 15:26 ` Marc Zyngier
2025-11-27 19:15 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).