From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC6BAC52D6F for ; Wed, 21 Aug 2024 13:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QLi63w3GTshmLuTL3HJ7/EitFZl0gKUfnLI98tmir14=; b=nrEKqmTe3uXPe9ELYFcb+39b8b 2bBtFDzPneGiXnXWbZT0ROUYoAB3sx1izaxwfLheYoQAG1ubqh2S6tPplS9ZWT7z3EUd1kys92V6C T046osRPVKeed/LTSP0szVUgFGEFStq/4nsoPhte/4iQyd+oQE9iKVRfsLz/+dtRVxN1FXSpGqCNF 9rkQe7452NvNn/5mReHieXmnk9u60Lo1p+pgyUz+wUEamnmbotnXpDI3xnvqB0Cd47tR4B4zWrw7H 99aLmgeFFo3M3397avp0XFzgHt4nL0pU34M1fzZ6EgKfqf1y3sBIxJ8iwPZ8tSOu4MSZ+n9iU+L3/ 7It5MAsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglgA-00000009BMG-1LwX; Wed, 21 Aug 2024 13:47:14 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglfR-00000009BGO-0mep for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 13:46:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8E7ACA41C6B; Wed, 21 Aug 2024 13:46:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD5DFC32782; Wed, 21 Aug 2024 13:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724247987; bh=K0I2LmOVKPqYuEGAfHzeGjhEUY2uSjqj5ZyhfoHUFYc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MlnlOxR8cd8v8rtNwSSX3AYvxy6PwEZqIDw4TmYOm/qy1zenQIrymaXakByyNnNiJ KZsCScFhXklkoCu2lSbhsl37lWRwH7Q9pPI53Ll55vQK99v0jvetw6VE55jMDBcXRW s3Bgek9TO4ffKlANwN+rpfRdY5s1mxUKNOta3q5J0gI/o5uGB4Z1+qFBP+8/Tnx92O nNhR378CYR03uBOXcwzqPhVGK7V4C2KooqZJbyzINHijyN2gr9KWX/U8tjQz493u3X yR/ToXSNWI8adG1SPXpeOV5glEnwMVQb/La0rxZrk1LGSQ+JiXKqVAwfcF+tw03kIT ghVoaloQPXOgQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sglfN-005bo9-TJ; Wed, 21 Aug 2024 14:46:25 +0100 Date: Wed, 21 Aug 2024 14:46:25 +0100 Message-ID: <86ed6ixa32.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Joey Gouly , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] KVM: arm64: Control visibility of S1PIE related sysregs to userspace In-Reply-To: <20240821-kvm-arm64-hide-pie-regs-v1-0-08cb3c79cb57@kernel.org> References: <20240821-kvm-arm64-hide-pie-regs-v1-0-08cb3c79cb57@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_064629_311862_703DC11C X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 21 Aug 2024 14:07:14 +0100, Mark Brown wrote: > > While looking at the KVM system register code I noticed that we do not > have visibility operations for TCR2 or the S1PIE registers, I may be > missing some reason why they are not required but in case I'm not I > figured the most direct way to ask was to propose adding the operations. > > Signed-off-by: Mark Brown > --- > Mark Brown (2): > KVM: arm64: Hide TCR2_EL1 from userspace when disabled for guests > KVM: arm64: Hide S1PIE registers from userspace when disabled for guests > > arch/arm64/include/asm/kvm_host.h | 6 ++++++ > arch/arm64/kvm/sys_regs.c | 31 ++++++++++++++++++++++++++----- > 2 files changed, 32 insertions(+), 5 deletions(-) If you are going to do this, please add it on top of [1], and handle the corresponding EL2 registers. Thanks, M. [1] https://lore.kernel.org/20240813144738.2048302-1-maz@kernel.org -- Without deviation from the norm, progress is not possible.