From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DF95C3DA63 for ; Tue, 23 Jul 2024 15:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gi4amxy3T5/KwQRhVkuwLlto5wTZ3bWOfTv1QeuftNo=; b=ExMubMh1uApxhUC16iwkgKJhDs Fnuv7nkB50GUVIgueZBM7NA8K4f/+1fw/HjkzXtEQN8S8toryRTcRIEeC9FhRBZoH/GnZ8O2Wy5Je qHT9m29a5gzRWIllZ7HebYD2ADwaUrPzhP7kTttCKUvLXmp8LsybpIwPx+rTWFp+WuqNNM9tqEJ1j s+5Jdf9IRNH8+BxLQSBVZg3JclnipaGX4C/CXy8YV4LfzmHV7FcVOvGGKGPTYm92gPbshgGnhx3E1 XdAlT3Ghi1chQiUH6c7d+FZCLNq88Q0ESNVMCIMyhShkrMHGfPeqi6gKcG4tqy+iLfxxfr8WTIp2g PbPU/h3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWH0E-0000000CoqY-1IiO; Tue, 23 Jul 2024 15:00:34 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWGzp-0000000Coi5-41AO for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 15:00:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 483F1CE0FA6; Tue, 23 Jul 2024 15:00:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 807DCC4AF0A; Tue, 23 Jul 2024 15:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721746807; bh=4DA2XWj/UrCTxITuQswP8CQ61smzRnN3hRrP34Z4cjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DS8tyUU7ud8/42wIElau7PNvNstxx1rBpQJsMWYVk7f2lSjpmVbhmFHPe9+c9hfpk VBgE9UrvxsFvKSDG48exXBpp+gG0xG3iIqp8BeUD5EMT5Bv0JGKtL/K6V25AlRdK4h Q3P1v6REJ9KW1lClfN4IWnqikeciltd3NRDbMjJ8XsGBBmtWdB8OHGjBXeMvbW8KuN cn1UX3iiCtpCunQS1t0Wru+kjo3MnEzmyIDzLgwvaEZRoJFXe9F4OpviPJ3IfEgS5J Go1GsLGygzVNXIXo5qbEXwbKxWmLDnSFoU2Tzfm6McroBfpgC9mvo2lE2ZYhM7kQ8l ViH3XDspvDiQw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sWGzl-00Ekd3-3P; Tue, 23 Jul 2024 16:00:05 +0100 Date: Tue, 23 Jul 2024 16:00:04 +0100 Message-ID: <86ed7k2lxn.wl-maz@kernel.org> From: Marc Zyngier To: Danilo Krummrich Cc: oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: free kvm->arch.nested_mmus with kvfree() In-Reply-To: <20240723142204.758796-1-dakr@kernel.org> References: <20240723142204.758796-1-dakr@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dakr@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_080010_210731_252C57EA X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Jul 2024 15:20:52 +0100, Danilo Krummrich wrote: > > kvm->arch.nested_mmus is allocated with kvrealloc(), hence free it with > kvfree() instead of kfree(). > > Fixes: 4f128f8e1aaa ("KVM: arm64: nv: Support multiple nested Stage-2 mmu structures") > Signed-off-by: Danilo Krummrich > --- > arch/arm64/kvm/nested.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index de789e0f1ae9..bab27f9d8cc6 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -786,7 +786,7 @@ void kvm_arch_flush_shadow_all(struct kvm *kvm) > if (!WARN_ON(atomic_read(&mmu->refcnt))) > kvm_free_stage2_pgd(mmu); > } > - kfree(kvm->arch.nested_mmus); > + kvfree(kvm->arch.nested_mmus); > kvm->arch.nested_mmus = NULL; > kvm->arch.nested_mmus_size = 0; > kvm_uninit_stage2_mmu(kvm); > Ah, nice catch. Thanks for fixing it. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.