From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C85FDC27C4F for ; Sat, 29 Jun 2024 09:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yQyWUTm2NbBMw9Mmaj68N7NKU133uMPYr97y/+4USDQ=; b=eaY3VfaycJBq4avQK89eyeerpZ WmAYc0swX8i2b/10KUOISr8BOrh6jVk0ajAXYEVwfN0YNcqbR3qsTiI7nKiAPoggXei+xr00eUN/Z PQcHD6LowLHY9k+l4VD9xy27CsjJe0FP4WdBLC9TWZ/tPkvyZ1y2JC8Mw6X0rrY8OQi/NJ+9/eN80 +/oHt1yj2vTIpT3V13GFP6T+PDZP56+KaT9aWl0P9KFJJGeaLo7ftBKzIvOfzvTXjAjKMmrzAhAY+ Jf+PJgRnwYnQevZCJqFRZtwbjQg2AbtibiJ2Qw/0Qdu4Bb5jmSz72e+koH1m9OO1qbe8euqW7+hyX blhwVsOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNUbb-0000000GCQ1-2RQL; Sat, 29 Jun 2024 09:42:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNUbR-0000000GCNf-1K9D for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 09:42:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D257960AD9; Sat, 29 Jun 2024 09:42:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B81C2BBFC; Sat, 29 Jun 2024 09:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719654158; bh=BNNwzhKnHmw3rVL1Hj8hEgbZxO4UQj1Vb6cTbftgi4c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qe/cTuAJZcDIEhzQYiIkPtmspp01y9HJ0A2EzQOBgHOhWTdD8+QE0oBsdZdq/+mPJ bBAmUO6jxJrbcBEUrHPjXMSPUGEnDCv8cuV5go6NXF1QenPSxPF4v3mv5aZhEagBp5 4c2UhIJDIivegzm1b0eop9OZ+ExEAi8Q31nnlWFe3O9cPzLj04rxRr3UfOZN0q7zp1 QnPH/w9+lurrRFMpQNdtZrikYUwy0ymo0e1cd5VpOqyMngju5XZ+xgVCF/SJeSsIvO hQs9fMV1yyg5XqM3qKGhhkEvbhU33Va8wChvq6bUDa+rumCIGh7ZPfiLQwjnxdznLS eTvOK2ImlPvZg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sNUbL-008MrS-T7; Sat, 29 Jun 2024 10:42:35 +0100 Date: Sat, 29 Jun 2024 10:42:35 +0100 Message-ID: <86ed8ghypg.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: Catalin Marinas , LKML , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X] In-Reply-To: <87h6dcxhy0.ffs@tglx> References: <20240623142137.448898081@linutronix.de> <20240623142235.024567623@linutronix.de> <87h6dcxhy0.ffs@tglx> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240629_024241_464153_BFEEAF86 X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 29 Jun 2024 09:37:59 +0100, Thomas Gleixner wrote: > > On Fri, Jun 28 2024 at 23:24, Catalin Marinas wrote: > > I just noticed guests (under KVM) failing to boot on my TX2 with your > > latest branch. I bisected to this patch as the first bad commit. > > > > I'm away this weekend, so won't have time to dive deeper. It looks like > > the CPU is stuck in do_idle() (no timer interrupts?). Also sysrq did not > > seem able to get the stack trace on the other CPUs. It fails both with a > > single or multiple CPUs in the same way place (shortly before mounting > > the rootfs and starting user space). > > From the RH log it's clear that PCI interrupts are not delivered. > > > I'll drop your branch from the arm64 for-kernelci for now and have a > > look again on Monday. > > I stare too. Unfortunately I don't have access to such hardware :( On the face of it, the LPIs are never unmasked (grepping in /sys/kernel/debug/kvm/*/vgic-state): Distributor =========== vgic_model: GICv3 nr_spis: 32 nr_lpis: 7 enabled: 1 P=pending_latch, L=line_level, A=active E=enabled, H=hw, C=config (level=1, edge=0) G=group VCPU 0 TYP ID TGT_ID PLAEHCG HWID TARGET SRC PRI VCPU_ID ---------------------------------------------------------------- [...] LPI 8192 0 1000001 0 0 0 160 -1 LPI 8193 1 0000001 0 0 0 160 -1 LPI 8194 2 0000001 0 0 0 160 -1 LPI 8256 3 0000001 0 0 0 160 -1 LPI 8257 4 0000001 0 0 0 160 -1 LPI 8320 5 0000001 0 0 0 160 -1 LPI 8321 6 1000001 0 0 0 160 -1 8192 and 8321 are pending, but never enabled. This is further confirmed by placing traces in the guest. Now trying to find my way through the new maze of callbacks, because something is clearly missing there. M. -- Without deviation from the norm, progress is not possible.