From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22439C77B7A for ; Thu, 18 May 2023 15:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ObeT2ysapPNPb20n779ojXpp21Y99WUxyLgXLmRzBpE=; b=AB8k83klL7E5Js bR10U7eurPWdWkDoz72YPo/IMwCYMBeNtFqxXqcbAEsH7vTmHrFTA/xQkZ1VoHGv34rKsD9FCkmPp dGDxMnxc8g9CpfTrVqFmSF2VpZs8J+hG7ZM6514zVVhRWnqm1hP0hJM3RZSLqcxtZkkntB2tIlvMw rI/3pc6/aVxjc6J1ZQhPvMQR7bTxx3GxCL38DmeE7VFZ8n2Cx0ARm36Fdopeu2fl6xOKmUxiJDkK9 T0IJqKppIH1eW2x1rnguanw0y6RfhzpTN/lpFrzkflfmOFjhbBhfvquK28+3PCbWb4km5Nub2+7vT 4jI1ZyIE1AvrA4aJsT0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzfzY-00DN1E-1i; Thu, 18 May 2023 15:56:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzfzV-00DN0h-2U for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 15:56:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CB6965070; Thu, 18 May 2023 15:56:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02804C433D2; Thu, 18 May 2023 15:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684425391; bh=y+xVDC8A3JFbZEhpJihTQMvxr9/6MH0gJb+0A74LjTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jCs2bq3NqyaGmTzFDlbNsQfLZNNayt9Vuv8KxNPXn5YcwMJroNTWf4BSwqtVhQkRI /ZsInm3J7Zfr4CAoY+pw81MwenlhwvdWEajIjGnlzzT6d5rkYFgSgj9l8LvOMVs5he PMWa2aRQV4oqPAANEtLDC4ZQvU7N8ahO3GZ+MCVHnDaqvpPd9AU29vbckFW8Ext+8T vyKqthrM+/vTuSJwWhfbBIRc2UxGd/H5lIcfBft7k53IWRHbW9X5q5byPK14YKuew2 05ME/pJCFMsnPEVAXSQH7GjAi9EjVv0LjgY+kDYjmYONioTTvHvdU35lBOrhjxhzzT VlScw/w2VyItg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pzfzQ-00GBQP-JI; Thu, 18 May 2023 16:56:28 +0100 Date: Thu, 18 May 2023 16:56:28 +0100 Message-ID: <86edndljkj.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, "Justin M . Forbes" , Mike Rapoport , Andrew Morton Subject: Re: [PATCH] arm64: Make the ARCH_FORCE_MAX_ORDER config input prompt unconditional In-Reply-To: <20230503123342.90538-1-catalin.marinas@arm.com> References: <20230503123342.90538-1-catalin.marinas@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, jforbes@fedoraproject.org, rppt@kernel.org, akpm@linux-foundation.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_085633_912135_659D3D1F X-CRM114-Status: GOOD ( 27.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 03 May 2023 13:33:42 +0100, Catalin Marinas wrote: > > Commit 34affcd7577a ("arm64: drop ranges in definition of > ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and > introduced an EXPERT condition on the input prompt instead. This change > may affect some distro kernels that change ARCH_FORCE_MAX_ORDER but do > not want to enable EXPERT. > > Drop EXPERT from the input prompt together with the (ARM64_4K_PAGES || > ARM64_16K_PAGES) condition as the latter no longer makes sense after the > ranges were removed. The latter makes all the page size configurations > consistent w.r.t. ARCH_FORCE_MAX_ORDER. > > Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER") > Signed-off-by: Catalin Marinas > Reported-by: Justin M. Forbes > Cc: Will Deacon > Cc: Mike Rapoport > Cc: Andrew Morton > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index b1201d25a8a4..1867aba83ba3 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1516,7 +1516,7 @@ config XEN > # 16K | 27 | 14 | 13 | 11 | > # 64K | 29 | 16 | 13 | 13 | > config ARCH_FORCE_MAX_ORDER > - int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) > + int "Order of maximal physically contiguous allocations" > default "13" if ARM64_64K_PAGES > default "11" if ARM64_16K_PAGES > default "10" > This patch (and the previous one) has the unfortunate side effect of completely breaking a change of page size (from 4k to 16k, for example): maz@valley-girl:~/hot-poop/arm-platforms$ make defconfig *** Default configuration is based on 'defconfig' # # configuration written to .config # maz@valley-girl:~/hot-poop/arm-platforms$ egrep 'PAGE_SHIFT|MAX_ORDER' .config CONFIG_ARM64_PAGE_SHIFT=12 CONFIG_ARCH_FORCE_MAX_ORDER=10 maz@valley-girl:~/hot-poop/arm-platforms$ make menuconfig configuration written to .config *** End of the configuration. *** Execute 'make' to start the build or try 'make help'. maz@valley-girl:~/hot-poop/arm-platforms$ egrep 'PAGE_SHIFT|MAX_ORDER' .config CONFIG_ARM64_PAGE_SHIFT=14 CONFIG_ARCH_FORCE_MAX_ORDER=10 The build then fails in ways that aren't obvious (BUILD_BUG in the THP code). It would much better if the result of the configuration tool would produce something that can actually build. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel