From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ABF8C77B7F for ; Tue, 16 May 2023 09:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OFqAWrw7J0KFD25x+7V/N+TuEGJCX37vS6fLrVKxYEM=; b=flb2W+8QA1heQJ La27LJvnN8Ml+UO57EfviIv4JkhVmDiEdjtYEr6Ott7p6BLyrDbCZXWu9hJl8hkm6AST0w8Ng3uuK CssVDCJbD+N1cjmJgIYG8ujGmFXJg6Wr/5EGvlfmcEdbvgf5MqpGN0+ZDC/8wxCuYdvIxEd5PK8vF zWzYJj7QOyWDJQp+EQxWFaZd4NJK9j7xSR4LJfeu3XhzmBBJ0JepdFxbIiPIE8XBDL9U4W6bdPG8v f/vM7TnVShf9HgriZNfLgeUG0ML3bjLmtWLS2oBbDCzcpQLL2BD755GaPKkcHjeYqFBDc85c6HH4e nV2KTSoVykR7ff8AxObQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyrRw-005A71-1J; Tue, 16 May 2023 09:58:32 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyrRt-005A61-1Q; Tue, 16 May 2023 09:58:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C146063166; Tue, 16 May 2023 09:58:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25618C433D2; Tue, 16 May 2023 09:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684231108; bh=0JLTG2Li8PG49+9IlKqTZkMJijzI0L6DUEsV5TZGNU0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kNZzqvm2N+ME5VpzfirrvTTWqlFxeUsBqC1EZNijP2dNem8CSY75XJX7oy2UWoxPe ldI7Ncnyz6Nwy38BrjpLpQGlT5tPvvXatHT4T5xZE+M75ATCjCryS7C+R6Me1fTHzj Hm8AFU821OuXFKqN7fg95WSq/83veBUWJhmy06vdpqmlxeAcnNXB0D7t9RNgmqOGLk SlNjAWF5XXz5eE0I8FnvIx381EoRJNrLayS3UqtWnJcERB2pr1quQkjNF+eSEwLdp5 C9pgXlQuqSqBTRyTJX9XU9Ft0fx8XXvBjWqOYe8wdYhusDfouKAf3RrxJ9Z5laWQx/ qJTmK8kMijSFg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pyrRp-00FUTg-H6; Tue, 16 May 2023 10:58:25 +0100 Date: Tue, 16 May 2023 10:58:24 +0100 Message-ID: <86edngmwcf.wl-maz@kernel.org> From: Marc Zyngier To: Douglas Anderson Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allen-KH Cheng , linux-mediatek@lists.infradead.org, Eddie Huang , Hsin-Hsiung Wang , AngeloGioacchino Del Regno , wenst@chromium.org, yidilin@chromium.org, Tinghan Shen , jwerner@chromium.org, Weiyi Lu , Ben Ho , Seiya Wang , Conor Dooley , Enric Balletbo i Serra , =?UTF-8?B?Ik7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIg==?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek Chromebooks w/ bad FW In-Reply-To: <20230515131353.v2.cover@dianders> References: <20230515131353.v2.cover@dianders> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dianders@chromium.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, allen-kh.cheng@mediatek.com, linux-mediatek@lists.infradead.org, eddie.huang@mediatek.com, hsin-hsiung.wang@mediatek.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, yidilin@chromium.org, tinghan.shen@mediatek.com, jwerner@chromium.org, weiyi.lu@mediatek.com, Ben.Ho@mediatek.com, seiya.wang@mediatek.com, conor+dt@kernel.org, eballetbo@kernel.org, nfraprado@collabora.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_025829_564727_CA5D089E X-CRM114-Status: GOOD ( 27.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 May 2023 21:13:49 +0100, Douglas Anderson wrote: > > As talked about in the bindings patch included in this series > ("dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for > Mediatek SoCs w/ broken FW"), many Mediatek-based Chromebooks shipped > with firmware that doesn't properly save/restore some GICR > registers. This causes the system to crash if "pseudo NMIs" are turned > on. > > This series makes sure that we never allow turning on "pseudo NMIs" if > we are running with the problematic firmware. > > The patches in this series can land in any order and can go through > entirely different trees. None of the patches are harmful on their > own, but to get things fixed we need all of them. > > v2 fixes the quirk name and also moves the quirk out of the SoC.dtsi > file and into the Chromebook file. This, unfortunately, means that > mt8186-based Chromebooks are no longer handled since they don't appear > to be upstream yet. :( > > Changes in v2: > - "when CPUs are powered" => "when the GIC redistributors are..." > - Changed "Fixes" tag. > - Moved from mt8183.dtsi to mt8183-kukui.dtsi > - Moved from mt8192.dtsi to mt8192-asurada.dtsi > - Moved from mt8195.dtsi to mt8195-cherry.dtsi > - mediatek,gicr-save-quirk => mediatek,broken-save-restore-fw > > Douglas Anderson (5): > dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek > SoCs w/ broken FW > irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware > issues > arm64: dts: mediatek: mt8183: Add mediatek,broken-save-restore-fw to > kukui > arm64: dts: mediatek: mt8192: Add mediatek,broken-save-restore-fw to > asurada > arm64: dts: mediatek: mt8195: Add mediatek,broken-save-restore-fw to > cherry > > .../interrupt-controller/arm,gic-v3.yaml | 6 ++++++ > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++ > .../boot/dts/mediatek/mt8192-asurada.dtsi | 4 ++++ > .../boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++ > drivers/irqchip/irq-gic-common.c | 8 ++++++-- > drivers/irqchip/irq-gic-common.h | 1 + > drivers/irqchip/irq-gic-v3.c | 20 +++++++++++++++++++ > 7 files changed, 45 insertions(+), 2 deletions(-) I'll take the first two patches as fixes. The rest can be merged via the soc tree as required. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel