From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFB56C61DA4 for ; Wed, 22 Feb 2023 10:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wVOYcNjGnK90Wr837bBRL98PWPD2g7fIbCDMD5oWEJ4=; b=pjL1ksR93MmB4v Jf9MbdDe/wSj2qFxY/CdGfOPJo9rMVzIEEQihg/ANRceXWtUmGfFguQixlwXu2C4BJKaNNOn+emi+ xmeMLR6m9ilGRwgPI3rM8Zn+O6DTHrkSxWnpmqah5JMUrZRq2m8KGPYItgi+pt13rAcHdHJKsUE+x W2HhKhT/GgKhAu7d778M+NcN3weZ1CnCQCZJtweBZ2DinyeUNFuwqKKDcq/tqloW54lRJ53gGVt4F D1YFcXJbpxzxVHZz+cNIgbfPiZDTHz5iiRIXvkbR4u2aZzVEJp1QQWyuhg/+YY9rBu2AMcGXkIwNG xR54DYr3I1CIczGDmmhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUmf2-00C3uZ-SS; Wed, 22 Feb 2023 10:47:45 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUmex-00C3sa-Qd for linux-arm-kernel@lists.infradead.org; Wed, 22 Feb 2023 10:47:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B90DB8123A; Wed, 22 Feb 2023 10:47:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BEE8C433D2; Wed, 22 Feb 2023 10:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677062857; bh=RxaCZgS3HlLRwESOI7a3H2MXN/i6tMp4RaaiUDcjBzw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dhV0YekXLHGEzUISBq07PKzIfXpZxbIv/7LT4M3v/XF237KCW+58WgpfLk/Wh/lxo CFrTbKoORVCLJ2mxHYTaxRIWf3TjFy0X1v3IudOfFvnMDZAjzLeJBo9L6YfsMwuYsi Qs6x5s0SartrL0Tb8TlG5yUIHpN4ozYG4JmVvGsSzg6ReRjGgj49Jks7OliB90mUG9 Z31QS6Ru+QtL/z584kMYFXTxt/DrnhDXWSZP/ETcv4B/w9xYv3HE2K0DU1gpyOH+Iv onHj9laIpHm6xDXIGHWPmrwgcXPotKxQQ61do7fT/hTQpzXrFdnGt1zSeNnpJb7wi1 4V7eA4Cmf+RrQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pUmes-00CKWj-Se; Wed, 22 Feb 2023 10:47:34 +0000 Date: Wed, 22 Feb 2023 10:47:33 +0000 Message-ID: <86edqix9h6.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Ricardo Koller , Simon Veith , dwmw2@infradead.org Subject: Re: [PATCH 02/16] arm64: Add HAS_ECV_CNTPOFF capability In-Reply-To: References: <20230216142123.2638675-1-maz@kernel.org> <20230216142123.2638675-3-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230222_024740_176636_389B8AB4 X-CRM114-Status: GOOD ( 23.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Feb 2023 04:30:00 +0000, Reiji Watanabe wrote: > > Hi Marc, > > On Thu, Feb 16, 2023 at 6:21 AM Marc Zyngier wrote: > > > > Add the probing code for the FEAT_ECV variant that implements CNTPOFF_EL2. > > Why is it optional is a mystery, but let's try and detect it. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kernel/cpufeature.c | 11 +++++++++++ > > arch/arm64/tools/cpucaps | 1 + > > 2 files changed, 12 insertions(+) > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index 23bd2a926b74..36852f96898d 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -2186,6 +2186,17 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > > .sign = FTR_UNSIGNED, > > .min_field_value = 1, > > }, > > + { > > + .desc = "Enhanced Counter Virtualization (CNTPOFF)", > > + .capability = ARM64_HAS_ECV_CNTPOFF, > > + .type = ARM64_CPUCAP_SYSTEM_FEATURE, > > + .matches = has_cpuid_feature, > > + .sys_reg = SYS_ID_AA64MMFR0_EL1, > > + .field_pos = ID_AA64MMFR0_EL1_ECV_SHIFT, > > + .field_width = 4, > > + .sign = FTR_UNSIGNED, > > + .min_field_value = 2, > > Nit: You might want to use ID_AA64MMFR0_EL1_ECV_CNTPOFF (instead of 2) ? Ah, of course! ;-) > Reviewed-by: Reiji Watanabe Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel