From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70AB4CD6E44 for ; Thu, 28 May 2026 10:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hxafBVxBhxizzK5NE9P/7nJ1FC3CnetncTxpOBAxpdk=; b=I7asZ5pqP7hG8+vJ12dCTmsB4K pEyMZEdu+QOD6Cq70bSFpsGfb63d0zVuVryfP3zpOkFEUAbWmHqp9QyifXQjTfBzQ7wLSa/hmksc8 ylxE4PO0o2iHmdTJHWpVOQafsAtBAibL6Q7D2Ds+w6kLiQ0PbG3yiGIqekOqHIqW8F9MDa4S01+KD M7Ua70pt/59uhuL9GoXgScZLdD90/q20cMo0fZCBQYQzPd8Zn8EL9Ix3MCzwVIRqZXsdDeraxiglc izc03cfBA/kXc7j6cYXW8YoDXI/ean00YcJ6WMTcCIeOXqE/rDaqyIlLd8tBdxO7LRyE51N9NRL0q hVbKsuMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSXpz-00000005aJ9-45ep; Thu, 28 May 2026 10:19:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSXpx-00000005aIn-44sR for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2026 10:19:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 24F50404DB; Thu, 28 May 2026 10:19:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0531E1F000E9; Thu, 28 May 2026 10:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779963577; bh=hxafBVxBhxizzK5NE9P/7nJ1FC3CnetncTxpOBAxpdk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jM1qH2LxjhJjFZwslPk2ueorJ3P7YzUQUam3KgDQJ9WOAreWExD56LRZkjxMrBaKV mzfACAfnlbZjRzs5CbYSayhPqMz/8V/g9mhYHSa/nyKpXfEj9bilfS60q4Bv3M+MdF FvE2DmdAngBZrEi/KiZ30DO1DlAjQeMxM/+WBK/oMfPtPhDE4KT1LFKuNR4AzO4Kw2 ZpCH9fMy0LDrxZk54aw12EzIHFOjBqlss2u3nEUB8aJkusa7QghTmdQQKiXgqNXGV5 KzaoWNhYRlMRnWdbrA/dH16742fdq7O6nqQlkfq4A+Yx7P/3cehoU3uEDzozgVmrO1 Geh7iP1SoqhqQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wSXpu-0000000700q-3lTn; Thu, 28 May 2026 10:19:35 +0000 Date: Thu, 28 May 2026 11:19:34 +0100 Message-ID: <86fr3bvnt5.wl-maz@kernel.org> From: Marc Zyngier To: Itaru Kitayama Cc: Wei-Lin Chang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon Subject: Re: [PATCH v3 0/5] KVM: arm64: nv: Implement nested stage-2 reverse map In-Reply-To: References: <20260510145338.322962-1-weilin.chang@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: itaru.kitayama@fujitsu.com, weilin.chang@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260528_031938_072584_CEF36F6A X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 20 May 2026 08:31:12 +0100, Itaru Kitayama wrote: > > Hi Wei Lin, > > On Sun, May 10, 2026 at 03:53:33PM +0100, Wei-Lin Chang wrote: > > Hi, > > > > This is v3 of optimizing the shadow s2 mmu unmapping during MMU > > notifiers. > > > > Two new preparatory patches are added, one reduces a hole in kvm_s2_mmu > > and another refactors the code a bit during s2 faults. Other changes are > > listed below. > > > > * Changes from v2 [1]: > > > > - Removed "polluted" teminology. > > > > - Use xa_{mk, to}_value() when storing and retriving values from maple > > trees. > > > > - Avoid using the 63rd bit in maple tree values so that xa_{mk, to}_value() > > does not lose us a bit. > > > > - Added reverse map removal during TLBI handling. > > > > - Other suggested refactorings. > > > > Thanks! > > With this series applied on the recent kvmarm/fixes (minor local modification), > your v3 hello_nested runs fine on all three page granules; without this 16KB > kernel can't handle stage 2 unmapping paths. I tested using the latest QEMU only > so wonder how you're testing. Can you clarify this statement? Are you saying that 16kB S2 unmap do not work with upstream? That seems odd, as it would mean NV wouldn't work on Apple HW, which represents two thirds of my development boxes... Thanks, M. -- Without deviation from the norm, progress is not possible.