From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B9E310A88E2 for ; Thu, 26 Mar 2026 16:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kCuq0CvhS9n+WdIm4mK7r+0jxzykOe3qHSsFefweB/I=; b=YEqPDlhS5SmnhvTb93nrtWurZi dkVdFMLY/wdp+R5kPdQklDAZ13W2pzWWqsveNs7zTT8/M26F1sH3jThQjoDPme080hlOJSKOnoiMt 57BeElbBLeMs6u4OqW48C2j/Msnm5TwThlVMQY10JUqsGwpeWBbsdKWASgGs9aFWlXwUc5Nr4+XE2 IY33OWs1G6T8KsoQeEYq32IasWCtB+usB3JqmzEuVn+GQp9CP9BoEJQUzLE2wfM4PgoZ4L+j46HfE gpHxfeSOVT+v3n+O4L2jQW/qTYo+rHv16Lv5uBgp8tQBt5ZgTbndHNan8+D8s4wFFmooBruIWMzi5 v2RABWvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5n8P-00000005oZs-08sw; Thu, 26 Mar 2026 16:00:37 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5n8M-00000005oZh-2PeA for linux-arm-kernel@lists.infradead.org; Thu, 26 Mar 2026 16:00:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8E01A60127; Thu, 26 Mar 2026 16:00:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37DA3C116C6; Thu, 26 Mar 2026 16:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774540833; bh=suSxf+cexdkRqgiCTVxM2+SaDbXf2T9H5jOvQ4DS/yo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pkmNb9d36WTAWrcg85iRDMqVsEBvSSFp6FJmcMvTprkrSlZmmauv3pQ0Z1wYGid7n 2QkqlumUYj4WwTS9W5VRmrZdMy19a5YvbgeddG1eppNfDVSXzTT33g2EYTFYLp8ynC TsmClxYJJDrNSOXTtbQ8JVoDitctK9c+GVHVzNzGBX9Kl7UDVRLONXnrXCVWWcN/Pz 0cFwLciqlkv9X0VmK9Vjq23voH8YGgv3qM7YZGQUlugOlEa9N58URJhLqIVS/N5Ksf BtyJ2yfeGMosE4on2g2imarshY4cz1XvSTuZ4BrkJDL+/v/1Ukf3YvUgG6Pf109Boh q8/AZ0t+XnmqA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w5n8J-0000000610M-1ZN0; Thu, 26 Mar 2026 16:00:31 +0000 Date: Thu, 26 Mar 2026 16:00:31 +0000 Message-ID: <86fr5m4m3k.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] irqchip/gic-v3: Print a warning for out-of-range interrupt numbers In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: geert+renesas@glider.be, tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 06 Mar 2026 12:13:32 +0000, Geert Uytterhoeven wrote: > > gic_irq_domain_translate() does not check if an interrupt number lies > within the valid range of the specified interrupt type. Add these > checks, and print a warning if the interrupt number is out of range. > > This can help flagging incorrectly described Extended SPI and PPI > interrupts in DT. > > Signed-off-by: Geert Uytterhoeven > --- > This would have prevented the issue fixed by "[PATCH] arm64: dts: > renesas: r8a78000: Fix out-of-range SPI interrupt numbers"[1]. > > v2: > - Fix off-by-one error in PPI range check. > > [1] https://lore.kernel.org/1f9dd274720ea1b66617a5dd84f76c3efc829dc8.1772641415.git.geert+renesas@glider.be/ > --- > drivers/irqchip/irq-gic-v3.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 20f13b686ab22faf..9e97505d4b767043 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -1603,15 +1603,27 @@ static int gic_irq_domain_translate(struct irq_domain *d, > > switch (fwspec->param[0]) { > case 0: /* SPI */ > + if (fwspec->param[1] > 987) > + pr_warn_once("SPI %u out of range (use ESPI?)\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + 32; > break; > case 1: /* PPI */ > + if (fwspec->param[1] > 15) > + pr_warn_once("PPI %u out of range (use EPPI?)\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + 16; > break; > case 2: /* ESPI */ > + if (fwspec->param[1] > 1023) > + pr_warn_once("ESPI %u out of range\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + ESPI_BASE_INTID; > break; > case 3: /* EPPI */ > + if (fwspec->param[1] > 63) > + pr_warn_once("EPPI %u out of range\n", > + fwspec->param[1]); > *hwirq = fwspec->param[1] + EPPI_BASE_INTID; > break; > case GIC_IRQ_TYPE_LPI: /* LPI */ Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.