From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B8ACC369D1 for ; Tue, 22 Apr 2025 20:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LXsn8wtIMjjN/gReGMqtFpduOKsBTAck1o+dSS1WiS0=; b=O/IVIt2Ygz8f7EGaJgWxb8DCe7 5ePWlrAGGpAHARGOtAVGfTsj7QvpCjc6lTAvGpZh9FH5b85YNmTXRSvIH/+r39jV2qlzZ1Y9IgZ/W UiYXK2t/6yCtqljCDTjvEjNQhPLzEuE2PLPU6XrFillxjDq8Lb/pXn2y1K/EEiWhtzezh/eYMi0oq EVy2t7XJQau2anjdxmXzV9FPuviJhkNP0ysFWCtK9PApZJxhVzGalSG3ELkxyearuuFv0y60oJTdl 6ueODUQhxFfV97Bq/SOLzh4RqH0nKestkkCKakbU6adR5zVDRHnXlWpFsxJBbQPjyIuJP7F+yh/Fo 4Xn17CdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7KfT-00000008X3Q-3RBI; Tue, 22 Apr 2025 20:56:35 +0000 Received: from mail-westusazlp170130003.outbound.protection.outlook.com ([2a01:111:f403:c000::3] helo=SJ2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7Kda-00000008Wrn-1DEW for linux-arm-kernel@lists.infradead.org; Tue, 22 Apr 2025 20:54:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GrMELXiGY55RwUuZLRVdeifdNc+ehD28SQfvHXVbDLIEV3AdjSCA1vIJsq8JGVpp0yAU0itQHGuKeEycVws/XZ11iWqjOBvo1HsdNpCayRhakXfP5zcuFksSbP5ihWUZpJ7mUs/+Deh9jifB94U/L6HtfzE0OtpZK6ZMNTE77YHh/DOTu5Z8NyHJ+rX+E5vA8Mro/nnD7247LoaUjoGBNssGKG5+/8fv5BHrFqgKGAUsywFyGtcr4pELmi38b+hc0UXgnLkPQm6eFVSncK14ZpPaJakkT79nVqkXquFOHFhIqEzShj1T0O5r5MIn42JxHoqEH/k8dbNtOv61TrlShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXsn8wtIMjjN/gReGMqtFpduOKsBTAck1o+dSS1WiS0=; b=QeDxw+WqFr+VI8dWbBiP7WYSoUrgRSPXvFn7UliOtO+E+dgauQUmsoxB2WvUtz/dKYUYNSeLsxYEtYGES+PiI5hmGTnqjjyN7fX3kALz5CIUWCFsrecv3DuGycGQzsVss/VF1K8O8Gg2eahrrt8gDSAWUzgsCYQiKd6FlRxJsk77Wi5W9qBMNKWrTHafT6t3+Ol6gBtJyPmlb7ZUt/OhUvH07LcZu2DW0XQp8jp7v6OgimYF9FqIIj56ioUfj//3yk4XuCe+yAXTktYWQNQs+NtP4ejCgqCx/xXFbW137wE3z7+gw3ZUVuK3FhoP/aHJHycqk9j0+ub0Maa4pTwA/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXsn8wtIMjjN/gReGMqtFpduOKsBTAck1o+dSS1WiS0=; b=awHi1jTGwMnFmfh4LIa4OwRls4zvXzCEY4cK/Cq03uFc/nd8BvidXfu66jYBb4IVftWhD1XIURrutP6weV8sHulC56EX0pVyhg/33DyiHDCJJVzx4wlkzvH3Dgeb+yV9hoGi9+3c9R261E1yyHTQjH7o0n8e2xOqWp3aBaRk3/4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DS7PR01MB7782.prod.exchangelabs.com (2603:10b6:8:7d::17) by CY1PR01MB9267.prod.exchangelabs.com (2603:10b6:930:104::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.35; Tue, 22 Apr 2025 20:54:31 +0000 Received: from DS7PR01MB7782.prod.exchangelabs.com ([fe80::b3b0:a90:453a:e924]) by DS7PR01MB7782.prod.exchangelabs.com ([fe80::b3b0:a90:453a:e924%6]) with mapi id 15.20.8678.021; Tue, 22 Apr 2025 20:54:31 +0000 From: D Scott Phillips To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Cc: Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH 2/3] KVM: arm64: Teach address translation about access faults In-Reply-To: <20250422122612.2675672-3-maz@kernel.org> References: <20250422122612.2675672-1-maz@kernel.org> <20250422122612.2675672-3-maz@kernel.org> Date: Tue, 22 Apr 2025 13:54:26 -0700 Message-ID: <86frhzyl19.fsf@scott-ph-mail.amperecomputing.com> Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0276.namprd04.prod.outlook.com (2603:10b6:303:89::11) To DS7PR01MB7782.prod.exchangelabs.com (2603:10b6:8:7d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR01MB7782:EE_|CY1PR01MB9267:EE_ X-MS-Office365-Filtering-Correlation-Id: b2a502f4-c749-40f2-da11-08dd81dfe0e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VezdylssVLf9KE66ZOn29kip2FpChYjMo/Pshvfbiv2mfWIoFTFI04BFFvOk?= =?us-ascii?Q?zyy8kc//JI2V6x5XUKYIp3d/fmku9wzRPD0v1AW/rOv1TA7ycikJV2nbh8Sb?= =?us-ascii?Q?SdixXOg/2GxUoaQCur0QE4rISUHt3YNwgz5TDIRP23r8+mEcq9XU5qC/v8RI?= =?us-ascii?Q?DrPeT0ICwjWhxrMO25Y5z7F1sGmDEUoTQHUlo2o+vDgJCa6qr13QvRtTxH5f?= =?us-ascii?Q?DxcQCQde0sj2DU3c6vgElFK3f8cCVm02AU1Qpf76ox6HNJnpM8+a/g6/IpT/?= =?us-ascii?Q?U36nhGf2vY4OV6PUgI58sZv/Oya31yqVFVuFLaMQGvmFQkEHdcOakCfsstHN?= =?us-ascii?Q?kgbdXLbdpspXOkXTsq5mCWy8Mzy97kMPkWEBUIK9r6o3+tCNqCWZlB8oElL8?= =?us-ascii?Q?A7lfFwrTaaGfWMCa8BKH49UeqUBTOsWP2c9lx773+ySnJcPPOp8ytjHZC3Yf?= =?us-ascii?Q?7BIW564YbQTYcYbTpuMUoyMoH9zAMDBCyU0QhtmvIMEoxVKg/otYngwD47OR?= =?us-ascii?Q?MTYl+lBy9CDWzuw3dFiw0H4t0s//R6xvWU4dOvJQSZJoD966kNW3vvv/C5zN?= =?us-ascii?Q?Ug1LV3kiQPvitk6nQuyeaiDiLFBFg+IdN/Ak/hCwfInGJbYTC7SHmV3fUQwi?= =?us-ascii?Q?S/9FjfDNUL2xU55Da+AGfuhyFisihEbN9/qLu6bqug9qjp4rREX5yXh4RVrZ?= =?us-ascii?Q?X3Z/ZZXrojVry+VdahepkrImGUE2RgJdzsK3C3F8BGdKxdMz/tj+yaIPG1RM?= =?us-ascii?Q?H0zOQBanjOOtwY30QABGa0Kh/P67q7ZVXA6zcFV5nWfA+GkzA2BLsjnFZOr/?= =?us-ascii?Q?y/QK4HukFkGc3g/dsUfGTYAy3+dMC5NjykWW99fU+JzoShG20qVhLIFG/hHV?= =?us-ascii?Q?7nJ0wAe//m6TqUqMYqjEcBIWYiLBmf44JKOvXGQXA9he4NHUuvL3Him8yGjQ?= =?us-ascii?Q?Dkq3AfAoYPiTRGuQcQtKbmfh8HjzN51lOE8nfC7WKo598r9otDpbaQMD7KaK?= =?us-ascii?Q?obkIWhQZpjUd+OK8a5pWgwQqDsTcV0HrC3o0vrOexuOwmyw8WdgM+mOj1XIP?= =?us-ascii?Q?rADfpBB/8Ha9x/FQ441R8Hv7J+l8NIFHkxQ4Om2g82ANit6mtz2TEt++qCEc?= =?us-ascii?Q?JEsPLBPSmVBRQ8t9k0MZeJ3f+ModoG2+6vgNO/pjl1k5uPRWW91lzKDRWIoA?= =?us-ascii?Q?qBcI/VXjFnzklLTlkncd+uaD/NxsW8+jie+vwC5lgrTgbYcj2DRnpZByBr7t?= =?us-ascii?Q?TjbiDCLgFplHzpQ6aVwIq+EQ5F5irlrWPujibqgqBnakY3kmX3CE2/LnHfPF?= =?us-ascii?Q?oJ3VACL1X45wgz5zZJJn718XmcBja+xZlXP9d5LhVcSNmIJ2T17/4dOhMnOs?= =?us-ascii?Q?F4LfZTFjEAK9YHYnK9fHG23nQCZmBH8FZGHioFsLaXthOZfIaE7NDoZ2P9+k?= =?us-ascii?Q?1eHmjR0kAsTYRZuicJXsBMplA/HMArjSiHJwHVLbL4BSxBigWZBNRA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR01MB7782.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W7bi/EvKnwNwNq046mqHXAc5O3TucOltjgpKXgB6nG1i42zvJgNEvKi0WCeO?= =?us-ascii?Q?lDhQcF1qBf212g9LQ/toP84I8dNd+Z+opvbnXDPV+hjPVWqTAUijb8VfUXCq?= =?us-ascii?Q?s9hnvR0yPClDFQR6CTTIwT9lEgMu3w7zW/EVrhmjiHPiXYIXykxDrEf+1B1e?= =?us-ascii?Q?GYXbtgikXznBLwIM6N9CvTMPwEkzDKkumANfYnU/qLOqITvXVtAVgQ0gmvrR?= =?us-ascii?Q?ZvfLtPN7NC8Trl65kr41hvZY6IIvnKO3XB/VBUqrsXdaa73ekyFOhzWsCBh4?= =?us-ascii?Q?Z2rcE8JWTfbdhPQypkT3sL2vgvgjVrn4Jsq3++m0/dxdYXLUNG5nPHSxr2Rg?= =?us-ascii?Q?slfFrT6Ln08uJGj2oBCaBaO5JiKlMreQJ11Y5cJfe91+GWaqU5MvKQQsTtKm?= =?us-ascii?Q?6Cq7IDGjxR/lb7LJIN6ZWhBJKzOTvrxg+KbEHKoipeSAD8pwyHk9vXWviSRI?= =?us-ascii?Q?lNMPPFDRtrMMxPFUmSKvl/lIPo2xFc9aP9L41NpX2uqfy/wjG2j+7WPo7smC?= =?us-ascii?Q?nr9wI416GSUFWwlaNN1h3bKv2GlODD9BzGV531RMzgGrCjIzULQ53xDB4V1f?= =?us-ascii?Q?lTRpt6xB4QDCzbSWp4TPo2JBIJF+ErMTJGsdHFhqItB9eW7P6A30S3ZMp22p?= =?us-ascii?Q?JpGuuocMRQe4zdlyNnxKKspZGj42BdoyBIBQW5Hd9CU1DXMVEJ+OiVTqjqGh?= =?us-ascii?Q?p6dE+Qsv+UA7imOMUps0N3NRZhJh5JuRTBa55Xij5AQaS9gLYFIxjYZDp9lE?= =?us-ascii?Q?ZqK0QSK35ntOcQLAvwJfywJPc2fieWnwfyW1QJu8VIOccF+zGwY6fIfktfzu?= =?us-ascii?Q?AzqObJlKJbPT3tjDIdM/txae7YHYC26COmNlz2A5r0CKj4wm44mfF9vDvYwS?= =?us-ascii?Q?dCQHyqijSewEkJTdBHZ1jp6spk/A2x1RFGhL2POPXn8xtumfqIOPgeOGkodX?= =?us-ascii?Q?KGv855LiIwkyDqpTLF9tsr8Z1cyZTvoPZn9ttQ9inY9cvSqKI+K8JMnqxqKZ?= =?us-ascii?Q?RS2VSQj+zsmuCApKiX+vXSMbtgv+t1rX/Ai0kjK0rdt/qhuzAVXzrNBmqnCJ?= =?us-ascii?Q?2c1VeCriS9Mr0VDanLOGLx4u8Qh0qoUpvSGg6gbsdGPFIXOIMGm2V/36NlMK?= =?us-ascii?Q?BjTYNMAcCQUpYqb2mKxe0mk0su7iT/i7dI1cKs2QPTT+3NwwLsQ41XQeRjy9?= =?us-ascii?Q?+yDbqWC32HNB7Y4o58baLYJGDV5QPrRBUQKgoha6okbX3uNkoLYW/0Ag7sOs?= =?us-ascii?Q?xgYzS5FfrEupEznhSmrRUFaE0xfBPgvb8n9XejNEErsICQejIZB6U7LekmSQ?= =?us-ascii?Q?HW3/nfajsC2Pr1oSlUCN/kjvKGx9AVVBmjWtIbCORiUoA+vN9B6e4jLFx655?= =?us-ascii?Q?YIe5za6dNjC2VqCNee1MbIN089J26RNkJUj7VapICqQU7lBF6uEg9oWWGoXh?= =?us-ascii?Q?cSewa1JONu4sX3P241iBV6uwLsAbzeHIHhAwn+SPl9AxwtqSwGCvPe+zXSGf?= =?us-ascii?Q?7tpmElDoD/uWVqyVk8yoBiA3ar4MF5lAKFDNnHh8980VV9uBRFOcKfNKaY1J?= =?us-ascii?Q?7fzjxJUi5Df6MS7wHlRKtGpbfTrHDMWMM2pkVeSF3ENHnWVTToyMYYHGES5H?= =?us-ascii?Q?izhg5fYKoAcZLB0ul9N3E4I=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2a502f4-c749-40f2-da11-08dd81dfe0e7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR01MB7782.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2025 20:54:30.9179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5qmBITcgYGHy6LDiGEM3pEVKJVLVpV6s3F1zrIFJ9X07voGHJ2AOEtTInc7MwnuoPNYSrQ8S2Suhs7I3mEdfZkcKC8JyMvRDHb7qv11YqwV2hvzO6IpNvi6NfloJRm5n X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR01MB9267 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_135438_338069_C737B78F X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Marc Zyngier writes: > It appears that our S1 PTW is completely oblivious of access faults. > Teach the S1 translation code about it. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/at.c | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > index 3a4568e2de910..c40583edebc4f 100644 > --- a/arch/arm64/kvm/at.c > +++ b/arch/arm64/kvm/at.c > @@ -456,6 +456,11 @@ static int walk_s1(struct kvm_vcpu *vcpu, struct s1_walk_info *wi, > if (check_output_size(desc & GENMASK(47, va_bottom), wi)) > goto addrsz; > > + if (!(desc & PTE_AF)) { Shouldn't this depend on TCR_ELx.HA == 0?