From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1A5EC0219B for ; Fri, 7 Feb 2025 17:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6XB2Oc/FhDgobnT3Hw+HhSPBFb/59SO9aXoZLju3UaQ=; b=snLyQ3qYq3cewMf14cZfdifXGk vGHk/rFB8WGI8ElAsFUP/nTeDr0Nt/boX1bBWh7TcOV7OWaiVFyGeZcH7D0RaSZLB1hlVxalZ76Qx rzbVtn8ZiVvdvULhuUgrGk63Q4PpPHTWZvTBg6y5YVaqel84NI0iKBFx5nS88/6bad5ZlvwtGQhXy 0+LfkbA1ESaZs4clyyH5MJluEgBUUKoaVaPlScVkM2K7uD9goih3bQcDkubrKo6tPXwsyX0Eh1YKI yMEugc4b0niKT0X4jW9SJlxh6etDub6qVqAa9+l+5KYLH1GiUja5CUrCRVpuSAgP3XLCbgnGq/zmD a9VVAcqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tgSZl-0000000AaDE-3lZS; Fri, 07 Feb 2025 17:55:37 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tgSQ6-0000000AXmm-1RtT for linux-arm-kernel@lists.infradead.org; Fri, 07 Feb 2025 17:45:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4AC9EA4386B; Fri, 7 Feb 2025 17:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7EA6C4CED1; Fri, 7 Feb 2025 17:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738950336; bh=3AhHH+IIgrOYeTXC6491GVKSYE85dc/aXAWC+t2j57k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DQq0ZdCrM+etyDgProVmvATLt+I/WsYPwrRdfuN5VYwcoPttACqy0tBNOVwlZRw6L C0ZhxuhkHHvFJPA6cM0FaYYWtOxkgWXmNPz3gBJmiaSmZ4KIhvYAfiBqJWVLj0PYBj 2CKDZJRijCY/S1npPSa8o+hKzheh9fi1JUOlJHKhma2NxyAO0ozFvk5zm3Eqz9hoqJ IqxMVpRf5gPF9tYvCZrvZH2V8vq8Ul0VQDNoTSc7/DMaNj70hmPaYnk0BdnqCOyD/4 cB13jEpLhvix8J8wNhYVAaHTGJn/5kw6g3/NXT+tOkqs4+HcWDF0vycF2UFN+IAUVb GyidZ/cVo6ICA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tgSQ2-001jBl-7g; Fri, 07 Feb 2025 17:45:34 +0000 Date: Fri, 07 Feb 2025 17:45:33 +0000 Message-ID: <86frkptzr6.wl-maz@kernel.org> From: Marc Zyngier To: Eric Auger Cc: Ganapatrao Kulkarni , kvmarm , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, christoffer.dall@arm.com, suzuki.poulose@arm.com, will@kernel.org, catalin.marinas@arm.com, coltonlewis@google.com, joey.gouly@arm.com, yuzenghui@huawei.com, darren@os.amperecomputing.com, vishnu@os.amperecomputing.com Subject: Re: [PATCH] KVM: arm64: nv: Set ISTATUS for emulated timers, If timer expired In-Reply-To: References: <20241209053201.339939-1-gankulkarni@os.amperecomputing.com> <867c89tc4q.wl-maz@kernel.org> <865xntt2kv.wl-maz@kernel.org> <8be59ff3-6a68-48e1-8181-0ce4b2e7180f@os.amperecomputing.com> <86y10osr19.wl-maz@kernel.org> <4d443db1-85b1-4071-acd5-3187deb9cb17@redhat.com> <2f6b2cb1-3d32-480a-9801-9b993ae74e2d@os.amperecomputing.com> <152d262e-641d-4bb1-9656-a13e049d62c4@redhat.com> <86h661wje4.wl-maz@kernel.org> <4a9fbdd9-ad23-44bc-8ba5-399f08068db4@redhat.com> <86cygpwfy0.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: eauger@redhat.com, gankulkarni@os.amperecomputing.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, christoffer.dall@arm.com, suzuki.poulose@arm.com, will@kernel.org, catalin.marinas@arm.com, coltonlewis@google.com, joey.gouly@arm.com, yuzenghui@huawei.com, darren@os.amperecomputing.com, vishnu@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250207_094538_517139_A1EB96ED X-CRM114-Status: GOOD ( 28.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jan 2025 17:52:10 +0000, Eric Auger wrote: > > Hi Marc, > > On 1/14/25 4:52 PM, Marc Zyngier wrote: > > On Tue, 14 Jan 2025 14:57:43 +0000, > > Eric Auger wrote: > >> > >> Hi Marc, > >> > >> On 1/14/25 3:38 PM, Marc Zyngier wrote: > >>> Hi Eric, > >>> > >>> On Tue, 14 Jan 2025 13:12:21 +0000, > >>> Eric Auger wrote: > >>>> > >>>> I also confirm that using a mailine edk2 fixed the issues I faced > >>>> previously (fed/rhel L1 guest not booting). > >>>> > >>>> I used Marc's nv-next branch and qemu rebase. > >>> > >>> When did you sample this branch? It is almost daily rebased at the > >>> moment, given that we keep piling up things in kvmarm/next. > >> 5 days ago. > > > > OK, so probably before I reapplied everything on top of kvmarm/next. > > Not necessarily a bad thing, just slightly older. The core NV code > > isn't rapidly changing anymore, with the exception of the recursive > > nesting stuff that I am currently rewriting. > > > >> > >> If you want me to test a specific branch, please let me know, esp. in > >> the context of latest series including > >> > >> [PATCH v2 00/17] KVM: arm64: Add NV GICv3 support > > > > That'd be the current nv-next then, which has all the series currently > > on the list, and a few more. > > > >>> > >>>> With a rhel L1 guest I can now boot buildroot, debian and rhel guest as > >>>> L2 (feat mainline edk2). For rhel, I tested different kinds of page size > >>>> combinations for L1/L2 (4k and 64kB) and it worked. > >>>> > >>>> I tested on AmpereOne and Grace-Hopper systems > >>> > >>> Thanks for the confirmation. I haven't had a chance to try QEMU yet, > >>> but I expect that save/restore will not work. Something to look into, > >> I have not tested this yet.I will give it a try. > > > > Thanks, that'd be super helpful. > > I confirm the migration fails when putting some registers on the dest > side. I will further investigate. I found at least one issue that could fail the migration. Before the VM starts running, we limit the feature set to the subset we actually support with NV. By doing this, we also change the value of IDreg fields that are not writable, because they describe features that we don't support. Obviously, that fails on restore. I need to have a think... M. -- Without deviation from the norm, progress is not possible.