From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13379C30658 for ; Sat, 29 Jun 2024 09:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h/EdodxCAPPamwtVa21IQ/PwH/2YhEw7zJ+KDK7WkD8=; b=FfD1zKitLYQiwf45zZbFcJ4y+J oHaL8aglp7HB7hjIK/B3ETBffjYLCjCtGKORUmkd8XamwUkCFcQ3rBLDwTwLGeiftIYNzIukBPFqZ oM2TpvZZBKVYVyp5zyVNcSTQLwfScsMC06qyqrHC0ABGuv/ckjppUglNuim8NbBpd63XmGBiFR1Ta NjYipDVQJMz/AO08s2bLFnmZk+oL2lY9jkzzRq8d0YWUsA7v/Xamt+CBH79OsEre/8EK9qHpTCobH l032jpLrLRLWFJYsOirYO5QtDUa5smmd3opkciQMGFF+5rWo6bXzc1YwtE4TD2/meeaKtb4/zPU2t zAMfwmVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNUEh-0000000GAgm-15zr; Sat, 29 Jun 2024 09:19:11 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNUEX-0000000GAdi-2M1O for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 09:19:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7DF75CE0E0B; Sat, 29 Jun 2024 09:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B891DC2BBFC; Sat, 29 Jun 2024 09:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719652737; bh=j0D4aM0HPc9hn8KU2KMSVB0fUvC5FVvdEkb1od0ha9Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cD0UhejHsdlBZZ3E3eAHSL8Un4GVWpUBluJ1RvU7gYspHeTFjW15HtYYj45XD2MzC SXCp1vENFFCX7mR+KpW1g1x20TOiEuPVhW8GsM9eVgw1s5x093wMmzIpoY0cS0fj07 IRiIsuxdySegvLIF5B9j89do6+hpD6KfcGBkFYRWYc/0gJmlz07fj8LD2BR77G++hB X/CG2pnH0mBmstXtBezVMjg3+n2w2TmQNqOO8EQG9ibkjHrK45siiWV6PVG8feFIqD 7ICHFhjt7uI01eryAuq806z2SRRLHAz0fYO28syLEngonpkS5HeeSEtAOZeCdGtnXs NJY1agnLr6+cA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sNUER-008Mh4-6l; Sat, 29 Jun 2024 10:18:55 +0100 Date: Sat, 29 Jun 2024 10:18:54 +0100 Message-ID: <86frswhzsx.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: Thomas Gleixner , LKML , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X] In-Reply-To: References: <20240623142137.448898081@linutronix.de> <20240623142235.024567623@linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240629_021902_095479_862C5653 X-CRM114-Status: GOOD ( 23.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 28 Jun 2024 23:24:56 +0100, Catalin Marinas wrote: > > Hi Thomas, > > On Sun, Jun 23, 2024 at 05:18:39PM +0200, Thomas Gleixner wrote: > > From: Thomas Gleixner > > > > The its_pci_msi_prepare() function from the ITS-PCI/MSI code provides the > > 'global' PCI/MSI domains. Move this function to the ITS-MSI parent code and > > amend the function to use the domain hardware size, which is the MSI[X] > > vector count, for allocating the ITS slots for the PCI device. > > > > Enable PCI matching in msi_parent_ops and provide the necessary update to > > the ITS specific child domain initialization function so that the prepare > > callback gets invoked on allocations. > > > > The latter might be optimized to do the allocation right at the point where > > the child domain is initialized, but keep it simple for now. > > > > Signed-off-by: Thomas Gleixner > > Signed-off-by: Anna-Maria Behnsen > > Signed-off-by: Shivamurthy Shastri > > Signed-off-by: Thomas Gleixner > > I just noticed guests (under KVM) failing to boot on my TX2 with your > latest branch. I bisected to this patch as the first bad commit. Reproduced here on a different host (M1), so this is not specific to TX2 (which would have been odd since KVM emulates the ITS entirely). I'll start digging. M. -- Without deviation from the norm, progress is not possible.