From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92287CD1288 for ; Wed, 3 Apr 2024 06:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6V1Ma537uRRZkC9ruGAyBo+z2x9gc2fE9eLwjy3MC6w=; b=bs9Z0vYKh7bqoX 5/4MMcm/2ktkaaELViPLHrlEqwVK3utiRx7ziIwZkZpjek0RbnPpaiaJCj+nZyYbIDStfv0mbf/Y1 DTW3412COj/Eno66RN1TExoO/01oee62xpuDEFqk9IEwVorC8lZIfPJRPZgoUf+nn0oUKJLh6bj6S UwsR/jbKD0eYP6KS7cBN6Qc2b4sd3kf4ZYO/DCzzW4LquF9cPGor5/Y6jfLUyOA0OJbumWvRlrIdE cTSRIXAJUWxGjsHBvI4Nk7drpyXIe2OeAZD1AuUZ6HEJ/1zQvEvgJZEFiZFZe/OYuUWFZSWffWlps eDYmByhlWzOwSKCTQJ8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrtfy-0000000EC5Q-3RQP; Wed, 03 Apr 2024 06:00:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrtfw-0000000EC48-20kN for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 06:00:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7C5C46121A; Wed, 3 Apr 2024 06:00:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31A2AC433C7; Wed, 3 Apr 2024 06:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712124043; bh=lm28SIM4QSvcW8ofLaB3A9XZSPLWwi+KGoQL55Ml0H0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KH+ZuPuoU4beU30S6hLa4jDXATT7BDGKl00AGr2JavQLUMPAnPjPued78VB9MzuZI zCjca5T7f5LgYWFQ2lQIPZ96OJaF9g7ZtFppclpUr37ICoXlKmO2FODCszTM3NXLyo RE+SCF6S/AzLdjgHB2Anm3sfS18hwQUg6Ze0ZKKbbRw5DEPOkjtTSwmEBZTkT18gj9 BURuikyYRnoIqHUTF4NFbUzZBEgmCwjuHiB8VaZEskLGMOlxX2Q5u318u4YZGHYb/L VrWLbmiz0fZpEz4xHddhairb/jGXs4VOEnZhjcORb4EyVZPI4ZX9xkAooDuEQz39Bm dd6akzZ//URNQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrtfs-000xdz-RZ; Wed, 03 Apr 2024 07:00:40 +0100 Date: Wed, 03 Apr 2024 07:00:40 +0100 Message-ID: <86frw3t27r.wl-maz@kernel.org> From: Marc Zyngier To: Tangnianyao Cc: , , , , Subject: Re: [PATCH] irqchip/gic-v3-its: Don't need VSYNC if VMAPP with {V, Alloc}=={0, x} In-Reply-To: References: <20240402114147.3788881-1-tangnianyao@huawei.com> <86jzlgt014.wl-maz@kernel.org> <8532b19b-361e-2234-92db-83f4d56bae19@huawei.com> <86il0zubh1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tangnianyao@huawei.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, guoyang2@huawei.com, wangwudi@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_230044_690934_6472B2A7 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 03 Apr 2024 03:18:51 +0100, Tangnianyao wrote: > > > > On 4/2/2024 21:43, Marc Zyngier wrote: > > On Tue, 02 Apr 2024 14:32:40 +0100, > > Tangnianyao wrote: > >> > >> > >> Thank you for quick fix, it would be great to remove this VSYNC. ITS handling VSYNC unmap > >> vpeid may waste some time, trigger exception and needed to be > >> handled. > > Do you actually see an exception being delivered from this? > > > > In any case, feel free to respin the patch after having tested this > > diff, with the commit message fixed and a Fixes: tag attached to it. > > In our developing implemenation, ITS would report RAS when doing vsync > and reaching an invalid vpe table entry. It is reasonable to report RAS, right? If a RAS error is the only reporting method you have, then I suspect you don't have much of a choice (the pseudocode indicates an IMPDEF SError for VSYNC). Shame this wasn't caught earlier. > It just reports, and kernel can still run normally regardless of > this RAS message. That really depends on the policy behind RAS errors. Looking forward to your respinning of this patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel