From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78AA4C54E58 for ; Mon, 11 Mar 2024 17:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XZMCrJJitrGIW4fo26Ydnl9fKJv/CkXjHoywBaGqYJ8=; b=Xz6tJzaS9aixOl GcSHzvj4wlwsLLVDUMMsDYYlFA2NhFScoocE1bokMB/Hm1DjUxyroqZYfDR9zwp6dmuY6yyBzb6s+ YnrI1jBthHlz5lc0R6qUs3aRqOh3gTQEgnPVrozRC9iQJfGFYCiR4J+GmgLSEyGrpfh7NKikQb1qO 6DvLoS9+ox0YYpevOTWuPOjWKVFsgDxTIRFUcZ2/NTsKsco12b+K3kEQjDLTrBdiq49iMEsvNSZ23 LvcC2gfQJp5gqOq7Fkn+/E8VS1jm8ojKsKgKykrN8Oa6L74JDidS4rcEzSuPGAgyTvLh0v57lwOx8 m0gBnMk1LitgfntNdK9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjjDs-00000002TZ2-1SJk; Mon, 11 Mar 2024 17:14:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjjDo-00000002TVt-1WW7 for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2024 17:13:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4C29E60F13; Mon, 11 Mar 2024 17:13:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E473FC433C7; Mon, 11 Mar 2024 17:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710177235; bh=36UHbz18A3pWWlXlgdb0fZqKa1wIimNOw8I3gCUNVZw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cGoUwFL3qpjsbSt0DcXZoUXWUNLAe0CsIER4SJijT3uqRvq5lp4hRugOSm74/muxe FHvM09e9BN7mbw8Sn99/W9ZrQ7rAkGpUDFPidkDSZBTpN4pYjcuf8DNcmjPSfelOc/ oJZipG17LlTImItJWsruLbzV3lEKwY4ES9GJe/MAk7DrwY84RVDruRJlf88ckUQwcq j4+0oxpdYDHkXldgKVsEVprPb92tzavqaj3G6YbCK3HmEMMzSbYDrngf8EIGFcI/Vp xX7GRf4/yWzSHwHXtLAhj7W7JfN4aRHOgZJhh6eaMYk1TRM3H5nUl2m+EJ79CGSFsA GqY6uqyoldLeg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rjjDk-00BTjZ-9E; Mon, 11 Mar 2024 17:13:52 +0000 Date: Mon, 11 Mar 2024 17:13:50 +0000 Message-ID: <86frww1yk1.wl-maz@kernel.org> From: Marc Zyngier To: Dongli Zhang Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , James Clark , Anshuman Khandual , Mark Brown Subject: Re: [PATCH 1/5] KVM: arm64: Add accessor for per-CPU state In-Reply-To: <36f0a5b5-01d7-23a8-b562-0470e0dddc22@oracle.com> References: <20240302111935.129994-1-maz@kernel.org> <20240302111935.129994-2-maz@kernel.org> <36f0a5b5-01d7-23a8-b562-0470e0dddc22@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dongli.zhang@oracle.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, james.clark@arm.com, anshuman.khandual@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_101356_653501_EF1365A7 X-CRM114-Status: GOOD ( 24.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 11 Mar 2024 04:50:23 +0000, Dongli Zhang wrote: > > > > On 3/2/24 03:19, Marc Zyngier wrote: > > In order to facilitate the introduction of new per-CPU state, > > add a new host_data_ptr() helped that hides some of the per-CPU > > verbosity, and make it easier to move that state around in the > > future. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/include/asm/kvm_host.h | 13 +++++++++++++ > > arch/arm64/kvm/arm.c | 2 +- > > arch/arm64/kvm/hyp/include/hyp/debug-sr.h | 4 ++-- > > arch/arm64/kvm/hyp/include/hyp/switch.h | 11 +++++------ > > arch/arm64/kvm/hyp/nvhe/psci-relay.c | 2 +- > > arch/arm64/kvm/hyp/nvhe/setup.c | 3 +-- > > arch/arm64/kvm/hyp/nvhe/switch.c | 4 ++-- > > arch/arm64/kvm/hyp/vhe/switch.c | 4 ++-- > > arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 4 ++-- > > arch/arm64/kvm/pmu.c | 2 +- > > 10 files changed, 30 insertions(+), 19 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 21c57b812569..3ca2a9444f21 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -492,6 +492,17 @@ struct kvm_cpu_context { > > u64 *vncr_array; > > }; > > > > +/* > > + * This structure is instanciated on a per-CPU basis, and contains > > instantiated? Yup, thanks. > > > May this patchset (at least the first, second, third and fifth) be qualified as > "non functional change" in the commit message? I disagree. No change is without any functional change unless it is only changing comments, and this one definitely introduces a bug. So I will not make any such statement. > That provides some hints when backporting this patchset to some old kernel in > the future. Thank you very much! two things: - you should not be backporting these patches. Full stop. They don't fix anything, they do not enable anything. They are just preliminary work for future things. - you really should perform a full review of what you are backporting in the light of the *target* kernel. I am never going to do this job (I only care about the current state), and that makes your earlier request even less realistic. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel