From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DDDE109C024 for ; Wed, 25 Mar 2026 14:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=68XGoki1n9lRZBu1LnWvj0bysBXjUXAgUwbasvwSOKE=; b=o8anehFBVTtmSdOIQiZJKaX6Py KYYSBtTCF6iW3CI3ctzQKeN7RtwWQ8eHZHRI8pJOIjmhirjMpKUa3BL5vRekWajoGHFS3DSYr0dBk xOXGz9j7t00vyVZgxZZ53aNUuKlKBZj8Mcg0kSli82qHM7lE07fEc+OUkfLc+JKz++I4PWrK6O2Ze 7pjAtbzCAYrXQ3TU3w6GbNn+P8QKOAPokjtMVyp32kb4kHuwv/2YE09oo7TH9Uxe8RD1y1DA3njbL 88efjM7LYqK/7ULfCfHgGOzzvNEUVKTgACJTzJgdzn8e4j/t5vU57yC9BvbR8no45rI+yWzD+LjbM jSSGFaiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5PIX-00000003cRu-104R; Wed, 25 Mar 2026 14:33:29 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5PIU-00000003cR0-3NLW for linux-arm-kernel@lists.infradead.org; Wed, 25 Mar 2026 14:33:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3F7F041AA9; Wed, 25 Mar 2026 14:33:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1177BC4CEF7; Wed, 25 Mar 2026 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774449206; bh=G4GBk+XM2N6la17JMHNsqGyO7EwPRwOUaGJIyT4vjC8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMedPZbsxffQ9XcfGQbMzHiA3QMR/kVJabk4N5ZtFQSPoyBMcS4Y2EGgIGInLasGk SFBGJzcwvaFas1fl2AXQTZBYB0JmKjs4X6wjVmvfpybPfKFO+r0GH7yc1gEGZy4CD6 yRAM6JQvc6+kotvbFy/x8qvEVQYDJUcjxu6Y2rvYkg/SisuJtxsftn5xlx9dv46QoJ gfHRy7+xF1m/EpMU0GwIALHu3gQChe/cIfLSx5NcvOw9rCETBttpg19J1Et/Sb+3gW HhyWAmUacL4OK9b8JbF3KD30KUXbGkBibnm1KpXjsg5/8eyrKiJLOEwWujiFmQ0MTy vHnfftML0LgRg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w5PIR-00000005arH-41VF; Wed, 25 Mar 2026 14:33:24 +0000 Date: Wed, 25 Mar 2026 14:33:23 +0000 Message-ID: <86h5q43rnw.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: Sebastian Ene , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, catalin.marinas@arm.com, joey.gouly@arm.com, oupton@kernel.org, suzuki.poulose@arm.com, tabba@google.com, vdonnefort@google.com, will@kernel.org, yuzenghui@huawei.com Subject: Re: [PATCH v2] KVM: arm64: Prevent the host from using an smc with imm16 != 0 In-Reply-To: References: <20260325113138.4171430-1-sebastianene@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, sebastianene@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, catalin.marinas@arm.com, joey.gouly@arm.com, oupton@kernel.org, suzuki.poulose@arm.com, tabba@google.com, vdonnefort@google.com, will@kernel.org, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260325_073326_886519_FD5E9A51 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Mar 2026 13:28:05 +0000, Mark Rutland wrote: >=20 > On Wed, Mar 25, 2026 at 11:31:38AM +0000, Sebastian Ene wrote: > > The ARM Service Calling Convention (SMCCC) specifies that the function > > identifier and parameters should be passed in registers, leaving the > > 16-bit immediate field of the SMC instruction un-handled. >=20 > That's not quite right; the SMCCC spec says callers must use immediate > 0. >=20 > See https://developer.arm.com/documentation/den0028/h/ section 2.10 > ("SME and HVC immediate value"), which says: >=20 > | =E2=80=A2 For all compliant calls, an SMC or HVC immediate value of zer= o must be > | used. > | =E2=80=A2 Nonzero immediate values in SMC instructions are reserved. > | =E2=80=A2 Nonzero immediate values in HVC instructions are designated f= or use by > | hypervisor vendors. >=20 > > Currently, our pKVM handler ignores the immediate value, which could le= ad > > to non-compliant software relying on implementation-defined behavior. > > Enforce the host kernel running under pKVM to use an immediate value > > of 0 by decoding the ISS from the ESR_EL2 and return a not supported > > error code back to the caller. >=20 > From my PoV, it'd be fine to turn a non-zero immediate into an UNDEF: I disagree. If SMC can be handled at all, then it cannot UNDEF based on the immediate -- the is no provision for that in the architecture. If it can UNDEF, then it must UNDEF always (as if SCR_EL3.SMD =3D=3D 1). Thanks, M. --=20 Without deviation from the norm, progress is not possible.