From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A569D0D785 for ; Fri, 11 Oct 2024 12:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4JqzbQCDUcSie1mFRpAXOYgyBDCXqFdhE21brHSasP4=; b=2ypjAN0ATY6jKYExMcz3aOQuPh JJH6nCx9nzLsmYw1VK2K0+6jxBTQaobzgzNKfXbdaNS6z8nNlP5WbbNl4qR6FR9kWA1Wr9KLanq3J 3IX3CMWzOxTRtMNzTiLUarY/BdYkjy43aeoJIWRKcL3OZyh5F2khkmTu2tzTyv8XJJXzhsiJWM/e2 ZbeNbTU5Yai8CEzmx9q0msi3fZcLDtxh2yXe2wAib72dgYBmEdHTFmq3hUYedhr+fnA8k9oBCb8HW uQLFG+fFft8Drtm91nd6+2SaWCU2Pfe/S2TJuM0cRi45vFxKbh2+fu4ao2d7rOB7cy+VnT9O8m8Tz W4rtkS0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szFCJ-0000000GMqg-3oCg; Fri, 11 Oct 2024 12:56:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szFAm-0000000GMal-0xO5; Fri, 11 Oct 2024 12:55:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 630FD5C5D11; Fri, 11 Oct 2024 12:55:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253F4C4CEC3; Fri, 11 Oct 2024 12:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728651310; bh=XT4qnBUKa3a1vSK5tJQUDSalL8lZA3BStEeYDOxhiyE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bxKmURlSi26SJe+QK4PGRX/Ogihvq7QIVMr0xUkNhvMtAINqZYYntZBEmNvBhXPzx xaQCgdyiANh8t3XzU1lUElo5+68IFooOi7w967UeZ4uBwr6loXlVb5zk3DL1pKqXt6 HBAY4AsSFxH7PoAyDc6zDcqNdJdwwUxb24R7cB1INpTJWpCOEqUw6OP69pfvqNeZbC Vp88tRv635qLdAkY5kchac2l6VKVhUPnICZg2BkQ2S5Mw0CUWfwf+IM4MLzHLqZKMT pfBsODaZQhvykSctTNHB5AQS0tLN6OjiebakwN3EDPLMXixs4xCDyUOUGpJp+oxxoE dWSEZjuQ+PXGA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1szFAg-002Y12-L7; Fri, 11 Oct 2024 13:55:06 +0100 Date: Fri, 11 Oct 2024 13:55:05 +0100 Message-ID: <86h69i6bpy.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: Nathan Chancellor , Mark Brown , Will Deacon , Jonathan Corbet , Andrew Morton , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , David Spickett , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v13 11/40] arm64/gcs: Provide basic EL2 setup to allow GCS usage at EL0 and EL1 In-Reply-To: References: <20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org> <20241001-arm64-gcs-v13-11-222b78d87eee@kernel.org> <20241009204903.GA3353168@thelio-3990X> <86msjc56mi.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, nathan@kernel.org, broonie@kernel.org, will@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, arnd@arndb.de, oleg@redhat.com, ebiederm@xmission.com, shuah@kernel.org, rick.p.edgecombe@intel.com, debug@rivosinc.com, ardb@kernel.org, Szabolcs.Nagy@arm.com, kees@kernel.org, hjl.tools@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, fweimer@redhat.com, brauner@kernel.org, thiago.bauermann@linaro.org, ross.burton@arm.com, david.spickett@arm.com, yury.khrustalev@arm.com, wilco.dijkstra@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_055512_382467_C3C97600 X-CRM114-Status: GOOD ( 25.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Oct 2024 18:16:52 +0100, Catalin Marinas wrote: > > On Thu, Oct 10, 2024 at 04:18:13PM +0100, Marc Zyngier wrote: > > From 20c98d2647c11db1e40768f92c5998ff5d764a3a Mon Sep 17 00:00:00 2001 > > From: Marc Zyngier > > Date: Thu, 10 Oct 2024 16:13:26 +0100 > > Subject: [PATCH] KVM: arm64: Shave a few bytes from the EL2 idmap code > > > > Our idmap is becoming too big, to the point where it doesn't fit in > > a 4kB page anymore. > > > > There are some low-hanging fruits though, such as the el2_init_state > > horror that is expanded 3 times in the kernel. Let's at least limit > > ourselves to two copies, which makes the kernel link again. > > > > At some point, we'll have to have a better way of doing this. > > > > Reported-by: Nathan Chancellor > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/20241009204903.GA3353168@thelio-3990X > > Thanks Marc for the quick fix. It looks fine to me, it will keep the > linker quiet for a while. I pushed it to arm64 for-kernelci for the time > being, see if anything falls apart. I'll apply it properly once it gets > a bit more testing. Works for me. Bu if that helps, I can also queue it as a KVM fix for 6.12, leaving the GCS branch unencumbered. Just let me know. M. -- Without deviation from the norm, progress is not possible.