From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A99DAC30658 for ; Fri, 28 Jun 2024 16:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bLlYZJlX+xtRudHSMfrJr7Q+U3NPYS92pMhq2I2kJ8g=; b=JG8OC4a6whw1KzdeUMlFpNYzJg plCiE7s2waUiDdq4Xo9XXI1Z++Yj4e2ngKze/+MAatPMEcy0xFMzOi2470zRUUxr4b87fABwy6kqI 1sU23dxJCMLwckTa43nTCWZ0lxYn6indp0eVK2b6rjgn3bfltqfY2jnITouDOROQVAiqkSEVLJ4Qk Bs51wGlDBZgDufeuoKe0rzaNr8u5V3EBh0oyiyyIYem0Wra4IgRKhNvivgY/dHvrJIA/PX7yinKvE t+f+sTGktlvSJZPVh0kwlcMXh6DUApsA0TayUxBBuMRnjKnAJQaBNFiC16zpUwJ7396ex92hrE4sa vznj+LOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNEpQ-0000000EPZN-2OiF; Fri, 28 Jun 2024 16:52:04 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNEpG-0000000EPWy-2sQx for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 16:51:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 90746CE4184; Fri, 28 Jun 2024 16:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7F74C116B1; Fri, 28 Jun 2024 16:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719593511; bh=6SF7A+ZNqwLAqeFjYgbJmC5zX/tLtGlaJW4FGn4HR+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cee/s26US9bT01/FuKcEby7DOkNu/vgdighuNLNuKJEZXTJPs27YAWe2Jd5+m6qzc JphPSvI8NOHrUpGmAsk295Lw/f1hmXrRsyb6p2sCcVfNgEdn403t5+O99+ILh6sIjX UT4gkUV8ZBKcUbdrbDykO2WeuCuvutyjHtRgJ+YKBlbkHryAQFEJi5Pr55D2HMYT7f l7XFN3tn8tsbRMwM4w1X5wpwQVtEJFxEt18MsnKyEJK9xAcjCDY+wAakXxw2zfBjYW gddLqU4zwHTz0gtCdT/ctX9ITk/eyqxjNBBOaUgUg7nRNQEo9eGInWmYipnWpA0xsY ubj5vzzgRwbbw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sNEpB-008DCa-He; Fri, 28 Jun 2024 17:51:49 +0100 Date: Fri, 28 Jun 2024 17:51:49 +0100 Message-ID: <86h6ddhuxm.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/gic-v3: Pass GICV index to gic_of_setup_kvm_info() In-Reply-To: <2eb7c6e9c142f08cbe34bc6f423778f389ac67f4.1719577252.git.geert+renesas@glider.be> References: <2eb7c6e9c142f08cbe34bc6f423778f389ac67f4.1719577252.git.geert+renesas@glider.be> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: geert+renesas@glider.be, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_095155_096958_32FCFCBE X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Fri, 28 Jun 2024 13:23:29 +0100, Geert Uytterhoeven wrote: > > The caller of gic_of_setup_kvm_info() already queried DT for the value > of the #redistributor-regions property. So just calculate and pass the > GICV index, instead of doing the DT look-up again in the callee. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/irqchip/irq-gic-v3.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 1f70262742f3b7c7..9c03b63277ba5b2b 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -2185,11 +2185,10 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) > of_node_put(parts_node); > } > > -static void __init gic_of_setup_kvm_info(struct device_node *node) > +static void __init gic_of_setup_kvm_info(struct device_node *node, u32 gicv_idx) > { > int ret; > struct resource r; > - u32 gicv_idx; > > gic_v3_kvm_info.type = GIC_V3; > > @@ -2197,11 +2196,6 @@ static void __init gic_of_setup_kvm_info(struct device_node *node) > if (!gic_v3_kvm_info.maint_irq) > return; > > - if (of_property_read_u32(node, "#redistributor-regions", > - &gicv_idx)) > - gicv_idx = 1; > - > - gicv_idx += 3; /* Also skip GICD, GICC, GICH */ Please keep the comment and/or make this '3' a #define so that we can easily remember why we're adding some apparently random number. > ret = of_address_to_resource(node, gicv_idx, &r); > if (!ret) > gic_v3_kvm_info.vcpu = r; > @@ -2292,7 +2286,7 @@ static int __init gic_of_init(struct device_node *node, struct device_node *pare > gic_populate_ppi_partitions(node); > > if (static_branch_likely(&supports_deactivate_key)) > - gic_of_setup_kvm_info(node); > + gic_of_setup_kvm_info(node, nr_redist_regions + 3); > return 0; > > out_unmap_rdist: With that fixed, Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.