From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19322C4332F for ; Sun, 5 Nov 2023 09:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+W0Q6KQfJXM1/08PtfIClJ3xFq/gfElNgK1K9PSJw1Y=; b=Qf8gIkHiduGXlB 5hcOCfRGv6xBw7D8CDw9WKmjY4UZSNHfgoObQ3mvpLAzBCvTKIWKvvclIWgNFS1l8ctffb1PSTevK loGqzhgi/IRwcsYul9eVTC8o4I0Uj/1pjQNngSfpCGJksLAJCXitOIJLxEkvVoVj+piwU/7bkxRG4 CZYLqCTRi3XqMaRbEdwR9+OqILUTzQcYmFdIdyTMTaXxChZYTxvqBlZUg598rQhLFsQzeleEhcDMH PqnNy425BOlW0aqJT3mwVITQMbPf9aEoJKeHOevC6rsnd/fXX+S1mddABsv5G4qCSYcEcmESrNYTT t4xbKE4ST5JwP0QPTtkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzZoK-00EhAk-20; Sun, 05 Nov 2023 09:52:52 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzZoH-00Eh9V-1a for linux-arm-kernel@lists.infradead.org; Sun, 05 Nov 2023 09:52:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6B802CE062B; Sun, 5 Nov 2023 09:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A26FBC433C7; Sun, 5 Nov 2023 09:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699177965; bh=drfUFyPMzU3Bg3c3IywoO6Ivb5hbZ/FS+ph9zFV4edE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F/nTnIxoXbLyD413SC8yDGcVFKQa0ojQWqfrfJGCs7P+zYQ7kE66W6EwpTFwrTqnm 30vqMzlG8SaVJse0px5fVUd0uOyS1G7Ua9rx/akobiDCkr1HAb6sfmFKYb+mRK4Gt9 wkM6snUafYSq8hlXmLJ02D+mgONCpZsijIJtko8QdPovSjqmz8T+Y6yxkDNWNp1jDJ lI/ReiuNSKvUNb7em+sbT9zYt/jsBMa/ugQW0fGKZiFsJCpXcPiNv6DE82eiVoKweX Lhel1VjoZM7EMIOOBOY/mOiOOKUwTHcD2XuSpKOOJYoPl33rXROB8nF+0ev7ZbDmyp 9u2hiilHUckgQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qzZoB-00AUeW-8B; Sun, 05 Nov 2023 09:52:43 +0000 Date: Sun, 05 Nov 2023 09:52:42 +0000 Message-ID: <86h6m01q8l.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: Fang Xiang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4] irqchip/gic-v3-its: Flush ITS tables before writing GITS_BASER registers in non-coherent GIC designs. In-Reply-To: <87bkc8inps.ffs@tglx> References: <20231030083256.4345-1-fangxiang3@xiaomi.com> <87o7g96duv.wl-maz@kernel.org> <87bkc8inps.ffs@tglx> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, fangxiang3@xiaomi.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231105_015249_725879_D009ED2A X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 05 Nov 2023 08:55:11 +0000, Thomas Gleixner wrote: > > On Sat, Nov 04 2023 at 09:56, Marc Zyngier wrote: > > On Mon, 30 Oct 2023 08:32:56 +0000, > > Fang Xiang wrote: > >> > >> In non-coherent GIC design, ITS tables should be clean and flushed > >> to the PoV of the ITS before writing GITS_BASER registers, otherwise > >> the ITS would read dirty tables and lead to UNPREDICTABLE behaviors. > >> > >> The ITS always got clean tables in initialization with this fix, by > >> observing the signals from GIC. > >> > >> Furthermore, hoist the quirked non-shareable attributes earlier to > >> save effort in tables setup. > >> > >> Suggested-by: Marc Zyngier > >> Signed-off-by: Fang Xiang > >> Tested-by: Fang Xiang > > > > Reviewed-by: Marc Zyngier > > Shouldn't this have a Fixes tag? My guess is: > > a8707f553884 ("irqchip/gic-v3: Add Rockchip 3588001 erratum workaround") Yes, that's indeed the point where the out of sequence programming can occur. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel