From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0B12C43603 for ; Fri, 6 Dec 2019 19:36:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 835C1206DB for ; Fri, 6 Dec 2019 19:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AO7bIJQJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 835C1206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kehZl9IXF5rH/hOVKTpzO3fTpb1bmquXw4Xvozeq2sc=; b=AO7bIJQJCVEK1p W+fIZkMpd8ktfwpT2juaoGmYciRU7D13ukj9ne/xoyeutzf84oJmZMtLTYhZ3oX7puo1A0Qkbl+Ur QI2Uc6qE/+EUTBIw8XFLGPDceEuEO7d6WWDqZJGLw/EKqO+s6d7qN63H1VE46rZ24UHCAjNbgeUoh Jo1+y1eHK5pX5E+XS2IflJ7xYwvqWu7Uoq97TqOlPWpYDWpH5kSSuQ+i99nvJhYoSifecdzDo5jkn HQtVvunSVRGYg4rhiwYKRPr41nawrkr3BCqsX1YxC7a5TXuEw9r6Xwu6oCYGTC2uZTgTWZhmDXGMI zLIG7TutOEPITM+d4BbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idJOa-0004yF-Mh; Fri, 06 Dec 2019 19:36:08 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idJOU-0004xU-1H for linux-arm-kernel@lists.infradead.org; Fri, 06 Dec 2019 19:36:06 +0000 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1idJOP-0000fB-Iw; Fri, 06 Dec 2019 20:35:57 +0100 Date: Fri, 06 Dec 2019 19:35:56 +0000 Message-ID: <86h82dz1pf.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Subject: Re: [PATCH 2/2] kvm/arm64: don't log IMP DEF sysreg traps In-Reply-To: <20191205180652.18671-3-mark.rutland@arm.com> References: <20191205180652.18671-1-mark.rutland@arm.com> <20191205180652.18671-3-mark.rutland@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, alexandru.elisei@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, kvmarm@lists.cs.columbia.edu, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_113602_223225_B35584DF X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 05 Dec 2019 18:06:52 +0000, Mark Rutland wrote: > > We don't intend to support IMPLEMENATION DEFINED system registers, but > have to trap them (and emulate them as UNDEFINED). These traps aren't > interesting to the system administrator or to the KVM developers, so > let's not bother logging when we do so. > > Signed-off-by: Mark Rutland > Cc: Alexandru Elisei > Cc: James Morse > Cc: Julien Thierry > Cc: Marc Zyngier > Cc: Suzuki K Poulose > Cc: kvmarm@lists.cs.columbia.edu > --- > arch/arm64/kvm/sys_regs.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index d128abd38656..61f019104841 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2233,6 +2233,12 @@ int kvm_handle_cp14_32(struct kvm_vcpu *vcpu, struct kvm_run *run) > NULL, 0); > } > > +static bool is_imp_def_sys_reg(struct sys_reg_params *params) > +{ > + // See ARM DDI 0487E.a, section D12.3.2 > + return params->Op0 == 3 && (params->CRn & 0b1011) == 0b1011; > +} > + > static int emulate_sys_reg(struct kvm_vcpu *vcpu, > struct sys_reg_params *params) > { > @@ -2248,6 +2254,8 @@ static int emulate_sys_reg(struct kvm_vcpu *vcpu, > > if (likely(r)) { > perform_access(vcpu, params, r); > + } else if (is_imp_def_sysreg(params)) { Meh. Doesn't compile... :-( Fixing it locally. M. -- Jazz is not dead, it just smells funny. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel